Extract + Drizzle `flows` aggregate (flows + runs + audit + legacy_forge_calls) #843

New issue

Closed

opened 2026-05-04 20:28:47 +00:00 by claude-desktop · 1 comment

claude-desktop commented

2026-05-04 20:28:47 +00:00

Collaborator

As a maintainer, I want all flow-related tables (flows, flow_runs, flow_node_runs, flow_audit, legacy_forge_calls) split out and rewritten on Drizzle, so that the largest SQL surface in db.ts (~25 fns) lives in one cohesive module with type-safe queries.

Acceptance criteria

Extraction

flows.ts + flow-runs.ts + flow-audit.ts + legacy-forge-calls.ts (split by table for review-ability).
All ~25 fns moved (audit db.ts:1571-1953 for exhaustive list): listFlows, getFlow, upsertFlow, seedDefaultFlow, deleteFlow, insertFlowRun, finishFlowRun, getFlowRun, listFlowRuns, deleteFlowRun, pruneFlowRunsOlderThan, insertFlowNodeRun, listFlowNodeRuns, listFlowNodeIntentsSince, insertFlowAudit, listFlowAudit, getFlowAuditByVersion, withFlowTransaction, insertLegacyForgeCall, listLegacyForgeCallsSince, resetLegacyForgeCalls.

Transactions

withFlowTransaction(fn) keeps same signature; internally wraps Drizzle + raw via shared getDb().transaction(...) so other-aggregate raw SQL inside the closure still participates.

Drizzle

schema/flows.ts + schema/flow-runs.ts + schema/flow-audit.ts + schema/legacy-forge-calls.ts.
All fns rewritten.

Tests

flows-db.test.ts green.
Cross-aggregate transaction test: open withFlowTransaction, write to flows (Drizzle) + holds (Drizzle from #840) + still-raw aggregate, rollback, all changes reverted.

Out of scope

Flow-runner business logic (domain/flows/) — only DB layer changes.

References

apps/server/src/infrastructure/database/db.ts:1571-1953.
apps/server/src/domain/flows/flow-dispatch.ts (caller).
Foundation story (#839) must merge first.

**As a** maintainer, **I want** all flow-related tables (`flows`, `flow_runs`, `flow_node_runs`, `flow_audit`, `legacy_forge_calls`) split out and rewritten on Drizzle, **so that** the largest SQL surface in `db.ts` (~25 fns) lives in one cohesive module with type-safe queries. ## Acceptance criteria ### Extraction - [ ] `flows.ts` + `flow-runs.ts` + `flow-audit.ts` + `legacy-forge-calls.ts` (split by table for review-ability). - [ ] All ~25 fns moved (audit `db.ts:1571-1953` for exhaustive list): `listFlows`, `getFlow`, `upsertFlow`, `seedDefaultFlow`, `deleteFlow`, `insertFlowRun`, `finishFlowRun`, `getFlowRun`, `listFlowRuns`, `deleteFlowRun`, `pruneFlowRunsOlderThan`, `insertFlowNodeRun`, `listFlowNodeRuns`, `listFlowNodeIntentsSince`, `insertFlowAudit`, `listFlowAudit`, `getFlowAuditByVersion`, `withFlowTransaction`, `insertLegacyForgeCall`, `listLegacyForgeCallsSince`, `resetLegacyForgeCalls`. ### Transactions - [ ] `withFlowTransaction(fn)` keeps same signature; internally wraps Drizzle + raw via shared `getDb().transaction(...)` so other-aggregate raw SQL inside the closure still participates. ### Drizzle - [ ] `schema/flows.ts` + `schema/flow-runs.ts` + `schema/flow-audit.ts` + `schema/legacy-forge-calls.ts`. - [ ] All fns rewritten. ### Tests - [ ] `flows-db.test.ts` green. - [ ] Cross-aggregate transaction test: open `withFlowTransaction`, write to flows (Drizzle) + holds (Drizzle from #840) + still-raw aggregate, rollback, all changes reverted. ## Out of scope - Flow-runner business logic (`domain/flows/`) — only DB layer changes. ## References - `apps/server/src/infrastructure/database/db.ts:1571-1953`. - `apps/server/src/domain/flows/flow-dispatch.ts` (caller). - Foundation story (#839) must merge first.

claude-desktop added the

area:database

type:user-story

labels

2026-05-04 20:30:07 +00:00

claude-desktop added this to the ORM migration (Drizzle) milestone

2026-05-04 20:30:15 +00:00

claude-desktop added a new dependency

2026-05-04 21:47:30 +00:00

#844 Extract + Drizzle agents aggregate (preserve onAgentDelete hook)

claude-desktop added a new dependency

2026-05-04 21:47:30 +00:00