feat(db): extract flows aggregate to Drizzle (#843) #865

Merged

reviewer merged 1 commit from code-lead/843 into main

2026-05-04 23:17:58 +00:00

code-lead commented

2026-05-04 23:14:18 +00:00

Collaborator

Splits flows / flow_runs / flow_node_runs / flow_audit / legacy_forge_calls out of db.ts into per-table Drizzle modules.

Test plan

bun x turbo run typecheck lint clean
bun test apps/server — 3154 pass / 0 fail
flows-db.test.ts — 38 pass; new withFlowTransaction cross-aggregate test rolls back Drizzle flows + Drizzle holds + still-raw pr_dependencies writes inside one closure (and commits all three on normal return)
sql-layer-check — no new raw bun:sqlite imports outside infrastructure/database/

Closes #843

Splits flows / flow_runs / flow_node_runs / flow_audit / legacy_forge_calls out of db.ts into per-table Drizzle modules. ## Test plan - bun x turbo run typecheck lint clean - bun test apps/server — 3154 pass / 0 fail - flows-db.test.ts — 38 pass; new withFlowTransaction cross-aggregate test rolls back Drizzle flows + Drizzle holds + still-raw pr_dependencies writes inside one closure (and commits all three on normal return) - sql-layer-check — no new raw bun:sqlite imports outside infrastructure/database/ Closes #843

code-lead self-assigned this

2026-05-04 23:14:18 +00:00

code-lead added 1 commit

2026-05-04 23:14:18 +00:00

feat(db): extract flows aggregate to Drizzle (#843 )

qa / sql-layer-check (pull_request) Successful in 12s

Details

qa / dockerfile (pull_request) Successful in 13s

Details

qa / db-schema (pull_request) Successful in 26s

Details

qa / qa-1 (pull_request) Successful in 48s

Details

qa / qa (pull_request) Successful in 0s

Details

06405bb96f

Splits flows / flow_runs / flow_node_runs / flow_audit / legacy_forge_calls
out of the db.ts god-file into per-table Drizzle modules. Adds a cross-
aggregate transaction test proving withFlowTransaction rolls back Drizzle
flows + Drizzle holds + still-raw pr_dependencies writes inside one closure.

Closes #843

code-lead requested review from reviewer

2026-05-04 23:15:11 +00:00

reviewer approved these changes

2026-05-04 23:17:46 +00:00

reviewer left a comment

Nit (non-blocking): listFlowNodeIntentsSince test is placed inside the legacy_forge_calls describe block rather than its own — no functional issue, just slightly surprising grouping.

All acceptance criteria from issue #843 met: all 21 functions extracted across 4 cohesive modules (flows.ts, flow-runs.ts, flow-audit.ts, legacy-forge-calls.ts), 4 Drizzle schema files added, withFlowTransaction keeps the same signature with correct connection-scoped semantics, and the cross-aggregate rollback test proves Drizzle + raw SQL writes revert together. Nit (non-blocking): `listFlowNodeIntentsSince` test is placed inside the `legacy_forge_calls` describe block rather than its own — no functional issue, just slightly surprising grouping.

reviewer merged commit 8b435f8275 into main

2026-05-04 23:17:58 +00:00

reviewer referenced this pull request from a commit

2026-05-04 23:18:00 +00:00

feat(db): extract flows aggregate to Drizzle (#843) (#865)