charles/claude-hooks

Fork

You've already forked claude-hooks

Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

Foundation: Drizzle setup + nuke 17 hand-rolled migrations #839

New issue

Closed

opened 2026-05-04 20:27:55 +00:00 by claude-desktop · 0 comments

claude-desktop commented

2026-05-04 20:27:55 +00:00

Collaborator

Copy link

As a maintainer, I want Drizzle wired up alongside bun:sqlite with current schema captured as a single snapshot and all 17 hand-rolled migrations deleted, so that future schema changes are TS-driven and the migration ladder no longer carries dead one-shot data backfills.

Decision context (chat 2026-05-04): repo is pure-dev, no prod, no preservation needed. Wipe-and-reseed is acceptable.

Acceptance criteria

Deps + config

drizzle-orm + drizzle-kit added to apps/server/package.json.
drizzle.config.ts at apps/server/, dialect sqlite, driver bun:sqlite, output apps/server/src/infrastructure/database/drizzle/.
Schema directory apps/server/src/infrastructure/database/schema/ created (one file per aggregate, populated incrementally by later stories).
Convention: snake_case TS field names that mirror SQL column names (bridge style — no caller-side renames). Documented in new docs/database.md.

Snapshot generation

drizzle-kit generate produces 0000_init.sql capturing every table currently in agents.db.
Same for tasks.db → 0000_init_tasks.sql.
Diff check (sqlite3 .schema normalized vs generated SQL) is empty before merge.

Migration runner

ensureSchema(db) in db.ts rewritten: if agents table absent → run 0000_init.sql; else assume up-to-date.
Future migrations applied via drizzle-kit migrate style — read SQL files from drizzle/, apply in order, track applied set in __drizzle_migrations table.
All 17 runXxxMigration files in apps/server/src/infrastructure/database/migrations/ deleted.
All runXxxMigration imports + calls in db.ts removed.
task-store.ts::ensureSchema rewritten same pattern over tasks.db.

Tooling

just db-generate recipe — calls drizzle-kit generate.
just db-check recipe — fails CI if schema/ has drifted from generated SQL (no uncommitted migration).
CI step in .forgejo/workflows/qa.yml runs just db-check.

Wipe + reseed

Local ~/.local/state/claude-hooks/agents.db and tasks.db wiped manually before first boot.
Service boots, seedDefaultAgents + ensureDefaultForTypes populate defaults; OAuth re-flows trigger on next webhook.
just qa green.

Tests

All existing *.test.ts in infrastructure/database/ pass against new ensureSchema.
New test: ensureSchema on fresh DB produces schema bit-identical to live agents.db .schema (after normalization).

Out of scope

Rewriting any aggregate's CRUD to Drizzle (covered in #2–#10 of this milestone).
Splitting db.ts god-file (begins in pilot story).
Deleting db.ts itself (final cleanup story).

References

Decision: pure-dev, no prod, no preservation — chat 2026-05-04.
docs/inheritance-contract.md — Drizzle migrations must respect add-only.
apps/server/src/infrastructure/database/db.ts:64-600 — current ensureSchema.

**As a** maintainer, **I want** Drizzle wired up alongside `bun:sqlite` with current schema captured as a single snapshot and all 17 hand-rolled migrations deleted, **so that** future schema changes are TS-driven and the migration ladder no longer carries dead one-shot data backfills. Decision context (chat 2026-05-04): repo is pure-dev, no prod, no preservation needed. Wipe-and-reseed is acceptable. ## Acceptance criteria ### Deps + config - [ ] `drizzle-orm` + `drizzle-kit` added to `apps/server/package.json`. - [ ] `drizzle.config.ts` at `apps/server/`, dialect `sqlite`, driver `bun:sqlite`, output `apps/server/src/infrastructure/database/drizzle/`. - [ ] Schema directory `apps/server/src/infrastructure/database/schema/` created (one file per aggregate, populated incrementally by later stories). - [ ] Convention: **snake_case TS field names** that mirror SQL column names (bridge style — no caller-side renames). Documented in new `docs/database.md`. ### Snapshot generation - [ ] `drizzle-kit generate` produces `0000_init.sql` capturing every table currently in `agents.db`. - [ ] Same for `tasks.db` → `0000_init_tasks.sql`. - [ ] Diff check (`sqlite3 .schema` normalized vs generated SQL) is empty before merge. ### Migration runner - [ ] `ensureSchema(db)` in `db.ts` rewritten: if `agents` table absent → run `0000_init.sql`; else assume up-to-date. - [ ] Future migrations applied via `drizzle-kit migrate` style — read SQL files from `drizzle/`, apply in order, track applied set in `__drizzle_migrations` table. - [ ] All 17 `runXxxMigration` files in `apps/server/src/infrastructure/database/migrations/` deleted. - [ ] All `runXxxMigration` imports + calls in `db.ts` removed. - [ ] `task-store.ts::ensureSchema` rewritten same pattern over `tasks.db`. ### Tooling - [ ] `just db-generate` recipe — calls `drizzle-kit generate`. - [ ] `just db-check` recipe — fails CI if `schema/` has drifted from generated SQL (no uncommitted migration). - [ ] CI step in `.forgejo/workflows/qa.yml` runs `just db-check`. ### Wipe + reseed - [ ] Local `~/.local/state/claude-hooks/agents.db` and `tasks.db` wiped manually before first boot. - [ ] Service boots, `seedDefaultAgents` + `ensureDefaultForTypes` populate defaults; OAuth re-flows trigger on next webhook. - [ ] `just qa` green. ### Tests - [ ] All existing `*.test.ts` in `infrastructure/database/` pass against new `ensureSchema`. - [ ] New test: `ensureSchema` on fresh DB produces schema bit-identical to live `agents.db .schema` (after normalization). ## Out of scope - Rewriting any aggregate's CRUD to Drizzle (covered in #2–#10 of this milestone). - Splitting `db.ts` god-file (begins in pilot story). - Deleting `db.ts` itself (final cleanup story). ## References - Decision: pure-dev, no prod, no preservation — chat 2026-05-04. - `docs/inheritance-contract.md` — Drizzle migrations must respect add-only. - `apps/server/src/infrastructure/database/db.ts:64-600` — current `ensureSchema`.

claude-desktop referenced this issue

2026-05-04 20:28:10 +00:00

Pilot: extract holds aggregate to Drizzle #840

claude-desktop referenced this issue

2026-05-04 20:28:20 +00:00

Migrate operator_sessions.ts to Drizzle #841

claude-desktop referenced this issue

2026-05-04 20:28:32 +00:00

Extract + Drizzle dead_letter_prs + watched_repos aggregates #842

claude-desktop referenced this issue

2026-05-04 20:28:47 +00:00

Extract + Drizzle flows aggregate (flows + runs + audit + legacy_forge_calls) #843

claude-desktop referenced this issue

2026-05-04 20:29:04 +00:00

Extract + Drizzle agents aggregate (preserve onAgentDelete hook) #844

claude-desktop referenced this issue

2026-05-04 20:29:17 +00:00

Extract + Drizzle service_config + label_catalog + agent_type_* aggregates #845

claude-desktop referenced this issue

2026-05-04 20:29:27 +00:00

Migrate task-store.ts to Drizzle (separate tasks.db client) #847

claude-desktop referenced this issue

2026-05-04 20:29:37 +00:00

Migrate sessions.ts to Drizzle #848

claude-desktop added the

area:database

type:user-story

labels

2026-05-04 20:30:00 +00:00

claude-desktop added this to the ORM migration (Drizzle) milestone

2026-05-04 20:30:12 +00:00

code-lead was assigned by architect

2026-05-04 20:35:12 +00:00

code-lead referenced this issue from a commit

2026-05-04 21:10:36 +00:00

feat(db): drizzle setup + nuke 17 hand-rolled migrations (#839)

code-lead referenced this issue from a pull request that will close it,

2026-05-04 21:11:01 +00:00

feat(db): drizzle setup + nuke 17 hand-rolled migrations #854

reviewer closed this issue

2026-05-04 21:25:35 +00:00

No Branch/Tag specified

main

chore/sync-pre-push-from-forge-base

fix/flows-yaml-dispatch-identity

feat/board-tap-to-assign

dev/1107

code-lead/1106

code-lead/1108

dev/1104

code-lead/1103

code-lead/1080

dev/1087

feat/flows-yaml-ci-events

chore/board-drop-stalled-and-density-controls

fix/flows-yaml-routes-always-register

flows-yaml/api-defaults

dev/1023

fix/event-log-history-bleed

fix/janitor-fix-ci-logs-and-cap

dev/1022

fix/board-card-provider

code-lead/1036

dev/1025

code-lead/1020

dev/1017

code-lead/1026

feat/web-shortcut-registry-1018

dev/1015

code-lead/1009

code-lead/1008

dev/975

dev/969

dev/973

dev/967

code-lead/968

code-lead/953

dev/970

dev/976

code-lead/966

code-lead/956

code-lead/951

dev/962

dev/963

dev/977

dev/955

dev/983

dev/961

dev/974

code-lead/950

code-lead/939

dev/941

dev/940

dev/937

dev/938

dev/936

dev/935

feat/web-i18n-fr-locale

feat/spec-editor-ui-polish

chore/drop-legacy-compat

fix/skills-drop-preview-pane

fix/882-skills-safety-rail

dev/911

dev/909

dev/923

dev/917

dev/915

feat/879-sr11-m2-drop-legacy-skill

code-lead/873

dev/881

code-lead/869

dev/867

code-lead/845

code-lead/843

code-lead/844

dev/837

dev/861

dev/849

code-lead/837

code-lead/842

fix/dedup-rebase-inflight

dev/838

code-lead/847

dev/833

code-lead/848

pr/838

code-lead/841

feat/settings-save-bar/836

code-lead/840

dev/846

code-lead/839

dev/832

fix/board-sse-stale-cache

dev/834

dev/835

feat/settings-breadcrumbs

feat/forge-oauth-credentials

refactor/service-config-consolidation

feat/agent-tokens-to-secrets

feat/gitlab-oauth-to-db

feat/authelia-rip-and-voice-fixes

fix/rebase-storm-and-dead-letter

code-lead/797

code-lead/796

dev/811

code-lead/798

dev/810

code-lead/795

dev/808

code-lead/794

dev/805

dev/802

dev/803

feat/avatar-menu-settings-entry

feat/per-agent-token-tracking

dev/793

dev/747

dev/752

code-lead/790

code-lead/759

dev/756

dev/760

dev/741

dev/767

dev/740

dev/709

dev/644

dev/637

boss/614

dev/600

dev/611

dev/585

fix/login-bonus-fixes

boss/544

dev/542

refactor/api-prefix-and-session-gate

dev/489

boss/531

boss/518

dev/499

boss/516

dev/530

dev/517

dev/519

dev/515

dev/522

dev/503

dev/471

boss/329

dev/417

dev/418

dev/402

boss/327

dev/334

dev/332

boss/326

boss/325

dev/331

boss/324

boss/323

boss/322

dev/294

test/s11-task-analytics

dev/262

boss/270

dev/268

foreman/ui-consolidation-spec

dev/234

boss/196

boss/176

boss/164

fix/124-session-persist-bind

boss/52

dev/87

boss/73

dev/77

dev/81

dev/82

boss/79

dev/42

dev/35

boss/7

No results found.

Labels

Clear labels

area:agents

Agent types, pool scheduling, per-instance config

area:dashboard

Dashboard UI and observability surfaces

area:database

DB layer — schema, migrations, ORM, raw SQL

area:design

UI/UX mockup work — routes to designer agent

area:design-review

Design review dispatch — routes to design-reviewer agent

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

area:infra

Deployment, isolation, containers, systemd units

area:meta

Tracking, scaffolding, project setup

area:security

Security — routes to reviewer-security (opus)

area:sessions

Session-id store, Claude SDK resume logic

area:webhook

Forgejo webhook routing and handlers

area:workdir

Clone cache, worktrees, git identity

security

Security-sensitive issue

Tracking or decisions, not implementation work

No labels

Milestone

Clear milestone

No items

No milestone

ORM migration (Drizzle)

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

code-lead

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks#839

Reference in a new issue

Repository

charles/claude-hooks

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns