Extract + Drizzle `agents` aggregate (preserve `onAgentDelete` hook) #844

New issue

Closed

opened 2026-05-04 20:29:04 +00:00 by claude-desktop · 1 comment

claude-desktop commented

2026-05-04 20:29:04 +00:00

Collaborator

Copy link

As a maintainer, I want the core agents + agent_provider_state + agent_provider_events tables split out and Drizzled, so that the most-imported DB surface gets type-safe column refs without breaking the registerOnAgentDelete lifecycle hook.

Acceptance criteria

Extraction

agents-store.ts + agent-provider.ts (split by table cluster).
All ~20 fns moved: listAgents, getAgent, listAgentsByType, createAgent, updateAgent, deleteAgent, getProviderState, listProviderStates, bumpTier, resetTier, setProviderPaused, listProviderEvents, parseMatchLabels, parsePlugins, seedDefaultAgents, ensureDefaultForTypes, migrateForLegacyTypeRenames, migrateSecretsForLegacyTypeRenames, migrateTokenFilesForLegacyTypeRenames, dropOrphanAgentDefault, applyDefaultMatchLabels, applyGlobalCavemanModeFlip, clearModelOverrideForType.
All callers updated.

Hooks preserved

registerOnAgentDelete(fn) API unchanged.
Drizzle-based deleteAgent still fires registered callbacks before/after delete (verify with existing tests).

Drizzle

schema/agents.ts + schema/agent-provider.ts.
match_labels, plugins, notes JSON-encoded TEXT columns — text({ mode: "json" }).$type<...>() with explicit NULL handling for tri-state plugins (NULL = inherit, [] = empty override, array = explicit list). Document in schema file.
Field-level inheritance resolver (row override (non-null) → type default) preserved.

Tests

Relevant db.test.ts slices extracted, green.
onAgentDelete callback fires once per delete (not zero, not twice).

Out of scope

Resolver layer (domain/agent-config/resolver.ts) — separate story (#845).

References

apps/server/src/infrastructure/database/db.ts:600-1500.
db.ts:862 — registerOnAgentDelete.
Foundation story (#839) must merge first.

**As a** maintainer, **I want** the core `agents` + `agent_provider_state` + `agent_provider_events` tables split out and Drizzled, **so that** the most-imported DB surface gets type-safe column refs without breaking the `registerOnAgentDelete` lifecycle hook. ## Acceptance criteria ### Extraction - [ ] `agents-store.ts` + `agent-provider.ts` (split by table cluster). - [ ] All ~20 fns moved: `listAgents`, `getAgent`, `listAgentsByType`, `createAgent`, `updateAgent`, `deleteAgent`, `getProviderState`, `listProviderStates`, `bumpTier`, `resetTier`, `setProviderPaused`, `listProviderEvents`, `parseMatchLabels`, `parsePlugins`, `seedDefaultAgents`, `ensureDefaultForTypes`, `migrateForLegacyTypeRenames`, `migrateSecretsForLegacyTypeRenames`, `migrateTokenFilesForLegacyTypeRenames`, `dropOrphanAgentDefault`, `applyDefaultMatchLabels`, `applyGlobalCavemanModeFlip`, `clearModelOverrideForType`. - [ ] All callers updated. ### Hooks preserved - [ ] `registerOnAgentDelete(fn)` API unchanged. - [ ] Drizzle-based `deleteAgent` still fires registered callbacks before/after delete (verify with existing tests). ### Drizzle - [ ] `schema/agents.ts` + `schema/agent-provider.ts`. - [ ] `match_labels`, `plugins`, `notes` JSON-encoded TEXT columns — `text({ mode: "json" }).$type<...>()` with explicit NULL handling for tri-state `plugins` (NULL = inherit, `[]` = empty override, array = explicit list). Document in schema file. - [ ] Field-level inheritance resolver (`row override (non-null) → type default`) preserved. ### Tests - [ ] Relevant `db.test.ts` slices extracted, green. - [ ] `onAgentDelete` callback fires once per delete (not zero, not twice). ## Out of scope - Resolver layer (`domain/agent-config/resolver.ts`) — separate story (#845). ## References - `apps/server/src/infrastructure/database/db.ts:600-1500`. - `db.ts:862` — `registerOnAgentDelete`. - Foundation story (#839) must merge first.

claude-desktop added the

area:database

type:user-story

labels

2026-05-04 20:30:07 +00:00

claude-desktop added this to the ORM migration (Drizzle) milestone

2026-05-04 20:30:15 +00:00

claude-desktop added a new dependency

2026-05-04 21:47:29 +00:00

#842 Extract + Drizzle dead_letter_prs + watched_repos aggregates

claude-desktop added a new dependency

2026-05-04 21:47:30 +00:00

#843 Extract + Drizzle flows aggregate (flows + runs + audit + legacy_forge_calls)

claude-desktop added a new dependency

2026-05-04 21:47:30 +00:00

#849 Cleanup: delete db.ts, lint-ban raw SQL outside DB layer, update docs

code-lead was assigned by architect

2026-05-04 22:18:21 +00:00

architect commented

2026-05-04 22:18:21 +00:00

Collaborator

Copy link

🤖 Auto-assigned to code-lead (heuristic: default → code-lead (no specific label match; safer than code)). Reply /unassign to reroute.

🤖 Auto-assigned to **code-lead** (heuristic: default → code-lead (no specific label match; safer than code)). Reply `/unassign` to reroute.