feat(tui): image renderer integration — thread through AppCtx #98

Merged

claude-desktop merged 3 commits from tui/image-ctx-85 into main

2026-04-12 15:36:28 +00:00

claude-desktop commented

2026-04-12 13:40:05 +00:00

Collaborator

Summary

Add render_image() and delete_image() convenience methods to AppCtx
Screens can display and clean up terminal images without directly locking the renderer mutex
The Arc<Mutex<Box<dyn ImageRenderer>>> is populated from CoreHandles at startup

Test plan

All 113 tests pass
Clippy clean
Pre-commit hooks pass

Closes charles/loom#85

🤖 Generated with Claude Code

## Summary - Add `render_image()` and `delete_image()` convenience methods to `AppCtx` - Screens can display and clean up terminal images without directly locking the renderer mutex - The `Arc<Mutex<Box<dyn ImageRenderer>>>` is populated from `CoreHandles` at startup ## Test plan - [x] All 113 tests pass - [x] Clippy clean - [x] Pre-commit hooks pass Closes charles/loom#85 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-desktop added the

type:user-story

area:image

labels

2026-04-12 13:40:05 +00:00

claude-desktop added 1 commit

2026-04-12 13:40:05 +00:00

feat(tui): thread ImageRenderer through AppCtx with render/delete helpers 9fd0658c66

Add render_image() and delete_image() convenience methods to AppCtx so
screens can display and clean up terminal images without directly locking
the renderer mutex. The renderer Arc<Mutex<Box<dyn ImageRenderer>>> is
populated from CoreHandles at startup via the auto-detect pipeline.

Closes charles/loom#85

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

claude-desktop referenced this pull request

2026-04-12 14:06:57 +00:00

feat(tui): bootstrap loom-core — plugin registry, storage & event bus #97

claude-desktop commented

2026-04-12 14:07:02 +00:00

Author

Collaborator

Review — PR #98: image renderer through AppCtx

LGTM. Small, focused, does exactly what it says.

Minor

render_image silently swallows a poisoned mutex (renderer.lock().ok()?). This is the right call for the render path — you don't want a panic mid-frame — but a tracing::warn! on Err would help debug if someone ever hits a poisoned lock.
delete_image similarly swallows errors silently via let _ = guard.delete(handle). Same suggestion: a debug/warn log would be cheap insurance.

## Review — PR #98: image renderer through AppCtx **LGTM.** Small, focused, does exactly what it says. ### Minor - `render_image` silently swallows a poisoned mutex (`renderer.lock().ok()?`). This is the right call for the render path — you don't want a panic mid-frame — but a `tracing::warn!` on `Err` would help debug if someone ever hits a poisoned lock. - `delete_image` similarly swallows errors silently via `let _ = guard.delete(handle)`. Same suggestion: a debug/warn log would be cheap insurance.

charles referenced this pull request from a commit

2026-04-12 14:32:32 +00:00

refactor(tui): extract centered_rect to components, add image renderer logs

charles added 2 commits

2026-04-12 14:47:18 +00:00

refactor(tui): extract centered_rect to components, add image renderer logs 335ffeaf1f

- Move duplicated centered_rect() to crate::components as public fn,
  replacing private copies in app.rs, confirm.rs, palette.rs
- Add tracing::warn on poisoned mutex in render_image/delete_image
- Add tracing::debug on delete_image failure

Addresses review comments on PRs #98, #103, #106, #109.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

refactor(tui): hoist shared traits/fields to base branch c3d1517857

- AppHandle.tx → pub(crate) (avoids duplicate change in #101, #107, #109)
- Add as_any_mut() to Screen and Overlay traits with impls on all types
  (avoids conflicting additions in #108, #109)
- Store degraded_settings/degraded_queue once in App to avoid fresh Arc
  allocation per ctx() call in degraded mode (PR #97 review)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>