feat(tui): LoRA picker overlay with fuzzy search

claude-desktop commented

2026-04-12 13:55:15 +00:00

Collaborator

Summary

Add a searchable LoRA picker overlay to the Generate screen's LoRA panel (a key)
Fetches available LoRAs from PluginBridge::list_loras() with loading/error states
Fuzzy search filtering via nucleo_matcher (same pattern as the command palette)
Shows LoRA name, base model compatibility, and checkmark for already-added entries
Enter adds the selected LoRA at weight 1.0; Esc closes without adding
Adds as_any_mut() to Screen and Overlay traits for downcast routing of async results

Test plan

cargo clippy -p loom-tui -- -D warnings clean
cargo test -p loom-tui passes (120 tests including new lora_picker tests)
Manual: open Generate screen, Tab to LoRA panel, press a — overlay opens with loading state
Manual: type to fuzzy-filter, arrow keys to navigate, Enter to add, Esc to cancel
Manual: already-added LoRAs show checkmark marker

Closes charles/loom#87

🤖 Generated with Claude Code

## Summary - Add a searchable LoRA picker overlay to the Generate screen's LoRA panel (`a` key) - Fetches available LoRAs from `PluginBridge::list_loras()` with loading/error states - Fuzzy search filtering via `nucleo_matcher` (same pattern as the command palette) - Shows LoRA name, base model compatibility, and checkmark for already-added entries - Enter adds the selected LoRA at weight 1.0; Esc closes without adding - Adds `as_any_mut()` to `Screen` and `Overlay` traits for downcast routing of async results ## Test plan - [x] `cargo clippy -p loom-tui -- -D warnings` clean - [x] `cargo test -p loom-tui` passes (120 tests including new lora_picker tests) - [ ] Manual: open Generate screen, Tab to LoRA panel, press `a` — overlay opens with loading state - [ ] Manual: type to fuzzy-filter, arrow keys to navigate, Enter to add, Esc to cancel - [ ] Manual: already-added LoRAs show checkmark marker Closes charles/loom#87 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-desktop added the

area:generate

type:user-story

labels

2026-04-12 13:55:15 +00:00

claude-desktop added 1 commit

2026-04-12 13:55:15 +00:00

feat(tui): add LoRA picker overlay with fuzzy search 9cca104e77

Add a searchable LoRA picker overlay to the Generate screen. Pressing
`a` in the LoRA panel opens a modal overlay that fetches available LoRAs
from PluginBridge::list_loras(), provides nucleo-based fuzzy filtering,
shows LoRA name and base model per entry, marks already-added LoRAs with
a checkmark, and adds the selected LoRA at weight 1.0 on Enter.

- New component: components/lora_picker.rs with LoraPickerState
- New overlay variant: OverlayKind::LoraPicker with async fetch
- New actions: AppAction::AddLora, AppAction::LoraListLoaded
- Screen/Overlay traits gain as_any_mut() for downcast routing

Closes charles/loom#87

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

claude-desktop added this to the loom-tui v0.1.0 milestone

2026-04-12 13:55:23 +00:00

claude-desktop referenced this pull request

2026-04-12 14:06:57 +00:00

feat(tui): bootstrap loom-core — plugin registry, storage & event bus #97

claude-desktop referenced this pull request

2026-04-12 14:07:32 +00:00

feat(tui): wire Entity screen to storage for CRUD & prompt injection #101

claude-desktop referenced this pull request

2026-04-12 14:07:53 +00:00

feat(tui): wire Queue overlay to JobQueue for real-time management #103

claude-desktop referenced this pull request

2026-04-12 14:08:23 +00:00

feat(tui): wire Sharing overlay to PluginBridge #106

claude-desktop referenced this pull request

2026-04-12 14:08:50 +00:00

feat(tui): wire Presets screen to storage for CRUD & apply #108

claude-desktop commented

2026-04-12 14:09:02 +00:00

Author

Collaborator

Review — PR #109: LoRA picker overlay with fuzzy search

Excellent. nucleo_matcher is the right tool for fuzzy search. Clean state management, good async loading pattern, solid tests.

Concern: `as_any_mut` on both `Screen` and `Overlay` traits

This PR adds as_any_mut to both traits. PR #108 also adds it to Screen. These will conflict on merge. Suggest landing one first and rebasing the other.

Concern: `Ctrl+k` / `Ctrl+j` for navigation

These conflict with common terminal bindings (Ctrl+j = newline, Ctrl+k = kill line). In the picker context this is fine since it's modal and swallows all keys, but worth noting in the keybinds documentation.

Cross-PR: `centered_rect` duplication

Third copy (also in #103, #106). Extract to crate::components::layout::centered_rect or crate::util.

Cross-PR: `test_ctx()` helper duplication

PRs #101, #107, and #109 each define their own test_ctx() -> AppCtx in test modules. Extract to a #[cfg(test)] helper in crate::app or a crate::test_util module.

Minor

filter_loras returns Vec<(i32, usize)> — allocates on every call (every render frame via filtered()). For the typical LoRA list size (<1000) this is fine, but if performance matters, consider caching the filtered result and invalidating on query change.
current_as_weight defaults strength to 1.0. Consider letting the user adjust strength before confirming (e.g. +/- keys in the picker).
The ✓ marker for already-added LoRAs is a nice touch.

LGTM with the cross-PR coordination items addressed.

## Review — PR #109: LoRA picker overlay with fuzzy search **Excellent.** `nucleo_matcher` is the right tool for fuzzy search. Clean state management, good async loading pattern, solid tests. ### Concern: `as_any_mut` on both `Screen` and `Overlay` traits This PR adds `as_any_mut` to both traits. PR #108 also adds it to `Screen`. These will conflict on merge. Suggest landing one first and rebasing the other. ### Concern: `Ctrl+k` / `Ctrl+j` for navigation These conflict with common terminal bindings (`Ctrl+j` = newline, `Ctrl+k` = kill line). In the picker context this is fine since it's modal and swallows all keys, but worth noting in the keybinds documentation. ### Cross-PR: `centered_rect` duplication Third copy (also in #103, #106). Extract to `crate::components::layout::centered_rect` or `crate::util`. ### Cross-PR: `test_ctx()` helper duplication PRs #101, #107, and #109 each define their own `test_ctx() -> AppCtx` in test modules. Extract to a `#[cfg(test)]` helper in `crate::app` or a `crate::test_util` module. ### Minor - `filter_loras` returns `Vec<(i32, usize)>` — allocates on every call (every render frame via `filtered()`). For the typical LoRA list size (<1000) this is fine, but if performance matters, consider caching the filtered result and invalidating on query change. - `current_as_weight` defaults strength to `1.0`. Consider letting the user adjust strength before confirming (e.g. `+`/`-` keys in the picker). - The `✓` marker for already-added LoRAs is a nice touch. LGTM with the cross-PR coordination items addressed.

charles referenced this pull request from a commit

2026-04-12 14:32:32 +00:00

refactor(tui): extract centered_rect to components, add image renderer logs

charles referenced this pull request from a commit

2026-04-12 14:32:32 +00:00

refactor(tui): hoist shared traits/fields to base branch

charles referenced this pull request from a commit

2026-04-12 14:48:00 +00:00

fix(tui): lora picker uses shared centered_rect, deduplicate trait additions

charles force-pushed tui/lora-picker-87 from 9cca104e77 to 4e215ef964

2026-04-12 14:48:00 +00:00

Compare