chore(db): SR-11 M2 — drop legacy skill table + skill_overrides_json (#879) #894

Merged

charles merged 2 commits from feat/879-sr11-m2-drop-legacy-skill into main 2026-05-06 00:13:11 +00:00

Conversation 0 Commits 2 Files changed 24 +137 -277

claude-desktop commented 2026-05-05 23:54:46 +00:00

Collaborator

Copy link

Closes #879 (SR-11 M2).

Schema

• 0003: DROP TABLE IF EXISTS skill
• 0004: remove agent_type_config.skill_overrides_json via idempotent PRAGMA table_info guard in migrate.ts (avoids ALTER … DROP COLUMN on DBs that never had the column)

Boot order

• Apply migrations paused before 0003, run runSr3M1Migration, then apply the rest so SR-3 can still read legacy skill / skill_overrides_json.

Code

• Removed Drizzle skill table + resolveSkill / SkillRow and skill_overrides on AgentTypeConfigRow
• Replaced loadSkill/skillCache with readSkillMarkdownFile in skill-library.ts
• Type rename: agent_skill row updates; affected_rows.agent_skill (was skill); ConfigTable uses agent_skill

Note

No production / backup requirements for this environment; local DB loss acceptable.

just qa green; pre-push hook passed.

Closes #879 (SR-11 M2). ### Schema - `0003`: `DROP TABLE IF EXISTS skill` - `0004`: remove `agent_type_config.skill_overrides_json` via idempotent `PRAGMA table_info` guard in `migrate.ts` (avoids `ALTER … DROP COLUMN` on DBs that never had the column) ### Boot order - Apply migrations **paused before** `0003`, run `runSr3M1Migration`, then apply the rest so SR-3 can still read legacy `skill` / `skill_overrides_json`. ### Code - Removed Drizzle `skill` table + `resolveSkill` / `SkillRow` and `skill_overrides` on `AgentTypeConfigRow` - Replaced `loadSkill`/`skillCache` with `readSkillMarkdownFile` in `skill-library.ts` - Type rename: `agent_skill` row updates; `affected_rows.agent_skill` (was `skill`); `ConfigTable` uses `agent_skill` ### Note No production / backup requirements for this environment; local DB loss acceptable. `just qa` green; pre-push hook passed.

claude-desktop added 3 commits 2026-05-05 23:54:46 +00:00

feat: remove legacy skills agent-config and GET /agents/skills (SR-10, #878) ... c87083224b

Drop the filesystem skill dump HTTP route in favour of /agents/skills/library,
remove skills from /agent-config CRUD and debug resolution, and align the web app:
history filters, inheritance panel on non-skills tabs, skill name discovery via
library endpoint, and SkillsTab typing for DB-backed skills only.

Co-authored-by: Cursor <cursoragent@cursor.com>

fix(history-tab): surface clear error for legacy skill revision restore (SR-10) ... 026556860b

Split the generic "missing kind or name" guard so operators attempting
to restore a legacy `skill` revision see a meaningful message instead
of the confusing generic one.

Co-authored-by: Cursor <cursoragent@cursor.com>

chore(db): SR-11 M2 drop legacy skill ladder + skill_overrides_json (#879) ... 932716aebe

- Migrations 0003 (DROP skill) + 0004 (idempotent column drop via migrate.ts)
- Pause applyMigrations before 0003, run SR-3 M1, then finish migrations
- Remove resolveSkill / skill schema; agent rename updates agent_skill
- Replace loadSkill cache with readSkillMarkdownFile from skill-library

Co-authored-by: Cursor <cursoragent@cursor.com>

charles added 1 commit 2026-05-05 23:58:52 +00:00

fix(db): use plain string compare for pauseBeforeMigration; fix stale SR-11 error msg ... d92b7c25e5

- Replace locale-sensitive `localeCompare` with `>=` in migrate.ts pause guard
- Update history-tab error: "until SR-11" is now past tense

Co-authored-by: Cursor <cursoragent@cursor.com>

charles force-pushed feat/879-sr11-m2-drop-legacy-skill from d92b7c25e5 to ed865a76e7 2026-05-06 00:01:55 +00:00 Compare

charles merged commit 42c8a75e4e into main 2026-05-06 00:13:11 +00:00

charles deleted branch feat/879-sr11-m2-drop-legacy-skill 2026-05-06 00:13:12 +00:00

charles referenced this pull request from a commit 2026-05-06 00:13:13 +00:00

chore(db): SR-11 M2 — drop legacy skill table + skill_overrides_json (#879) (#894)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks!894

No description provided.