#879 - SR-11 M2 — drop legacy skill table + skill_overrides_json column + dead resolver code - charles/claude-hooks

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks#879

claude-desktop commented

2026-05-05 10:30:47 +00:00

Collaborator

User story

As a platform engineer, I want the legacy skill table, the agent_type.skill_overrides_json column, and the resolver code paths that read them dropped, so that the codebase has no dead branches and the schema reflects the actual model.

Land this PR no earlier than one full release after SR-4 ships, so that any rollback can still consult the legacy data.

Acceptance criteria

Schema

DROP TABLE skill (the four-scope ladder table).
DROP COLUMN agent_type.skill_overrides_json.
Migration is forward-only — drop scripts are not reversible without restoring from backup. This is intentional.

Code

Delete apps/server/src/infrastructure/database/schema/agent-config-scope.ts's skill schema export. Other kinds (systemPrompt, pluginBinding, mcpServer, pluginMarketplace) stay.
Delete legacy reader code paths from agent-type-config.ts if SR-4 left any behind (it should have removed resolveSkill, but verify).
Delete the loadSkill cache (skillCache Map) and the loadSkill export — by this point the only consumer is the SR-6 library endpoint, which can read directly from disk.
Delete STATELESS_SKILLS constant if SR-4 left it.
Delete any tests that asserted legacy ladder behaviour.

Verification

just qa passes.
Production database snapshot taken before the migration runs (operator runbook step, documented in PR body).
One full release cycle elapsed since SR-4 merged. PR body cites the release tag.

Out of scope

Schema or code paths for other artifact kinds.
The agent_type_config aggregate as a whole — only the skill-relevant pieces.

References

Spec: specs/skills-rework.md §M2 — drop legacy tables/columns.
Files: apps/server/src/infrastructure/database/schema/agent-config-scope.ts, apps/server/src/infrastructure/database/agent-type-config.ts.
Depends on SR-4 + one full release cycle.

## User story As a platform engineer, I want the legacy `skill` table, the `agent_type.skill_overrides_json` column, and the resolver code paths that read them dropped, so that the codebase has no dead branches and the schema reflects the actual model. Land this PR no earlier than one full release after SR-4 ships, so that any rollback can still consult the legacy data. ## Acceptance criteria ### Schema - [ ] DROP TABLE `skill` (the four-scope ladder table). - [ ] DROP COLUMN `agent_type.skill_overrides_json`. - [ ] Migration is forward-only — drop scripts are not reversible without restoring from backup. This is intentional. ### Code - [ ] Delete `apps/server/src/infrastructure/database/schema/agent-config-scope.ts`'s `skill` schema export. Other kinds (`systemPrompt`, `pluginBinding`, `mcpServer`, `pluginMarketplace`) stay. - [ ] Delete legacy reader code paths from `agent-type-config.ts` if SR-4 left any behind (it should have removed `resolveSkill`, but verify). - [ ] Delete the `loadSkill` cache (`skillCache` Map) and the `loadSkill` export — by this point the only consumer is the SR-6 library endpoint, which can read directly from disk. - [ ] Delete `STATELESS_SKILLS` constant if SR-4 left it. - [ ] Delete any tests that asserted legacy ladder behaviour. ### Verification - [ ] `just qa` passes. - [ ] Production database snapshot taken before the migration runs (operator runbook step, documented in PR body). - [ ] One full release cycle elapsed since SR-4 merged. PR body cites the release tag. ## Out of scope - Schema or code paths for other artifact kinds. - The `agent_type_config` aggregate as a whole — only the skill-relevant pieces. ## References - Spec: `specs/skills-rework.md` §M2 — drop legacy tables/columns. - Files: `apps/server/src/infrastructure/database/schema/agent-config-scope.ts`, `apps/server/src/infrastructure/database/agent-type-config.ts`. - Depends on **SR-4** + one full release cycle.

claude-desktop added the

labels

2026-05-05 10:31:25 +00:00

claude-desktop added this to the Skills rework milestone

2026-05-05 10:31:34 +00:00

charles referenced this issue from a commit

2026-05-05 23:54:07 +00:00

chore(db): SR-11 M2 drop legacy skill ladder + skill_overrides_json (#879)

claude-desktop referenced this issue from a pull request that will close it,

2026-05-05 23:54:46 +00:00

chore(db): SR-11 M2 — drop legacy skill table + skill_overrides_json (#879) #894

2026-05-06 00:01:55 +00:00