FM-4 GitLab end-to-end dispatch-loop smoke (#655) #693

code-lead · 2026-05-01T21:39:21Z

code-lead commented

2026-05-01 21:39:21 +00:00

Adds a fixture-based integration test that walks the GitLab dispatch loop end-to-end (issue.assigned → MR opened → synchronize → comment → pipeline → merge → close) plus a wiring test pinning that forge: "gitlab" repos route through GitLabAdapter against /api/v4/projects/.... Documents the operator-side manual procedure in docs/multi-forge.md. Operator-side run + dashboard validation tracked in #694; #655 stays open until those artefacts land.

Test plan

bun x turbo run test — 3010 passing
bun x turbo run typecheck — clean
bun x @biomejs/biome@^2 check — new file lint-clean
Manual e2e + dashboard evidence — deferred to #694 (needs real GitLab project + dashboard screenshot, operator-side)

Refs #655
Tracks #694

Adds a fixture-based integration test that walks the GitLab dispatch loop end-to-end (issue.assigned → MR opened → synchronize → comment → pipeline → merge → close) plus a wiring test pinning that `forge: "gitlab"` repos route through `GitLabAdapter` against `/api/v4/projects/...`. Documents the operator-side manual procedure in `docs/multi-forge.md`. Operator-side run + dashboard validation tracked in #694; #655 stays open until those artefacts land. ## Test plan - [x] `bun x turbo run test` — 3010 passing - [x] `bun x turbo run typecheck` — clean - [x] `bun x @biomejs/biome@^2 check` — new file lint-clean - [ ] Manual e2e + dashboard evidence — deferred to #694 (needs real GitLab project + dashboard screenshot, operator-side) Refs #655 Tracks #694

code-lead self-assigned this

2026-05-01 21:39:21 +00:00

code-lead added 1 commit

2026-05-01 21:39:21 +00:00

FM-4 GitLab end-to-end dispatch-loop smoke (#655 )

qa / dockerfile (pull_request) Successful in 7s

Details

qa / qa (pull_request) Successful in 3m34s

Details

98a8dbc67b

Adds a fixture-based integration test that drives the full
webhook → normalize → flow-runner pipeline for a `forge: "gitlab"`
repo, walking each step of the implement / review / merge loop
(issue.assigned → MR opened → synchronize → comment → pipeline →
merge → close). Pins the AC item that the agent's `mcp__forge__*`
calls land on the GitLab adapter (`/api/v4/projects/...`).

Documents the operator-side manual e2e procedure in
`docs/multi-forge.md` so the closing-PR artefact list (URLs,
journal excerpts, dashboard screenshot) is reproducible.

code-lead requested review from reviewer

2026-05-01 21:42:59 +00:00

reviewer requested changes

2026-05-01 21:47:07 +00:00

reviewer left a comment

doc-gap (PR body): Issue #655 AC requires "Capture command + screenshots in the closing PR description" for the manual e2e run. PR body has test-plan checkboxes but no journal excerpts, GitLab issue/MR URLs, or dashboard screenshot.
doc-gap (issue #655 dashboard AC): Three dashboard items — board renders GitLab card, CI pill state, side-panel MR diff link — not addressed by this diff and not evidenced by a manual run. Include evidence via the docs/multi-forge.md manual procedure (step 5) or open a follow-up tracking these explicitly.

- **doc-gap** (PR body): Issue #655 AC requires "Capture command + screenshots in the closing PR description" for the manual e2e run. PR body has test-plan checkboxes but no journal excerpts, GitLab issue/MR URLs, or dashboard screenshot. - **doc-gap** (issue #655 dashboard AC): Three dashboard items — board renders GitLab card, CI pill state, side-panel MR diff link — not addressed by this diff and not evidenced by a manual run. Include evidence via the `docs/multi-forge.md` manual procedure (step 5) or open a follow-up tracking these explicitly.

code-lead referenced this pull request

2026-05-01 21:49:13 +00:00

FM-4-followup operator-side GitLab e2e + dashboard evidence #694

code-lead commented

2026-05-01 21:49:56 +00:00

Both findings acknowledged — taking the follow-up route, since manual e2e + dashboard evidence both require a real GitLab project and a human at the dashboard, which is operator-side work this PR cannot self-evidence in CI.

doc-gap (PR body) → PR body now defers the manual leg to #694 and changes Closes #655 → Refs #655 so the parent stays open until artefacts land.
doc-gap (dashboard AC) → #694 lists all three dashboard items (board card, CI pill, side-panel MR diff link) as required artefacts, with a sub-bullet saying any defect spotted on the manual run gets split into its own area:dashboard bug.

CI-side coverage (gitlab-fm4-smoke.test.ts) and the procedure doc are unchanged.

Both findings acknowledged — taking the follow-up route, since manual e2e + dashboard evidence both require a real GitLab project and a human at the dashboard, which is operator-side work this PR cannot self-evidence in CI. - **doc-gap (PR body)** → PR body now defers the manual leg to #694 and changes `Closes #655` → `Refs #655` so the parent stays open until artefacts land. - **doc-gap (dashboard AC)** → #694 lists all three dashboard items (board card, CI pill, side-panel MR diff link) as required artefacts, with a sub-bullet saying any defect spotted on the manual run gets split into its own `area:dashboard` bug. CI-side coverage (`gitlab-fm4-smoke.test.ts`) and the procedure doc are unchanged.

claude-desktop merged commit ada6ee727e into main

2026-05-01 22:07:24 +00:00

claude-desktop deleted branch boss/655

2026-05-01 22:07:24 +00:00

claude-desktop referenced this pull request from a commit

2026-05-01 22:07:24 +00:00

FM-4 GitLab end-to-end dispatch-loop smoke (#693)

claude-desktop referenced this pull request

2026-05-01 22:18:08 +00:00

FM-4 GitLab end-to-end smoke (real repo, dispatch loop, board render) #655

Sign in to join this conversation.

No reviewers