charles/claude-hooks
1
0
Fork 0
Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

FM-4 GitLab end-to-end smoke (real repo, dispatch loop, board render) #655

New issue
Open
opened 2026-05-01 18:33:08 +00:00 by claude-desktop · 2 comments
claude-desktop commented 2026-05-01 18:33:08 +00:00
Collaborator
Copy link

User story

As a platform engineer, I want a real GitLab repo watched by claude-hooks with the full dispatch loop (issue → implement → review → merge) closing successfully, so that the multi-forge claim from forge-mcp-multi-forge.md is validated end-to-end on a non-Forgejo backend.

Acceptance criteria

Webhook config

  • webhook-config.json::repos adds an entry pointing at a GitLab repo (operator-controlled — forge.jacquin.app/charles/... mirror, or a gitlab.com project of your choice). The entry's forge field is "gitlab".
  • GitLab webhook configured on that project to send Issue Hook, Merge Request Hook, Note Hook, Pipeline Hook events to https://claude.jacquin.app/webhooks/gitlab (or equivalent route — coordinate with apps/server/src/http/webhook.ts).
  • Same HMAC pattern as Forgejo for signature verification.

Dispatch loop

  • Create an issue on the GitLab repo, assign dev. The webhook fires, the dispatcher constructs an implement task, the agent's mcp__forge__* calls hit the GitLab adapter via forge-mcp.
  • Agent creates an MR. Reviewer is requested. Reviewer agent picks up, reads MR diff (getPullRequestDiff adapter call), submits APPROVE or REQUEST_CHANGES via submitReview (GitLab approve / unapprove + discussion mapping).
  • Boss merges the MR via mergePullRequest (GitLab squash).
  • Issue auto-closes (GitLab Closes #N keyword in MR body).

Dashboard

  • The board renders the GitLab card alongside Forgejo cards under the same Triage / per-agent columns. PR pill renders correctly with GitLab CI state. Card click opens the side panel with MR diff link.

Tests

  • Integration test against recorded GitLab REST fixtures (no live GitLab in CI) walks the entire dispatch loop.
  • Manual: one real issue on a real GitLab repo, watched and processed end-to-end. Capture command + screenshots in the closing PR description.

Out of scope

  • GitHub end-to-end smoke (file separately if needed).
  • GitLab CI integration beyond reading pipeline status.
  • A second GitLab repo (one is enough to validate).

References

  • specs/forge-mcp-multi-forge.md §Story FM-4
  • specs/multi-forge.md §MF-7 — multi-forge dispatch tests, this extends
  • apps/server/src/infrastructure/forge/gitlab-adapter.ts
  • Depends on FM-1, FM-2, FM-3.
## User story As a platform engineer, I want a real GitLab repo watched by `claude-hooks` with the full dispatch loop (issue → implement → review → merge) closing successfully, so that the multi-forge claim from `forge-mcp-multi-forge.md` is validated end-to-end on a non-Forgejo backend. ## Acceptance criteria ### Webhook config - [ ] `webhook-config.json::repos` adds an entry pointing at a GitLab repo (operator-controlled — `forge.jacquin.app/charles/...` mirror, or a `gitlab.com` project of your choice). The entry's `forge` field is `"gitlab"`. - [ ] GitLab webhook configured on that project to send `Issue Hook`, `Merge Request Hook`, `Note Hook`, `Pipeline Hook` events to `https://claude.jacquin.app/webhooks/gitlab` (or equivalent route — coordinate with `apps/server/src/http/webhook.ts`). - [ ] Same HMAC pattern as Forgejo for signature verification. ### Dispatch loop - [ ] Create an issue on the GitLab repo, assign `dev`. The webhook fires, the dispatcher constructs an implement task, the agent's `mcp__forge__*` calls hit the GitLab adapter via `forge-mcp`. - [ ] Agent creates an MR. Reviewer is requested. Reviewer agent picks up, reads MR diff (`getPullRequestDiff` adapter call), submits APPROVE or REQUEST_CHANGES via `submitReview` (GitLab `approve` / `unapprove + discussion` mapping). - [ ] Boss merges the MR via `mergePullRequest` (GitLab squash). - [ ] Issue auto-closes (GitLab `Closes #N` keyword in MR body). ### Dashboard - [ ] The board renders the GitLab card alongside Forgejo cards under the same `Triage` / per-agent columns. PR pill renders correctly with GitLab CI state. Card click opens the side panel with MR diff link. ### Tests - [ ] Integration test against recorded GitLab REST fixtures (no live GitLab in CI) walks the entire dispatch loop. - [ ] Manual: one real issue on a real GitLab repo, watched and processed end-to-end. Capture command + screenshots in the closing PR description. ## Out of scope - GitHub end-to-end smoke (file separately if needed). - GitLab CI integration beyond reading pipeline status. - A second GitLab repo (one is enough to validate). ## References - `specs/forge-mcp-multi-forge.md` §Story FM-4 - `specs/multi-forge.md` §MF-7 — multi-forge dispatch tests, this extends - `apps/server/src/infrastructure/forge/gitlab-adapter.ts` - Depends on **FM-1**, **FM-2**, **FM-3**.
code-lead commented 2026-05-01 21:23:54 +00:00
Collaborator
Copy link

🤖 Auto-assigned to boss (heuristic: area:agents → boss (architecture-touching)). Reply /unassign to reroute.

🤖 Auto-assigned to **boss** (heuristic: area:agents → boss (architecture-touching)). Reply `/unassign` to reroute.
claude-desktop commented 2026-05-01 22:18:08 +00:00
Author
Collaborator
Copy link

Unassigned boss + wired native dependency on #694. CI-side coverage is done (PR #693), the remaining ACs (real GitLab project, dispatch-loop run, dashboard screenshots) are operator-side per docs/multi-forge.md §FM-4 and now tracked on #694. Reassign once #694 lands its evidence and this can close.

Unassigned boss + wired native dependency on #694. CI-side coverage is done (PR #693), the remaining ACs (real GitLab project, dispatch-loop run, dashboard screenshots) are operator-side per `docs/multi-forge.md` §FM-4 and now tracked on #694. Reassign once #694 lands its evidence and this can close.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
chore/sync-pre-push-from-forge-base
fix/flows-yaml-dispatch-identity
feat/board-tap-to-assign
dev/1107
code-lead/1106
code-lead/1108
dev/1104
code-lead/1103
code-lead/1080
dev/1087
feat/flows-yaml-ci-events
chore/board-drop-stalled-and-density-controls
fix/flows-yaml-routes-always-register
flows-yaml/api-defaults
dev/1023
fix/event-log-history-bleed
fix/janitor-fix-ci-logs-and-cap
dev/1022
fix/board-card-provider
code-lead/1036
dev/1025
code-lead/1020
dev/1017
code-lead/1026
feat/web-shortcut-registry-1018
dev/1015
code-lead/1009
code-lead/1008
dev/975
dev/969
dev/973
dev/967
code-lead/968
code-lead/953
dev/970
dev/976
code-lead/966
code-lead/956
code-lead/951
dev/962
dev/963
dev/977
dev/955
dev/983
dev/961
dev/974
code-lead/950
code-lead/939
dev/941
dev/940
dev/937
dev/938
dev/936
dev/935
feat/web-i18n-fr-locale
feat/spec-editor-ui-polish
chore/drop-legacy-compat
fix/skills-drop-preview-pane
fix/882-skills-safety-rail
dev/911
dev/909
dev/923
dev/917
dev/915
feat/879-sr11-m2-drop-legacy-skill
code-lead/873
dev/881
code-lead/869
dev/867
code-lead/845
code-lead/843
code-lead/844
dev/837
dev/861
dev/849
code-lead/837
code-lead/842
fix/dedup-rebase-inflight
dev/838
code-lead/847
dev/833
code-lead/848
pr/838
code-lead/841
feat/settings-save-bar/836
code-lead/840
dev/846
code-lead/839
dev/832
fix/board-sse-stale-cache
dev/834
dev/835
feat/settings-breadcrumbs
feat/forge-oauth-credentials
refactor/service-config-consolidation
feat/agent-tokens-to-secrets
feat/gitlab-oauth-to-db
feat/authelia-rip-and-voice-fixes
fix/rebase-storm-and-dead-letter
code-lead/797
code-lead/796
dev/811
code-lead/798
dev/810
code-lead/795
dev/808
code-lead/794
dev/805
dev/802
dev/803
feat/avatar-menu-settings-entry
feat/per-agent-token-tracking
dev/793
dev/747
dev/752
code-lead/790
code-lead/759
dev/756
dev/760
dev/741
dev/767
dev/740
dev/709
dev/644
dev/637
boss/614
dev/600
dev/611
dev/585
fix/login-bonus-fixes
boss/544
dev/542
refactor/api-prefix-and-session-gate
dev/489
boss/531
boss/518
dev/499
boss/516
dev/530
dev/517
dev/519
dev/515
dev/522
dev/503
dev/471
boss/329
dev/417
dev/418
dev/402
boss/327
dev/334
dev/332
boss/326
boss/325
dev/331
boss/324
boss/323
boss/322
dev/294
test/s11-task-analytics
dev/262
boss/270
dev/268
foreman/ui-consolidation-spec
dev/234
boss/196
boss/176
boss/164
fix/124-session-persist-bind
boss/52
dev/87
boss/73
dev/77
dev/81
dev/82
boss/79
dev/42
dev/35
boss/7
No results found.
Labels
Clear labels   
area:agents
Agent types, pool scheduling, per-instance config

  
area:dashboard
Dashboard UI and observability surfaces

  
area:database
DB layer — schema, migrations, ORM, raw SQL

  
area:design
UI/UX mockup work — routes to designer agent

  
area:design-review
Design review dispatch — routes to design-reviewer agent

  
area:flows
Flow runner — YAML loader, executor, op registry, expression eval

  
area:infra
Deployment, isolation, containers, systemd units

  
area:meta
Tracking, scaffolding, project setup

  
area:security
Security — routes to reviewer-security (opus)

  
area:sessions
Session-id store, Claude SDK resume logic

  
area:webhook
Forgejo webhook routing and handlers

  
area:workdir
Clone cache, worktrees, git identity

  
security
Security-sensitive issue

  
type:bug
Bug

  
type:chore
Chore

  
type:meta
Tracking or decisions, not implementation work

  
type:user-story
User story

No labels
area:agents
area:dashboard
area:database
area:design
area:design-review
area:flows
area:infra
area:meta
area:security
area:sessions
area:webhook
area:workdir
security
type:bug
type:chore
type:meta
type:user-story
Milestone
Clear milestone
No items
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on
#654 FM-3 Migrate agents to forge-mcp, drop forgejo-mcp from image + patches
charles/claude-hooks
#694 FM-4-followup operator-side GitLab e2e + dashboard evidence
charles/claude-hooks
Reference
charles/claude-hooks#655
No description provided.