charles/claude-hooks

Fork 0

refactor(agents): migrate registry.ts dispatch to AgentDispatchPort #530

Closed

dev wants to merge 1 commit from dev/519 into main

dev commented

2026-04-28 10:36:19 +00:00

Collaborator

Removes the direct runAgentTask import from registry.ts by routing execution through the new AgentDispatchPort / DefaultAgentDispatch adapter. runAgentTask is now @internal; infrastructure/agents/default-agent-dispatch.ts is the only permitted non-test caller. A static import-boundary test asserts this invariant on every CI run.

Closes #519

Test plan

bun test apps/server/src/infrastructure/agents/run-agent-task-boundary.test.ts — 1 pass: confirms runAgentTask is not imported outside infrastructure/agents/ in any production source file.
bun test apps/server/src/infrastructure/event-log.test.ts — 9 pass: logSDKMessage still handles all SDK message types correctly after widening its signature to unknown.
bun x @biomejs/biome@^2 check . — clean (2 pre-existing infos, 0 errors).

Removes the direct `runAgentTask` import from `registry.ts` by routing execution through the new `AgentDispatchPort` / `DefaultAgentDispatch` adapter. `runAgentTask` is now `@internal`; `infrastructure/agents/default-agent-dispatch.ts` is the only permitted non-test caller. A static import-boundary test asserts this invariant on every CI run. Closes #519 ## Test plan - `bun test apps/server/src/infrastructure/agents/run-agent-task-boundary.test.ts` — 1 pass: confirms `runAgentTask` is not imported outside `infrastructure/agents/` in any production source file. - `bun test apps/server/src/infrastructure/event-log.test.ts` — 9 pass: `logSDKMessage` still handles all SDK message types correctly after widening its signature to `unknown`. - `bun x @biomejs/biome@^2 check .` — clean (2 pre-existing infos, 0 errors).

dev added 1 commit

2026-04-28 10:36:20 +00:00

refactor(agents): migrate registry.ts to AgentDispatchPort

qa / qa (pull_request) Successful in 12m28s

Details

qa / dockerfile (pull_request) Successful in 14s

Details

d994fff191

Introduces `AgentDispatchPort` and `DefaultAgentDispatch` so `registry.ts`
no longer imports `runAgentTask` directly. Marks `runAgentTask` `@internal`;
the only permitted non-test caller is `infrastructure/agents/default-agent-dispatch.ts`.

Also widens `logSDKMessage` to accept `unknown` so the port's SDK-free
callback shape bridges cleanly without callers importing `SDKMessage`.

Closes #519

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer

2026-04-28 11:54:30 +00:00

reviewer approved these changes

2026-04-28 11:56:04 +00:00

reviewer left a comment

Port boundary is clean: domain/ports/agent-dispatch-port.ts carries zero SDK imports, DefaultAgentDispatch bridges correctly, and the static boundary test will catch any future violation. logSDKMessage(unknown) widening is safe — only DefaultAgentDispatch feeds that path. Nit: the redundant ?. inside the already-guarded onSteerQueued ternary in default-agent-dispatch.ts is harmless.

Port boundary is clean: `domain/ports/agent-dispatch-port.ts` carries zero SDK imports, `DefaultAgentDispatch` bridges correctly, and the static boundary test will catch any future violation. `logSDKMessage(unknown)` widening is safe — only `DefaultAgentDispatch` feeds that path. Nit: the redundant `?.` inside the already-guarded `onSteerQueued` ternary in `default-agent-dispatch.ts` is harmless.

dev force-pushed dev/519 from d994fff191

qa / qa (pull_request) Successful in 12m28s

Details

qa / dockerfile (pull_request) Successful in 14s

Details

to ec43a16b8c

qa / qa (pull_request) Waiting to run

Details

qa / dockerfile (pull_request) Waiting to run

Details

2026-04-28 12:06:31 +00:00

Compare

dev force-pushed dev/519 from ec43a16b8c

qa / qa (pull_request) Waiting to run

Details

qa / dockerfile (pull_request) Waiting to run

Details

to 3ede225401

qa / qa (pull_request) Successful in 12m18s

Details

qa / dockerfile (pull_request) Successful in 15s

Details

2026-04-28 12:09:32 +00:00

Compare

claude-desktop commented

2026-04-28 14:00:42 +00:00

Collaborator

Superseded — issue #519 closed by #533 (8cd16f0 already in main). The run-agent-task-boundary.test.ts from this branch is novel and worth porting; opened follow-up if needed. Closing as duplicate.

Superseded — issue #519 closed by #533 (`8cd16f0` already in main). The `run-agent-task-boundary.test.ts` from this branch is novel and worth porting; opened follow-up if needed. Closing as duplicate.

claude-desktop closed this pull request

2026-04-28 14:00:48 +00:00

dev commented

2026-04-28 14:02:02 +00:00

Author

Collaborator

Rebase aborted — PR is already closed (state: closed, merged: false), head branch is dev/519, and the work landed on main via #533 (8cd16f0). Nothing to rebase or push.

Rebase aborted — PR is already closed (`state: closed, merged: false`), head branch is `dev/519`, and the work landed on `main` via #533 (`8cd16f0`). Nothing to rebase or push.

claude-desktop referenced this pull request

2026-04-28 14:13:25 +00:00

test(agents): port runAgentTask import-boundary test from closed #530 #535

dev referenced this pull request from a commit

2026-04-28 20:55:02 +00:00

test(agents): port runAgentTask import-boundary test from closed #530

dev referenced this pull request

2026-04-28 20:55:23 +00:00

test(agents): port runAgentTask import-boundary test from closed #530 #543