chore(web): remove settings-search widget from app shell header #1016

Merged

reviewer merged 6 commits from dev/1015 into main

2026-05-09 17:45:16 +00:00

dev commented

2026-05-09 17:41:41 +00:00

Collaborator

Removes the SU-6 ⌘K settings search palette and its header triggers from the app shell, freeing the chord for future global use.

Deletes settings-search.tsx and settings-search.test.tsx (no other consumers)
Removes desktop chip (settings-search-trigger) and mobile icon button (settings-search-trigger-mobile) from app-shell.tsx
Drops searchOpen state, closeSearch callback, and global keydown ⌘K listener
Removes app_shell_search_settings i18n key from en.json and fr.json
Purges 5 settings-search-* test-id constants from settings-manifest.ts

Test plan

just qa passes (typecheck, Biome lint/format, paraglide-check, i18n-string-check, sql-layer-check all clean)
App header renders: RepoSelector → NotificationsBell → ConnPill → AvatarMenu with no leftover gap artefacts
⌘K no longer opens a settings palette

Closes #1015

Removes the SU-6 ⌘K settings search palette and its header triggers from the app shell, freeing the chord for future global use. - Deletes `settings-search.tsx` and `settings-search.test.tsx` (no other consumers) - Removes desktop chip (`settings-search-trigger`) and mobile icon button (`settings-search-trigger-mobile`) from `app-shell.tsx` - Drops `searchOpen` state, `closeSearch` callback, and global `keydown` ⌘K listener - Removes `app_shell_search_settings` i18n key from `en.json` and `fr.json` - Purges 5 `settings-search-*` test-id constants from `settings-manifest.ts` ## Test plan - `just qa` passes (typecheck, Biome lint/format, paraglide-check, i18n-string-check, sql-layer-check all clean) - App header renders: `RepoSelector → NotificationsBell → ConnPill → AvatarMenu` with no leftover gap artefacts - ⌘K no longer opens a settings palette Closes #1015

dev self-assigned this

2026-05-09 17:41:41 +00:00

dev added 6 commits

2026-05-09 17:41:41 +00:00

chore(web): remove settings-search widget from app shell header 30cbb07576

chore(web): remove settings-search widget from app shell header f775eb9754

chore(web): remove settings-search widget from app shell header d94c89c01a

chore(web): remove settings-search widget from app shell header 59cfdaa95d

chore(web): remove settings-search widget from app shell header 89a7c34c71

chore(web): remove settings-search widget from app shell header

qa / sql-layer-check (pull_request) Successful in 8s

Details