Remove settings-search widget from app shell header #1015
Labels
No labels
area:agents
area:dashboard
area:database
area:design
area:design-review
area:flows
area:infra
area:meta
area:security
area:sessions
area:webhook
area:workdir
security
type:bug
type:chore
type:meta
type:user-story
No milestone
No project
No assignees
1 participant
dev
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
charles/claude-hooks#1015
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
User story
As an operator using the claude-hooks dashboard, I want the Search settings chip and ⌘K palette removed from the global header, so that the topbar utility cluster is leaner and the ⌘K chord is freed for future global use.
The chip currently sits between the desktop nav and the repo selector (icon + "Search settings" label +
⌘Kkbd hint, plus an icon-only mirror on mobile). It opens aSettingsSearchpalette dialog. Both the chip and the palette ship viaapps/web/src/components/app-shell.tsx(introduced in #837 / SU-6) — the operator wants the entire feature gone, not just hidden.Acceptance criteria
Header
data-testid="settings-search-trigger") removed fromapps/web/src/components/app-shell.tsx.data-testid="settings-search-trigger-mobile") removed from the same file.Searchicon import fromlucide-reactdropped if no other call site inapp-shell.tsxuses it.RepoSelector → NotificationsBell → ConnPill → AvatarMenu. No leftovergapartefacts or empty wrapper divs.Palette + ⌘K wiring
searchOpenstate,closeSearchcallback, and the globalkeydownlistener that toggles ⌘K all removed fromAppShell.<SettingsSearch open={searchOpen} onClose={closeSearch} />mount at the bottom of the shell removed.import { SettingsSearch } from "@/components/settings-search"removed.apps/web/src/components/settings-search.tsxandapps/web/src/components/settings-search.test.tsxdeleted (no other consumers).app_shell_search_settingsParaglide message removed from every locale messages file underapps/web/messages/(and any generated Paraglide output regenerated).settings-search-palette,settings-search-input,settings-search-empty,settings-search-trigger,settings-search-trigger-mobiletest-id entries removed fromapps/web/src/lib/settings-manifest.ts(so the manifest stays consistent with the rendered DOM).Tests
apps/web/src/components/app-shell.test.tsx(if it asserts on the search chip) updated; no test referencessettings-search-trigger*anymore.bun run --filter @claude-hooks/web testpasses.just qapasses (typecheck + lint + format).Out of scope
References
apps/web/src/components/app-shell.tsx:24,186-202,261-294,433— chip, ⌘K listener, palette mount.apps/web/src/components/settings-search.tsx— palette to delete.apps/web/src/lib/settings-manifest.ts:491-495— test-id constants to drop.