charles/my-fractal

Fork 0

feat: OpenAiWhisperEngine + VoskEngine + SecretString (#6) #96

Closed

charles wants to merge 21 commits from feat/6-openai-vosk-engines into main

charles commented

2026-04-06 01:57:49 +00:00

Owner

Closes #6

Summary

SecretString : type opaque ajouté dans types.rs — Debug/Display masquent la valeur ([REDACTED]), expose() retourne la valeur brute au point d'usage
OpenAiWhisperEngine : appel HTTP multipart vers {base_url}/v1/audio/transcriptions via reqwest + rustls-tls (pas d'OpenSSL) ; health_check() valide la clé API via GET {base_url}/v1/models ; compatible OpenAI, Groq, Together…
VoskEngine : invoque vosk-transcriber en subprocess ; health_check() vérifie la présence du binaire puis du répertoire modèle ; parse le format JSON ligne-par-ligne ({"text": "…"})
whisper.rs : WHISPER_LANGUAGES rendu pub(crate) ; convert_to_wav extrait en fonction libre pub(crate) convert_audio_to_wav réutilisée par VoskEngine
lib.rs : exports mis à jour (openai, vosk, SecretString depuis types)
Cargo : reqwest = { version = "0.12", features = ["multipart", "json", "rustls-tls"] } et url = "2" ajoutés au workspace et à fractal-stt

Plan de test

cargo test -p fractal-stt — tous les tests unitaires passent (OpenAI URL building, clé masquée, parsing Vosk, health checks avec binaires manquants)
cargo clippy -p fractal-stt -- -D warnings — pas d'avertissement
Vérifier que SecretString n'apparaît pas en clair dans les logs ({:?} → SecretString([REDACTED]), {} → [REDACTED])
Test d'intégration manuel : instancier OpenAiWhisperEngine avec une vraie clé et appeler health_check() → EngineStatus::Ready
Test d'intégration manuel : VoskEngine::health_check() avec /bin/true + modèle manquant → ModelMissing

Closes #6 ## Summary - **`SecretString`** : type opaque ajouté dans `types.rs` — `Debug`/`Display` masquent la valeur (`[REDACTED]`), `expose()` retourne la valeur brute au point d'usage - **`OpenAiWhisperEngine`** : appel HTTP multipart vers `{base_url}/v1/audio/transcriptions` via `reqwest` + `rustls-tls` (pas d'OpenSSL) ; `health_check()` valide la clé API via GET `{base_url}/v1/models` ; compatible OpenAI, Groq, Together… - **`VoskEngine`** : invoque `vosk-transcriber` en subprocess ; `health_check()` vérifie la présence du binaire puis du répertoire modèle ; parse le format JSON ligne-par-ligne (`{"text": "…"}`) - **`whisper.rs`** : `WHISPER_LANGUAGES` rendu `pub(crate)` ; `convert_to_wav` extrait en fonction libre `pub(crate) convert_audio_to_wav` réutilisée par `VoskEngine` - **`lib.rs`** : exports mis à jour (`openai`, `vosk`, `SecretString` depuis `types`) - **Cargo** : `reqwest = { version = "0.12", features = ["multipart", "json", "rustls-tls"] }` et `url = "2"` ajoutés au workspace et à `fractal-stt` ## Plan de test - [ ] `cargo test -p fractal-stt` — tous les tests unitaires passent (OpenAI URL building, clé masquée, parsing Vosk, health checks avec binaires manquants) - [ ] `cargo clippy -p fractal-stt -- -D warnings` — pas d'avertissement - [ ] Vérifier que `SecretString` n'apparaît pas en clair dans les logs (`{:?}` → `SecretString([REDACTED])`, `{}` → `[REDACTED]`) - [ ] Test d'intégration manuel : instancier `OpenAiWhisperEngine` avec une vraie clé et appeler `health_check()` → `EngineStatus::Ready` - [ ] Test d'intégration manuel : `VoskEngine::health_check()` avec `/bin/true` + modèle manquant → `ModelMissing`

charles added 21 commits

2026-04-06 01:57:49 +00:00

feat(stt): add OpenAiWhisperEngine (HTTP multipart, configurable base_url) a7be23c80a

feat(stt): SecretString opaque type (#6 ) 6e1b706c59

feat(stt): add VoskEngine via subprocess 615e59d08b

feat(stt): add reqwest + dirs + tempfile deps for OpenAI/Vosk engines (#6 ) 11cc4c0453

feat(stt): export OpenAiWhisperEngine, VoskEngine, SecretString (#6 )

CI / cargo check (pull_request) Waiting to run

Details

CI / cargo test (pull_request) Blocked by required conditions

Details

CI / clippy + rustfmt (pull_request) Waiting to run

Details

532b32ace3

fix(stt): corriger EngineStatus + importer SecretString depuis secret.rs (#6 )

CI / cargo check (pull_request) Waiting to run

Details

CI / cargo test (pull_request) Blocked by required conditions

Details

CI / clippy + rustfmt (pull_request) Waiting to run

Details

94e419b2cc

fix(stt): corriger EngineStatus dans VoskEngine (#6 )

CI / cargo check (pull_request) Waiting to run

Details

CI / cargo test (pull_request) Blocked by required conditions

Details

CI / clippy + rustfmt (pull_request) Waiting to run

Details

bafb41d3e9

feat(stt): exposer tous les modules + moteurs (#6 )

CI / cargo check (pull_request) Waiting to run

Details

CI / cargo test (pull_request) Blocked by required conditions

Details

CI / clippy + rustfmt (pull_request) Waiting to run

Details

fa754cbd5c

fix(stt): supprimer dep dirs inutilisée (#6 )

CI / cargo check (pull_request) Has been cancelled

Details

CI / cargo test (pull_request) Has been cancelled

Details

CI / clippy + rustfmt (pull_request) Has been cancelled

Details

edab0c898b

chore(stt): synchroniser whisper.rs depuis main pour la branche #6

CI / cargo check (pull_request) Waiting to run

Details

CI / cargo test (pull_request) Blocked by required conditions

Details

CI / clippy + rustfmt (pull_request) Waiting to run

Details

92666eb452

chore(stt): utiliser workspace pour toutes les dépendances (#6 )

CI / cargo check (pull_request) Waiting to run

Details

CI / cargo test (pull_request) Blocked by required conditions

Details

CI / clippy + rustfmt (pull_request) Waiting to run

Details

dc1b60c49e

chore: ajouter reqwest + tempfile + dirs aux dépendances workspace (#6 )

CI / cargo check (pull_request) Waiting to run

Details

CI / cargo test (pull_request) Blocked by required conditions

Details

CI / clippy + rustfmt (pull_request) Waiting to run

Details

65e1814e18

feat(stt): add audio conversion utility module (#6 )

CI / cargo check (pull_request) Waiting to run

Details

CI / cargo test (pull_request) Blocked by required conditions

Details

CI / clippy + rustfmt (pull_request) Waiting to run

Details

0845fe7249

chore: add url workspace dep to root Cargo.toml

CI / cargo check (pull_request) Waiting to run

Details

CI / cargo test (pull_request) Blocked by required conditions

Details

CI / clippy + rustfmt (pull_request) Waiting to run

Details

a6da13d417

chore: add url dep to fractal-stt Cargo.toml

CI / cargo check (pull_request) Has been cancelled

Details

CI / cargo test (pull_request) Has been cancelled

Details

CI / clippy + rustfmt (pull_request) Has been cancelled

Details

744d4c32a3

feat: add SecretString to types.rs c5ca8bd0e9

refactor: make WHISPER_LANGUAGES pub(crate) and extract convert_audio_to_wav as free function 606dc39ace

feat: add OpenAiWhisperEngine 4ceeca149b

feat: rewrite VoskEngine to match spec (convert_audio_to_wav, parse_vosk_output) a5de4313ab

feat: update lib.rs exports for openai, vosk, SecretString in types d01377f5b5

refactor: remove secret.rs, SecretString moved into types.rs

CI / cargo check (pull_request) Has been cancelled

Details

CI / cargo test (pull_request) Has been cancelled

Details

CI / clippy + rustfmt (pull_request) Has been cancelled

Details

d6227401c0

charles closed this pull request

2026-04-06 02:01:15 +00:00

CI / cargo check (pull_request) Has been cancelled

Details

CI / cargo test (pull_request) Has been cancelled

Details

CI / clippy + rustfmt (pull_request) Has been cancelled

Details

Required

Pull request closed

Please reopen this pull request to perform a merge.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/my-fractal!96

No description provided.

Rows
Columns