charles/my-fractal
1
0
Fork 0
Code Issues 14 Pull requests Projects Releases Packages Wiki Activity Actions

feat: BridgeType detection + UnifiedContact + ContactsDb (#47, #48, #49, #51) #138

Closed
charles wants to merge 5 commits from feat/47-49-51-bridge-foundation into main
pull from: feat/47-49-51-bridge-foundation
merge into: charles:main
Conversation 0 Commits 5 Files changed 5 +278 -152
charles commented 2026-04-06 02:16:58 +00:00
Owner
Copy link

Summary

Implements issues #47, #48, #49 and #51 in the fractal-bridge crate.

#47 — BridgeType::detect()

  • Rewrote bridge_type.rs with Serialize/Deserialize derives and Option-returning detect()
  • Added Instagram variant and Custom(String) for config-driven prefixes
  • Added detect_with_custom(), icon_name(), display_name()
  • 7 unit tests covering all main bridge types, human users, and custom prefixes

#48 — UnifiedContact + BridgedIdentity

  • Rewrote contact.rs with the canonical field names from the spec (matrix_user_id, external_id, external_username, primary_matrix_user_id, bridged_identities)
  • Both structs derive Serialize/Deserialize
  • BridgedIdentity::new() and UnifiedContact::{new, add_identity, bridge_types} helpers

#49 — Crate wiring

  • lib.rs now exposes contacts_db module and re-exports ContactsDb + default_db_path
  • Cargo.toml extended with serde_json, sqlx (workspace), dirs = "5"

#51 — SQLite CRUD

  • New contacts_db.rs with ContactsDb::open() (creates dir + tables), upsert_contact(), get_contact(), delete_contact()
  • DB path: ~/.local/share/fractal-plus/contacts.db
  • Tables: unified_contacts, bridged_identities (FK with ON DELETE CASCADE)
  • BridgeType round-tripped via serde_json in the bridge_type column

Test plan

  • cargo test -p fractal-bridge — all unit tests in bridge_type and contact pass
  • Manual smoke test: open a DB, upsert a contact with a Telegram identity, fetch it back, delete it
  • Verify ~/.local/share/fractal-plus/contacts.db is created at runtime with correct schema
## Summary Implements issues #47, #48, #49 and #51 in the `fractal-bridge` crate. ### #47 — `BridgeType::detect()` - Rewrote `bridge_type.rs` with `Serialize`/`Deserialize` derives and `Option`-returning `detect()` - Added `Instagram` variant and `Custom(String)` for config-driven prefixes - Added `detect_with_custom()`, `icon_name()`, `display_name()` - 7 unit tests covering all main bridge types, human users, and custom prefixes ### #48 — `UnifiedContact` + `BridgedIdentity` - Rewrote `contact.rs` with the canonical field names from the spec (`matrix_user_id`, `external_id`, `external_username`, `primary_matrix_user_id`, `bridged_identities`) - Both structs derive `Serialize`/`Deserialize` - `BridgedIdentity::new()` and `UnifiedContact::{new, add_identity, bridge_types}` helpers ### #49 — Crate wiring - `lib.rs` now exposes `contacts_db` module and re-exports `ContactsDb` + `default_db_path` - `Cargo.toml` extended with `serde_json`, `sqlx` (workspace), `dirs = "5"` ### #51 — SQLite CRUD - New `contacts_db.rs` with `ContactsDb::open()` (creates dir + tables), `upsert_contact()`, `get_contact()`, `delete_contact()` - DB path: `~/.local/share/fractal-plus/contacts.db` - Tables: `unified_contacts`, `bridged_identities` (FK with `ON DELETE CASCADE`) - `BridgeType` round-tripped via `serde_json` in the `bridge_type` column ## Test plan - [ ] `cargo test -p fractal-bridge` — all unit tests in `bridge_type` and `contact` pass - [ ] Manual smoke test: open a DB, upsert a contact with a Telegram identity, fetch it back, delete it - [ ] Verify `~/.local/share/fractal-plus/contacts.db` is created at runtime with correct schema
feat(#49): expose contacts_db module and re-exports in lib.rs
Some checks failed
CI / cargo check (pull_request) Has been cancelled
Details
CI / cargo test (pull_request) Has been cancelled
Details
CI / clippy + rustfmt (pull_request) Has been cancelled
Details
3a87dc2dac
charles closed this pull request 2026-04-06 02:21:51 +00:00
Some checks are pending
CI / cargo check (pull_request) Has been cancelled
Details
CI / cargo test (pull_request) Has been cancelled
Details
CI / clippy + rustfmt (pull_request) Has been cancelled
Details
qa
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
module:M0-setup

   
module:M1-stt

   
module:M1-stt

   
module:M2-ai

   
module:M2-ai

   
module:M3-rich

   
module:M3-rich

   
module:M4-bridge

   
module:M4-bridge

   
module:M5-bonus

   
module:M5-bonus

   
module:setup
Phase 0 — Fork, workspace Cargo, infrastructure

  
priority:high

   
priority:high

   
priority:low

   
priority:low

   
priority:medium

   
priority:medium

   
type:chore

   
type:chore

   
type:feature

   
type:feature
No labels
module:M0-setup
module:M1-stt
module:M1-stt
module:M2-ai
module:M2-ai
module:M3-rich
module:M3-rich
module:M4-bridge
module:M4-bridge
module:M5-bonus
module:M5-bonus
module:setup
priority:high
priority:high
priority:low
priority:low
priority:medium
priority:medium
type:chore
type:chore
type:feature
type:feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/my-fractal!138
No description provided.