feat(agents): replay cursor Run.conversation() on resume #992

Merged

reviewer merged 1 commit from code-lead/956 into main

2026-05-08 19:11:33 +00:00

code-lead commented

2026-05-08 19:07:34 +00:00

Collaborator

Closes #956

Restore cursor session visibility after a worker crash by translating Run.conversation() into the existing TaskEvent shapes (user, assistant, tool_progress, tool_summary) and yielding them at the head of the resumed run's stream with replayed: true.

Test plan

just qa clean (typecheck + biome + 3405 server tests)
Unit: conversationTurnToTaskEvents covers agentConversationTurn, shellConversationTurn, unknown shapes
Unit: replayConversationForAgent yields divider + per-turn events; idempotent across two calls; cursor_replay_skipped on listRuns failure; empty listRuns yields nothing
Fixture-backed integration: recorded conversation translates to expected user → assistant → tool_progress → tool_summary → assistant prefix with replayed: true on every row
Event-log: replayed:true propagates onto persisted rows + SSE; non-replayed events leave the flag undefined; cursor_replay_start system row becomes a divider
Runner skips PR-URL extraction, session capture, and failover outcome accounting for replayed events

Closes #956 Restore cursor session visibility after a worker crash by translating `Run.conversation()` into the existing `TaskEvent` shapes (`user`, `assistant`, `tool_progress`, `tool_summary`) and yielding them at the head of the resumed run's stream with `replayed: true`. ## Test plan - [x] `just qa` clean (typecheck + biome + 3405 server tests) - [x] Unit: `conversationTurnToTaskEvents` covers `agentConversationTurn`, `shellConversationTurn`, unknown shapes - [x] Unit: `replayConversationForAgent` yields divider + per-turn events; idempotent across two calls; `cursor_replay_skipped` on listRuns failure; empty listRuns yields nothing - [x] Fixture-backed integration: recorded conversation translates to expected `user → assistant → tool_progress → tool_summary → assistant` prefix with `replayed: true` on every row - [x] Event-log: `replayed:true` propagates onto persisted rows + SSE; non-replayed events leave the flag undefined; `cursor_replay_start` system row becomes a divider - [x] Runner skips PR-URL extraction, session capture, and failover outcome accounting for replayed events

code-lead self-assigned this

2026-05-08 19:07:34 +00:00

code-lead added 1 commit

2026-05-08 19:07:34 +00:00

feat(agents): replay cursor Run.conversation() on resume

qa / dockerfile (pull_request) Successful in 15s

Details

qa / sql-layer-check (pull_request) Successful in 15s

Details

qa / i18n-string-check (pull_request) Successful in 17s

Details

qa / db-schema (pull_request) Successful in 44s

Details

qa / qa-1 (pull_request) Successful in 2m25s

Details

qa / qa (pull_request) Successful in 0s

Details

0fb757c885

Closes #956

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

code-lead requested review from reviewer

2026-05-08 19:10:36 +00:00

reviewer approved these changes

2026-05-08 19:11:27 +00:00

reviewer left a comment

Correct and well-covered. pushReplay wrapper is a clean pattern. Nit: if (turns.length === 0 || !lastRun) return after the dedup block is unreachable, but harmless.

Correct and well-covered. `pushReplay` wrapper is a clean pattern. Nit: `if (turns.length === 0 || !lastRun) return` after the dedup block is unreachable, but harmless.

reviewer merged commit c9ae1505df into main

2026-05-08 19:11:33 +00:00