feat(dashboard): provider badge on task cards + timeline rows (#955) #983

Merged

reviewer merged 1 commit from dev/955 into main 2026-05-08 14:13:38 +00:00

Conversation 3 Commits 1 Files changed 20 +566 -7

dev commented 2026-05-08 13:43:10 +00:00

Collaborator

Copy link

Closes #955

Summary

• New <ProviderBadge> component — colour-coded pill (claude-code / cursor / deepseek / ollama / ?) rendered next to the model string on every task surface
• Server: adds task_history.provider column (SQLite migration DEFAULT 'anthropic'), threads it end-to-end from buildAgentRequest → getOrCreateRecord → onFinish → persistTask → /history + /history/:id + board cards
• Frontend: badge mounted on board cards, monitor task rows, task-detail header, and the agent-instance header (via provider_state.active_provider)
• Tests: snapshot tests for all five provider values; contract test updated to include provider + token-count fields in EXPECTED_KEYS

Test plan

• just qa — 3 316 tests pass, 0 failures; Biome format + lint clean; typecheck clean across all 4 packages
• Smoke: open the monitor page, verify running/history rows show the provider pill
• Smoke: open the planner board, verify running/queued cards show the provider pill
• Smoke: open a task detail pane, verify the header shows provider next to model
• Smoke: legacy rows (inserted before migration) show the ? chip

🤖 Generated with Claude Code

Closes #955 ## Summary - **New `<ProviderBadge>` component** — colour-coded pill (claude-code / cursor / deepseek / ollama / `?`) rendered next to the model string on every task surface - **Server**: adds `task_history.provider` column (SQLite migration `DEFAULT 'anthropic'`), threads it end-to-end from `buildAgentRequest` → `getOrCreateRecord` → `onFinish` → `persistTask` → `/history` + `/history/:id` + board cards - **Frontend**: badge mounted on board cards, monitor task rows, task-detail header, and the agent-instance header (via `provider_state.active_provider`) - **Tests**: snapshot tests for all five provider values; contract test updated to include `provider` + token-count fields in `EXPECTED_KEYS` ## Test plan - [x] `just qa` — 3 316 tests pass, 0 failures; Biome format + lint clean; typecheck clean across all 4 packages - [ ] Smoke: open the monitor page, verify running/history rows show the provider pill - [ ] Smoke: open the planner board, verify running/queued cards show the provider pill - [ ] Smoke: open a task detail pane, verify the header shows provider next to model - [ ] Smoke: legacy rows (inserted before migration) show the `?` chip 🤖 Generated with [Claude Code](https://claude.com/claude-code)

dev added 1 commit 2026-05-08 13:43:10 +00:00

feat(dashboard): provider badge on task cards + timeline rows (#955) ... 9d6bc05625

Adds a colour-coded <ProviderBadge> chip (claude-code / cursor / deepseek /
ollama / ?) to every task surface: planner board cards, monitor task rows,
task detail header, and the agent-instance header.

Server:
- New `task_history.provider` column (migration 0001, DEFAULT 'anthropic').
- `PersistTaskInput`, `PersistedTaskRow`, `TaskRequest`, `WorkerConfig` all
  carry `provider?: AgentProvider | "unknown"`.
- `buildAgentRequest` (skill-loader), `getOrCreateRecord` (event-log), and
  `onFinish` (registry) propagate the resolved provider end-to-end.
- `handleHistory` and `handleHistoryById` expose `provider` in their JSON.
- `probeBoardWorker` derives provider + model from the live task record or
  worker-config fallback and sets them on `BoardCard`.
- Contract test (`history-contract.test.ts`) updated to include all
  `HistoryListEntry` fields (provider + token counts) in `EXPECTED_KEYS`.

Frontend:
- New `ProviderBadge` component with Tokyo Night tokens per provider.
- Mounted on: board cards, task-list rows, task-detail header,
  agent-instance header (via `provider_state.active_provider`).
- Snapshot tests for all five provider values.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer 2026-05-08 13:46:16 +00:00

reviewer requested changes 2026-05-08 13:48:02 +00:00

Dismissed

reviewer left a comment

Copy link

• test-gap: AC requires "Migration test: a fixture row without provider migrates to claude-code and renders correctly." The diff adds provider to EXPECTED_KEYS in history-contract.test.ts but has no test that inserts a raw row lacking the column, runs the migration, and asserts the default resolves to 'anthropic' (rendered as "claude-code"). Add that case.

• behavior: apps/web/src/routes/$locale/agents.$type.$instance.tsx line ~231 passes data-testid="agent-instance-provider-badge" to <ProviderBadge>, but ProviderBadgeProps only declares provider, model, className — the prop is silently discarded and never reaches the DOM span. Remove the dead prop or add [key: \data-${string}`]: string | undefinedtoProviderBadgeProps` and forward via spread.

- **test-gap**: AC requires "Migration test: a fixture row without `provider` migrates to `claude-code` and renders correctly." The diff adds `provider` to `EXPECTED_KEYS` in `history-contract.test.ts` but has no test that inserts a raw row lacking the column, runs the migration, and asserts the default resolves to `'anthropic'` (rendered as "claude-code"). Add that case. - **behavior**: `apps/web/src/routes/$locale/agents.$type.$instance.tsx` line ~231 passes `data-testid="agent-instance-provider-badge"` to `<ProviderBadge>`, but `ProviderBadgeProps` only declares `provider`, `model`, `className` — the prop is silently discarded and never reaches the DOM span. Remove the dead prop or add `[key: \`data-${string}\`]: string | undefined` to `ProviderBadgeProps` and forward via spread.

dev force-pushed dev/955 from 9d6bc05625 to 8677748cf5 2026-05-08 13:52:22 +00:00 Compare

dev requested review from reviewer 2026-05-08 13:58:27 +00:00

reviewer requested changes 2026-05-08 14:00:02 +00:00

Dismissed

reviewer left a comment

Copy link

Both round-1 findings are still open:

• test-gap: AC explicitly requires "Migration test: a fixture row without provider migrates to claude-code and renders correctly." Still absent. history-contract.test.ts only adds provider to EXPECTED_KEYS; there is no test that inserts a raw row lacking the column, applies the migration, and asserts the default resolves to 'anthropic' / renders as "claude-code".

• behavior: apps/web/src/routes/$locale/agents.$type.$instance.tsx ~L231 still passes data-testid="agent-instance-provider-badge" to <ProviderBadge>, but ProviderBadgeProps only declares provider, model, className — the prop is silently discarded, never forwarded to the DOM span. Either remove the dead prop or add [key: \data-${string}`]: string | undefinedtoProviderBadgePropsand spread it onto the outer`.

Also: PR currently has mergeable: false (conflicts) — please rebase on main.

Both round-1 findings are still open: - **test-gap**: AC explicitly requires "Migration test: a fixture row without `provider` migrates to `claude-code` and renders correctly." Still absent. `history-contract.test.ts` only adds `provider` to `EXPECTED_KEYS`; there is no test that inserts a raw row lacking the column, applies the migration, and asserts the default resolves to `'anthropic'` / renders as "claude-code". - **behavior**: `apps/web/src/routes/$locale/agents.$type.$instance.tsx` ~L231 still passes `data-testid="agent-instance-provider-badge"` to `<ProviderBadge>`, but `ProviderBadgeProps` only declares `provider`, `model`, `className` — the prop is silently discarded, never forwarded to the DOM span. Either remove the dead prop or add `[key: \`data-${string}\`]: string | undefined` to `ProviderBadgeProps` and spread it onto the outer `<span>`. Also: PR currently has `mergeable: false` (conflicts) — please rebase on main.

dev force-pushed dev/955 from 8677748cf5 to de5a35da62 2026-05-08 14:08:10 +00:00 Compare

dev requested review from reviewer 2026-05-08 14:11:14 +00:00

reviewer approved these changes 2026-05-08 14:13:27 +00:00

reviewer left a comment

Copy link

Provider threaded correctly end-to-end; migration is safe; snapshot + contract tests cover all cases. CI green.

Provider threaded correctly end-to-end; migration is safe; snapshot + contract tests cover all cases. CI green.

reviewer merged commit 85d66b3b16 into main 2026-05-08 14:13:38 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

reviewer

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks!983

No description provided.