chore(web): narrow SCOPE_ORDER to 3 layers, drop builtin UI affordances #946

Merged

dev merged 1 commit from dev/941 into main

2026-05-08 09:27:05 +00:00

dev commented

2026-05-08 09:16:18 +00:00

Collaborator

Removes "builtin" from SCOPE_ORDER, the mcp-tab scope filter, and the service-config scope chips. Wires "Reset to factory defaults" to POST /api/service-config/reset-defaults (endpoint in separate story). ScopeId narrowed to "global"; anchored-scope.ts ladders updated to 3 tiers.

Test plan

mcp-tab.test.tsx: no builtin option in scope filter; Reset present for global cards (12 tests pass).
settings.service.test.tsx (new): no builtin chip; factory-reset button calls resetServiceConfigToFactoryDefaults.
skills-tab.test.tsx: inherited-row test updated to global-scoped ancestor.
Full vitest suite: 1001/1001 pass, Biome: 0 errors.

Closes #941

Removes `"builtin"` from `SCOPE_ORDER`, the mcp-tab scope filter, and the service-config scope chips. Wires "Reset to factory defaults" to `POST /api/service-config/reset-defaults` (endpoint in separate story). `ScopeId` narrowed to `"global"`; `anchored-scope.ts` ladders updated to 3 tiers. ## Test plan - `mcp-tab.test.tsx`: no builtin option in scope filter; Reset present for global cards (12 tests pass). - `settings.service.test.tsx` (new): no builtin chip; factory-reset button calls `resetServiceConfigToFactoryDefaults`. - `skills-tab.test.tsx`: inherited-row test updated to global-scoped ancestor. - Full vitest suite: 1001/1001 pass, Biome: 0 errors. Closes #941

dev self-assigned this

2026-05-08 09:16:18 +00:00

dev added 1 commit

2026-05-08 09:16:19 +00:00

chore(web): narrow SCOPE_ORDER to 3 layers, drop builtin UI affordances

qa / sql-layer-check (pull_request) Successful in 6s

Details

qa / dockerfile (pull_request) Successful in 8s

Details

qa / i18n-string-check (pull_request) Successful in 9s

Details

qa / db-schema (pull_request) Successful in 45s

Details

qa / qa-1 (pull_request) Successful in 1m21s

Details

qa / qa (pull_request) Successful in 0s

Details

0d45644a95

Removes "builtin" from the agent-config scope ladder and service-config
dashboard per #941. Adds resetServiceConfigToFactoryDefaults() calling
POST /api/service-config/reset-defaults (endpoint in separate story).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer

2026-05-08 09:17:51 +00:00

reviewer approved these changes

2026-05-08 09:18:45 +00:00

reviewer left a comment

Correct. SCOPE_ORDER narrowed cleanly, SCOPE_LABELS retains builtin for legacy display, context simplification is valid, factory-reset wired correctly with error handling. Tests cover all changed paths.

Nit (non-blocking): resetMutation (individual field patch) and deleteAllMutation (full factory reset) now share the same toast text "Reset to factory defaults" — minor UX ambiguity but out of scope here.

Correct. `SCOPE_ORDER` narrowed cleanly, `SCOPE_LABELS` retains `builtin` for legacy display, context simplification is valid, factory-reset wired correctly with error handling. Tests cover all changed paths. Nit (non-blocking): `resetMutation` (individual field patch) and `deleteAllMutation` (full factory reset) now share the same toast text "Reset to factory defaults" — minor UX ambiguity but out of scope here.

reviewer commented

2026-05-08 09:18:50 +00:00

Collaborator

PR has conflicts — please rebase on main before merging.