chore(service-config): extract factory defaults to code constants #942

Merged

dev merged 1 commit from dev/935 into main

2026-05-08 09:08:49 +00:00

dev commented

2026-05-08 09:05:43 +00:00

Collaborator

New setup/service-config-defaults.ts exports SERVICE_CONFIG_DEFAULTS — a frozen object covering all nullable service_config columns (container_image, container_image_default, webhook_secret_ref, watchdogs_json, penpot_json, speech_json, janitor_json), each with a one-line comment naming its dashboard surface. service-config-settings.ts now synthesises the builtin response from this constant instead of querying scope='builtin' in the DB.

Test plan

Unit tests in service-config-defaults.test.ts: shape matches schema columns, all values null, object frozen.
just qa clean — 3266 tests pass, Biome format + lint clean.

Closes #935

New `setup/service-config-defaults.ts` exports `SERVICE_CONFIG_DEFAULTS` — a frozen object covering all nullable `service_config` columns (`container_image`, `container_image_default`, `webhook_secret_ref`, `watchdogs_json`, `penpot_json`, `speech_json`, `janitor_json`), each with a one-line comment naming its dashboard surface. `service-config-settings.ts` now synthesises the `builtin` response from this constant instead of querying `scope='builtin'` in the DB. ## Test plan - Unit tests in `service-config-defaults.test.ts`: shape matches schema columns, all values null, object frozen. - `just qa` clean — 3266 tests pass, Biome format + lint clean. Closes #935

dev self-assigned this

2026-05-08 09:05:44 +00:00

dev added 1 commit

2026-05-08 09:05:44 +00:00

chore(service-config): extract factory defaults to code constants

qa / sql-layer-check (pull_request) Successful in 7s

Details

qa / dockerfile (pull_request) Successful in 8s

Details

qa / i18n-string-check (pull_request) Successful in 12s

Details

qa / db-schema (pull_request) Successful in 42s

Details

qa / qa-1 (pull_request) Successful in 1m13s

Details

qa / qa (pull_request) Successful in 0s

Details

074d2c330f

Add `setup/service-config-defaults.ts` with `SERVICE_CONFIG_DEFAULTS`
(raw JSON column names, all null, each commented with its dashboard
surface). Update `service-config-settings.ts` to synthesise the
`builtin` response from code constants instead of querying the DB.

Closes #935

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer

2026-05-08 09:07:50 +00:00

reviewer approved these changes

2026-05-08 09:08:40 +00:00

reviewer left a comment

Correct extraction — BUILTIN_ROW synthesised from frozen constant, SQL tightened to WHERE scope = 'global', tests cover shape/values/freeze. Nit: null-check ternaries in BUILTIN_ROW are dead code (all defaults null) but harmless.

Correct extraction — `BUILTIN_ROW` synthesised from frozen constant, SQL tightened to `WHERE scope = 'global'`, tests cover shape/values/freeze. Nit: null-check ternaries in `BUILTIN_ROW` are dead code (all defaults null) but harmless.

dev merged commit 9be1124a8b into main

2026-05-08 09:08:49 +00:00

dev referenced this pull request from a commit

2026-05-08 09:08:50 +00:00

chore(service-config): extract factory defaults to code constants (#942)

reviewer commented

2026-05-08 09:08:57 +00:00

Collaborator

Merge call returned false — please merge manually.

Merge call returned `false` — please merge manually.