feat(skills): drop preview pane — Crepe editor is already WYSIWYG #926

Merged
reviewer merged 1 commit from fix/skills-drop-preview-pane into main 2026-05-07 18:27:14 +00:00
Collaborator

Summary

The skill editor drawer rendered Markdown twice — left pane was the new <MarkdownEditor> (Milkdown Crepe, visual mode) and the right pane re-rendered the same draft via <Markdown>. Crepe's visual mode already shows the rendered output inline, so the right pane was just a duplicate that ate half the drawer width.

Drop the preview pane, the toggle button, and the previewOpen state. Editor now fills the whole drawer body. Same <MarkdownEditor> + Assistant button on top.

This commit was originally part of PR #925 but landed on the branch after the squash-merge already closed it; carrying it across as a follow-up.

Test plan

  • just qa clean — 3263 server tests + lint + typecheck + paraglide-check
  • No test referenced editor-preview-toggle or the <Markdown> import — nothing else to update

Closes #882 (the editor-UX half).

## Summary The skill editor drawer rendered Markdown twice — left pane was the new `<MarkdownEditor>` (Milkdown Crepe, visual mode) and the right pane re-rendered the same draft via `<Markdown>`. Crepe's visual mode already shows the rendered output inline, so the right pane was just a duplicate that ate half the drawer width. Drop the preview pane, the toggle button, and the `previewOpen` state. Editor now fills the whole drawer body. Same `<MarkdownEditor>` + Assistant button on top. This commit was originally part of PR #925 but landed on the branch after the squash-merge already closed it; carrying it across as a follow-up. ## Test plan - [x] `just qa` clean — 3263 server tests + lint + typecheck + paraglide-check - [x] No test referenced `editor-preview-toggle` or the `<Markdown>` import — nothing else to update Closes #882 (the editor-UX half).
feat(skills): drop preview pane — Crepe editor is already WYSIWYG
Some checks failed
qa / sql-layer-check (pull_request) Successful in 15s
qa / i18n-string-check (pull_request) Successful in 17s
qa / dockerfile (pull_request) Successful in 21s
qa / db-schema (pull_request) Failing after 23s
qa / qa-1 (pull_request) Failing after 22s
qa / qa (pull_request) Failing after 0s
ca64caf1c2
The skill editor drawer rendered Markdown twice — left pane was the
new `<MarkdownEditor>` (Milkdown Crepe, visual mode) and the right
pane re-rendered the same draft via `<Markdown>`. Crepe's visual mode
already shows the rendered output inline, so the right pane was just
a duplicate that ate half the drawer width.

Drop the preview pane, the toggle button, and the `previewOpen`
state. Editor now fills the whole drawer body. Same `<MarkdownEditor>`
+ Assistant button on top.

No test changes — none referenced `editor-preview-toggle` or the
`<Markdown>` import.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator

🚫 Dispatch aborted: skill 'fix-ci' missing for agent type 'claude-desktop'. Seed it at /agents/claude-desktop/skills.

🚫 Dispatch aborted: skill 'fix-ci' missing for agent type 'claude-desktop'. Seed it at /agents/claude-desktop/skills.
charles force-pushed fix/skills-drop-preview-pane from ca64caf1c2
Some checks failed
qa / sql-layer-check (pull_request) Successful in 15s
qa / i18n-string-check (pull_request) Successful in 17s
qa / dockerfile (pull_request) Successful in 21s
qa / db-schema (pull_request) Failing after 23s
qa / qa-1 (pull_request) Failing after 22s
qa / qa (pull_request) Failing after 0s
to 0701183a06
All checks were successful
qa / sql-layer-check (pull_request) Successful in 15s
qa / i18n-string-check (pull_request) Successful in 21s
qa / dockerfile (pull_request) Successful in 22s
qa / db-schema (pull_request) Successful in 25s
qa / qa-1 (pull_request) Successful in 2m16s
qa / qa (pull_request) Successful in 0s
2026-05-07 18:22:58 +00:00
Compare
reviewer approved these changes 2026-05-07 18:27:08 +00:00
reviewer left a comment

Clean removal — previewOpen state, toggle button, Eye/Markdown imports all gone, editor fills the drawer correctly. CI green.

Clean removal — `previewOpen` state, toggle button, `Eye`/`Markdown` imports all gone, editor fills the drawer correctly. CI green.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/claude-hooks!926
No description provided.