chore(i18n): docs, CI missing-key guard, locale-sync tests #922

Merged

charles merged 1 commit from dev/910 into main 2026-05-07 16:07:51 +00:00

Conversation 9 Commits 1 Files changed 5 +326 -2

dev commented 2026-05-07 14:02:20 +00:00

Collaborator

Copy link

Implements #910 (US-C1, US-C2, US-C3).

• docs/i18n.md: contributor one-pager — add message, add locale, codegen/build, router/Link pitfalls, allowed-literal exceptions for reviewers
• justfile: paraglide-check added to qa; fails when a non-source locale file is missing keys present in en.json
• $locale.tsx: sync document.documentElement.lang on locale change
• $locale.test.tsx: 7 Vitest tests — locale sync contract, beforeLoad guard, rollout-area coverage (onboarding + settings, pilot locale en)
• vitest.setup.tsx: global stub for @/paraglide/runtime; drops unused SUPPORTED_LOCALES import

Test plan

• 984 Vitest tests pass (7 new)
• Biome check: 0 errors
• tsc: clean
• paraglide-check passes with 0 non-source locales; fails on missing keys when a second locale is added

Closes #910

Implements #910 (US-C1, US-C2, US-C3). - `docs/i18n.md`: contributor one-pager — add message, add locale, codegen/build, router/Link pitfalls, allowed-literal exceptions for reviewers - `justfile`: `paraglide-check` added to `qa`; fails when a non-source locale file is missing keys present in `en.json` - `$locale.tsx`: sync `document.documentElement.lang` on locale change - `$locale.test.tsx`: 7 Vitest tests — locale sync contract, `beforeLoad` guard, rollout-area coverage (onboarding + settings, pilot locale `en`) - `vitest.setup.tsx`: global stub for `@/paraglide/runtime`; drops unused `SUPPORTED_LOCALES` import ## Test plan - 984 Vitest tests pass (7 new) - Biome check: 0 errors - tsc: clean - `paraglide-check` passes with 0 non-source locales; fails on missing keys when a second locale is added Closes #910

dev self-assigned this 2026-05-07 14:02:20 +00:00

dev added 1 commit 2026-05-07 14:02:20 +00:00

chore(i18n): docs, CI missing-key guard, locale-sync tests (#910) ... 2089d3a29f

- docs/i18n.md: contributor one-pager (add message, add locale, codegen,
  router/Link pitfalls, allowed-literal exceptions for reviewers)
- justfile: add `paraglide-check` recipe to `qa`; fails when a non-source
  locale file is missing keys present in en.json
- $locale.tsx: sync document.documentElement.lang on locale change (#910)
- $locale.test.tsx: 7 Vitest tests covering locale sync contract, beforeLoad
  guard, and rollout-area (onboarding + settings) lang assertions (US-C3)
- vitest.setup.tsx: global stub for @/paraglide/runtime so tests don't
  require a codegen pass; also removes unused SUPPORTED_LOCALES import

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer 2026-05-07 14:05:23 +00:00

reviewer refused to review 2026-05-07 14:06:41 +00:00

reviewer commented 2026-05-07 14:06:46 +00:00

Collaborator

Copy link

CI still pending at review time (run #3161, sha 2089d3a). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3161, sha `2089d3a`). Stepping off the review request — will be re-dispatched automatically when CI completes.

reviewer commented 2026-05-07 14:07:35 +00:00

Collaborator

Copy link

CI still pending at review time (run #1639, sha 2089d3a). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #1639, sha `2089d3a`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-07 14:09:38 +00:00

reviewer refused to review 2026-05-07 14:11:10 +00:00

reviewer commented 2026-05-07 14:11:13 +00:00

Collaborator

Copy link

CI still pending at review time (run #1639, sha 2089d3a). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #1639, sha `2089d3a`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-07 14:50:21 +00:00

reviewer refused to review 2026-05-07 14:55:26 +00:00

reviewer commented 2026-05-07 14:55:30 +00:00

Collaborator

Copy link

CI still pending at review time (run #3161, sha 2089d3a). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3161, sha `2089d3a`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-07 14:58:55 +00:00

reviewer refused to review 2026-05-07 15:01:06 +00:00

reviewer commented 2026-05-07 15:01:09 +00:00

Collaborator

Copy link

CI still pending at review time (run #3161, sha 2089d3a). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3161, sha `2089d3a`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-07 15:14:49 +00:00

reviewer commented 2026-05-07 15:16:03 +00:00

Collaborator

Copy link

Merge call returned false — manual merge required.

Merge call returned false — manual merge required.

reviewer commented 2026-05-07 15:33:52 +00:00

Collaborator

Copy link

Merge returned false — manual merge required.

Merge returned `false` — manual merge required.

reviewer commented 2026-05-07 15:45:40 +00:00

Collaborator

Copy link

Merge call returned false — please merge manually.

Merge call returned `false` — please merge manually.

reviewer approved these changes 2026-05-07 15:54:13 +00:00

reviewer left a comment

Copy link

approve

approve

charles referenced this pull request from a commit 2026-05-07 15:58:56 +00:00

fix(forge): submit_review APPROVE → APPROVED + janitor no-task fallback

charles merged commit 88aad26dd8 into main 2026-05-07 16:07:51 +00:00

charles deleted branch dev/910 2026-05-07 16:07:52 +00:00

charles referenced this pull request from a commit 2026-05-07 16:07:52 +00:00

chore(i18n): docs, CI missing-key guard, locale-sync tests (#922)

Sign in to join this conversation.

Reviewers

No reviewers

reviewer

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

dev

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks!922

No description provided.