feat(agents): HTTP CRUD for agent_skill (SR-7, #875) #890

Merged

charles merged 2 commits from feat/875-agent-skill-crud into main 2026-05-05 22:55:33 +00:00

Conversation 0 Commits 2 Files changed 5 +412

claude-desktop commented 2026-05-05 22:27:02 +00:00

Collaborator

Copy link

Implements SR-7 (#875): operator-auth CRUD for agent_skill at /agents/:agentType/skills (type scope) and /agents/:agentType/:instanceId/skills (instance scope).

• Instance GET returns { skills, inherits_from_type }.
• Instance POST adds pool_session_warning + pool_sessions when active pooled SDK sessions exist for that agent type.
• Adds getAgentByRowId, listActiveSessionsForAgentType, and agent-skill-routes.test.ts.

Fork branch off latest main after SR-6 merge.

Implements SR-7 (#875): operator-auth CRUD for `agent_skill` at `/agents/:agentType/skills` (type scope) and `/agents/:agentType/:instanceId/skills` (instance scope). - Instance GET returns `{ skills, inherits_from_type }`. - Instance POST adds `pool_session_warning` + `pool_sessions` when active pooled SDK sessions exist for that agent type. - Adds `getAgentByRowId`, `listActiveSessionsForAgentType`, and `agent-skill-routes.test.ts`. Fork branch off latest `main` after SR-6 merge.

claude-desktop added 1 commit 2026-05-05 22:27:02 +00:00

feat(agents): HTTP CRUD for agent_skill rows (SR-7, #875) ... 6f4cc78d72

Expose type- and instance-scoped skill CRUD under /agents/:type/skills and
/agents/:type/:instanceId/skills with operator auth, pool session warning
on instance POST, and unit tests.

Co-authored-by: Cursor <cursoragent@cursor.com>

charles added 1 commit 2026-05-05 22:54:12 +00:00

fix(agents): address SR-7 review nits ... 2512005672

- Use getAgentTypeSkill() point-lookup instead of list+find after type upsert
- Drop dead try/catch in handleAgentInstanceSkillsPost (resolveInstance already guards type mismatch)
- Remove unused getSessionMaxAgeMs export
- Fix misleading route-registration comment in main.ts (no segment collision risk)

Co-authored-by: Cursor <cursoragent@cursor.com>

charles merged commit 455a14e5be into main 2026-05-05 22:55:33 +00:00

charles deleted branch feat/875-agent-skill-crud 2026-05-05 22:55:33 +00:00

charles referenced this pull request from a commit 2026-05-05 22:55:34 +00:00

feat(agents): HTTP CRUD for agent_skill (SR-7, #875) (#890)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks!890

No description provided.