charles/claude-hooks
1
0
Fork 0
Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

chore(secrets): rename FORGEJO_TOKEN_* → FORGE_TOKEN_* #868

Merged
reviewer merged 1 commit from dev/867 into main 2026-05-05 06:46:08 +00:00
Conversation 1 Commits 1 Files changed 8 +92 -8
dev commented 2026-05-05 06:43:08 +00:00
Collaborator
Copy link

Collapses the per-type forge-token secret prefix to the forge-neutral FORGE_TOKEN_<TYPE> name, eliminating the Forgejo-specific prefix and the duplicate-row problem.

Closes #867

Test plan

  • just qa passes (3158 tests, typecheck + Biome clean)
  • New unit tests: prefix migration (rename, coexistence, idempotency)
  • migrateSecretsForLegacyTypeRenames extended to cover FORGE_TOKEN_BOSS/FOREMAN pairs
  • onboarding-apply test asserts FORGE_TOKEN_* names
Collapses the per-type forge-token secret prefix to the forge-neutral `FORGE_TOKEN_<TYPE>` name, eliminating the Forgejo-specific prefix and the duplicate-row problem. Closes #867 ## Test plan - `just qa` passes (3158 tests, typecheck + Biome clean) - New unit tests: prefix migration (rename, coexistence, idempotency) - `migrateSecretsForLegacyTypeRenames` extended to cover `FORGE_TOKEN_BOSS/FOREMAN` pairs - `onboarding-apply` test asserts `FORGE_TOKEN_*` names
dev self-assigned this 2026-05-05 06:43:08 +00:00
chore(secrets): rename FORGEJO_TOKEN_* → FORGE_TOKEN_* (#867)
All checks were successful
qa / sql-layer-check (pull_request) Successful in 7s
Details
qa / dockerfile (pull_request) Successful in 9s
Details
qa / db-schema (pull_request) Successful in 11s
Details
qa / qa-1 (pull_request) Successful in 42s
Details
qa / qa (pull_request) Successful in 0s
Details
09b5967e49 
Unify the per-type forge-token secret prefix to the forge-neutral
FORGE_TOKEN_<TYPE> name used by the FORGE_TOKEN env var injected at
dispatch. Adds an idempotent boot migration that copies legacy rows to
the new prefix and covers type-rename pairs (boss/foreman) for both
prefixes.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dev requested review from reviewer 2026-05-05 06:43:55 +00:00
reviewer approved these changes 2026-05-05 06:45:57 +00:00
reviewer left a comment
Copy link

Migration logic correct, idempotent, coexistence case handled. All AC met.

Nit (non-blocking): resolver.test.ts:818 comment still says ${SECRET:FORGEJO_TOKEN_DEV} — should be FORGE_TOKEN_DEV now.

Migration logic correct, idempotent, coexistence case handled. All AC met. Nit (non-blocking): `resolver.test.ts:818` comment still says `${SECRET:FORGEJO_TOKEN_DEV}` — should be `FORGE_TOKEN_DEV` now.
Sign in to join this conversation.
Reviewers
No reviewers
reviewer
Labels
Clear labels   
area:agents
Agent types, pool scheduling, per-instance config

  
area:dashboard
Dashboard UI and observability surfaces

  
area:database
DB layer — schema, migrations, ORM, raw SQL

  
area:design
UI/UX mockup work — routes to designer agent

  
area:design-review
Design review dispatch — routes to design-reviewer agent

  
area:flows
Flow runner — YAML loader, executor, op registry, expression eval

  
area:infra
Deployment, isolation, containers, systemd units

  
area:meta
Tracking, scaffolding, project setup

  
area:security
Security — routes to reviewer-security (opus)

  
area:sessions
Session-id store, Claude SDK resume logic

  
area:webhook
Forgejo webhook routing and handlers

  
area:workdir
Clone cache, worktrees, git identity

  
security
Security-sensitive issue

  
type:bug
Bug

  
type:chore
Chore

  
type:meta
Tracking or decisions, not implementation work

  
type:user-story
User story

No labels
area:agents
area:dashboard
area:database
area:design
area:design-review
area:flows
area:infra
area:meta
area:security
area:sessions
area:webhook
area:workdir
security
type:bug
type:chore
type:meta
type:user-story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dev
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/claude-hooks!868
No description provided.