feat(settings): split agent-config tabs to side-nav routes (SU-3, #834) #851

Merged

reviewer merged 2 commits from dev/834 into main

2026-05-04 20:53:43 +00:00

dev commented

2026-05-04 20:45:48 +00:00

Collaborator

Replaces /settings/agent-config?tab=* with three routes under a new /settings/agents layout shell with side-nav (Types, Per-agent secrets, Config history, Admin).

/settings/agents/per-agent-secrets — per-agent secret editor (was ?tab=secrets)
/settings/agents/config-history — paginated revision list (was ?tab=history), preserves ?q= param
/settings/agents/admin — wizard reset (was ?tab=admin)
Old /settings/agent-config?tab=* URLs redirect to new routes
Links in agents.$type.* updated to navigate to new route

Test plan

21 new/updated tests pass; full suite 916/916 green
Verify old /settings/agent-config?tab=history&q=foo redirects to /settings/agents/config-history?q=foo
Verify side-nav shows Types / Per-agent secrets / Config history / Admin

Closes #834

Replaces `/settings/agent-config?tab=*` with three routes under a new `/settings/agents` layout shell with side-nav (Types, Per-agent secrets, Config history, Admin). - `/settings/agents/per-agent-secrets` — per-agent secret editor (was `?tab=secrets`) - `/settings/agents/config-history` — paginated revision list (was `?tab=history`), preserves `?q=` param - `/settings/agents/admin` — wizard reset (was `?tab=admin`) - Old `/settings/agent-config?tab=*` URLs redirect to new routes - Links in `agents.$type.*` updated to navigate to new route ## Test plan - 21 new/updated tests pass; full suite 916/916 green - Verify old `/settings/agent-config?tab=history&q=foo` redirects to `/settings/agents/config-history?q=foo` - Verify side-nav shows Types / Per-agent secrets / Config history / Admin Closes #834

dev self-assigned this

2026-05-04 20:45:48 +00:00

dev added 2 commits

2026-05-04 20:45:48 +00:00

feat(settings): split agent-config tabs to side-nav routes (SU-3) 8a504d6864

Replaces the single `/settings/agent-config?tab=*` page with three
sibling routes under a new `/settings/agents` layout shell:
- `/settings/agents/per-agent-secrets` (was ?tab=secrets)
- `/settings/agents/config-history`    (was ?tab=history)
- `/settings/agents/admin`             (was ?tab=admin)

Old URLs redirect to the matching new routes, preserving the `q` param
for config-history. Side-nav exposes Types, Per-agent secrets, Config
history, Admin under the Agents group.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(settings): correct ReactElement import in config-history test

qa / dockerfile (pull_request) Successful in 18s

Details

qa / qa-1 (pull_request) Successful in 4m25s

Details

qa / qa (pull_request) Successful in 0s

Details

48b79ca422

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer

2026-05-04 20:50:17 +00:00

reviewer approved these changes

2026-05-04 20:53:35 +00:00

reviewer left a comment

CI green, all AC from #834 met.

Nit (non-blocking): /settings/agents bare has no index redirect — Outlet renders empty if navigated to directly. The settings.service group sets the precedent with an index route. Worth adding a settings.agents.index.tsx that redirects to per-agent-secrets in a follow-up.

CI green, all AC from #834 met. Nit (non-blocking): `/settings/agents` bare has no index redirect — Outlet renders empty if navigated to directly. The `settings.service` group sets the precedent with an index route. Worth adding a `settings.agents.index.tsx` that redirects to `per-agent-secrets` in a follow-up.

reviewer merged commit 38094189cc into main

2026-05-04 20:53:43 +00:00

reviewer referenced this pull request from a commit

2026-05-04 20:53:44 +00:00

feat(settings): split agent-config tabs to side-nav routes (SU-3, #834) (#851)