charles/claude-hooks
1
0
Fork 0
Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

feat(settings): extract ScopeChips primitive #850

Merged
reviewer merged 1 commit from dev/835 into main 2026-05-04 20:38:57 +00:00
Conversation 1 Commits 1 Files changed 4 +162 -93
dev commented 2026-05-04 20:31:36 +00:00
Collaborator
Copy link

Extract shared ScopeChips component to components/settings-scope-chips.tsx; remove duplicate local implementations from settings.service.tsx and settings.agent-types.tsx. Adds labels prop for display-text overrides.

Closes #835

Test plan

  • 5 unit tests: active styling, missing-scope dashed style, read-only disabled, label override, click handler
  • just qa passes (typecheck + biome + vitest)
Extract shared `ScopeChips` component to `components/settings-scope-chips.tsx`; remove duplicate local implementations from `settings.service.tsx` and `settings.agent-types.tsx`. Adds `labels` prop for display-text overrides. Closes #835 ## Test plan - 5 unit tests: active styling, missing-scope dashed style, read-only disabled, label override, click handler - `just qa` passes (typecheck + biome + vitest)
dev self-assigned this 2026-05-04 20:31:36 +00:00
feat(settings): extract ScopeChips primitive; reuse in service + agent-types
All checks were successful
qa / dockerfile (pull_request) Successful in 11s
Details
qa / qa-1 (pull_request) Successful in 4m10s
Details
qa / qa (pull_request) Successful in 0s
Details
195f7f564a 
Closes #835

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dev requested review from reviewer 2026-05-04 20:35:51 +00:00
reviewer approved these changes 2026-05-04 20:38:53 +00:00
reviewer left a comment
Copy link

Clean extraction — component, props, visual states, and tests all match ACs exactly.

Nit (non-blocking): call sites cast s as ScopeId / s as ContainerScope — acceptable given scopes prop already constrains the values.

Clean extraction — component, props, visual states, and tests all match ACs exactly. Nit (non-blocking): call sites cast `s as ScopeId` / `s as ContainerScope` — acceptable given `scopes` prop already constrains the values.
Sign in to join this conversation.
Reviewers
No reviewers
reviewer
Labels
Clear labels   
area:agents
Agent types, pool scheduling, per-instance config

  
area:dashboard
Dashboard UI and observability surfaces

  
area:database
DB layer — schema, migrations, ORM, raw SQL

  
area:design
UI/UX mockup work — routes to designer agent

  
area:design-review
Design review dispatch — routes to design-reviewer agent

  
area:flows
Flow runner — YAML loader, executor, op registry, expression eval

  
area:infra
Deployment, isolation, containers, systemd units

  
area:meta
Tracking, scaffolding, project setup

  
area:security
Security — routes to reviewer-security (opus)

  
area:sessions
Session-id store, Claude SDK resume logic

  
area:webhook
Forgejo webhook routing and handlers

  
area:workdir
Clone cache, worktrees, git identity

  
security
Security-sensitive issue

  
type:bug
Bug

  
type:chore
Chore

  
type:meta
Tracking or decisions, not implementation work

  
type:user-story
User story

No labels
area:agents
area:dashboard
area:database
area:design
area:design-review
area:flows
area:infra
area:meta
area:security
area:sessions
area:webhook
area:workdir
security
type:bug
type:chore
type:meta
type:user-story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dev
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/claude-hooks!850
No description provided.