settings/SU-2: relocate Voice input; merge Watched repos into Repositories #838

Merged

dev merged 3 commits from dev/833 into main 2026-05-04 22:04:52 +00:00

Conversation 7 Commits 3 Files changed 6 +333 -64

dev commented 2026-05-04 20:20:36 +00:00

Collaborator

Copy link

Lifts VoiceInputGroup out of the settings hub into its own /settings/voice route, and moves WatchedReposSection from the hub into the Repositories page.

• New route settings.voice.tsx at /settings/voice with breadcrumb, page header, and full Save/Discard form
• Hub gains a Voice input card link; inline VoiceInputGroup and WatchedReposSection removed (~350 LOC trimmed)
• settings.repos.tsx gains WatchedReposSection above the repo browser; migrated-row error dot and Rotate button preserved
• settings.voice-input.test.tsx updated to import from settings.voice
• routeTree.gen.ts updated with /settings/voice registration

Closes #833

Test plan

• 912 tests pass
• /settings/voice renders form, status pill, Test button
• /settings/repos shows watched-repos list above the browser
• Hub shows Voice input card link, no inline form

Lifts VoiceInputGroup out of the settings hub into its own /settings/voice route, and moves WatchedReposSection from the hub into the Repositories page. - New route settings.voice.tsx at /settings/voice with breadcrumb, page header, and full Save/Discard form - Hub gains a Voice input card link; inline VoiceInputGroup and WatchedReposSection removed (~350 LOC trimmed) - settings.repos.tsx gains WatchedReposSection above the repo browser; migrated-row error dot and Rotate button preserved - settings.voice-input.test.tsx updated to import from settings.voice - routeTree.gen.ts updated with /settings/voice registration Closes #833 ## Test plan - 912 tests pass - /settings/voice renders form, status pill, Test button - /settings/repos shows watched-repos list above the browser - Hub shows Voice input card link, no inline form

dev added 1 commit 2026-05-04 20:20:36 +00:00

feat(settings): relocate voice input to own route; merge watched repos into repos page ... 6cb32d25ed

Closes #833

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer 2026-05-04 20:27:00 +00:00

reviewer requested changes 2026-05-04 20:29:53 +00:00

Dismissed

reviewer left a comment

Copy link

• test-gap apps/web/src/routes/settings.repos.tsx: AC #833 explicitly requires "Repos page renders both watched-repos list and repo browser." No settings.repos.test.tsx exists — neither new nor updated. Add a test that renders ReposRoute with mocked fetchWatchedRepos + fetchForgesActiveRepos and asserts both [data-testid="watched-repos-section"] and [data-testid="repos-section"] are present.

- **test-gap** `apps/web/src/routes/settings.repos.tsx`: AC #833 explicitly requires "Repos page renders both watched-repos list and repo browser." No `settings.repos.test.tsx` exists — neither new nor updated. Add a test that renders `ReposRoute` with mocked `fetchWatchedRepos` + `fetchForgesActiveRepos` and asserts both `[data-testid="watched-repos-section"]` and `[data-testid="repos-section"]` are present.

dev added 1 commit 2026-05-04 21:15:42 +00:00

test(web): add settings.repos route tests (SU-2 / #833) ... 8540cae6c4

Adds `settings.repos.test.tsx` covering AC #833: asserts both
`[data-testid="watched-repos-section"]` and `[data-testid="repos-section"]`
are present when `ReposRoute` renders with mocked API calls.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev commented 2026-05-04 21:15:55 +00:00

Author

Collaborator

Copy link

Added settings.repos.test.tsx in 8540cae — renders ReposRoute with mocked fetchWatchedRepos + fetchForgesActiveRepos and asserts both [data-testid="watched-repos-section"] and [data-testid="repos-section"] are present.

Added `settings.repos.test.tsx` in 8540cae — renders `ReposRoute` with mocked `fetchWatchedRepos` + `fetchForgesActiveRepos` and asserts both `[data-testid="watched-repos-section"]` and `[data-testid="repos-section"]` are present.

dev requested review from reviewer 2026-05-04 21:22:53 +00:00

dev force-pushed dev/833 from 8540cae6c4 to de744242ef 2026-05-04 21:23:21 +00:00 Compare

reviewer refused to review 2026-05-04 21:24:58 +00:00

reviewer commented 2026-05-04 21:25:02 +00:00

Collaborator

Copy link

CI still pending at review time (run #3063, sha de74424). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3063, sha `de74424`). Stepping off the review request — will be re-dispatched automatically when CI completes.

reviewer commented 2026-05-04 21:26:48 +00:00

Collaborator

Copy link

CI still pending at review time (run #3063, sha de74424). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3063, sha `de74424`). Stepping off the review request — will be re-dispatched automatically when CI completes.

reviewer commented 2026-05-04 21:28:12 +00:00

Collaborator

Copy link

CI still pending at review time (run #3063, sha de744242). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3063, sha `de744242`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-04 21:29:38 +00:00

reviewer approved these changes 2026-05-04 21:33:48 +00:00

reviewer left a comment

Copy link

Test gap from round 1 addressed: settings.repos.test.tsx added, asserts both watched-repos-section and repos-section present. CI green (run #3063).

Test gap from round 1 addressed: `settings.repos.test.tsx` added, asserts both `watched-repos-section` and `repos-section` present. CI green (run #3063).

reviewer commented 2026-05-04 21:34:00 +00:00

Collaborator

Copy link

PR has conflicts — please rebase on main before merging.

PR has conflicts — please rebase on main before merging.

dev force-pushed dev/833 from de744242ef to 95a2a10138 2026-05-04 21:58:20 +00:00 Compare

dev force-pushed dev/833 from 95a2a10138 to fcfe278da2 2026-05-04 22:03:32 +00:00 Compare

dev merged commit ae60f552d5 into main 2026-05-04 22:04:52 +00:00

dev referenced this pull request from a commit 2026-05-04 22:04:53 +00:00

settings/SU-2: relocate Voice input; merge Watched repos into Repositories (#838)

charles referenced this pull request from a commit 2026-05-04 22:11:54 +00:00

fix(dispatch): dedup rebase against in-flight queue, not just task_history

claude-desktop referenced this pull request 2026-05-04 22:12:07 +00:00

fix(dispatch): dedup rebase against in-flight queue, not just task_history #859

Sign in to join this conversation.

Reviewers

No reviewers

reviewer

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks!838

No description provided.