DOB-5: rip config/*.json from the repo + Docker build context #820

Merged

reviewer merged 1 commit from code-lead/797 into main

2026-05-04 01:16:19 +00:00

code-lead commented

2026-05-04 01:06:32 +00:00

Collaborator

Replaces every config/*.json factory file with code-side defaults (typed AGENTS_DEFAULT_CONFIG const + inlined MCP env-key locks). loadWebhookConfig now accepts the const directly so the boot path no longer reads any JSON off disk. The dashboard CRUD remains the only edit surface.

Closes #797

Test plan

bun x turbo run typecheck — green
bun x @biomejs/biome check . — green
bun x turbo run test — 3213 / 3213 pass
grep -r 'config/.*\.json' apps/ packages/ Dockerfile justfile README.md docs/ — only references that explicitly note the migration
ls config/ — directory removed
Cold boot smoke: service comes up against a populated DB without reading the deleted JSON files

Replaces every `config/*.json` factory file with code-side defaults (typed `AGENTS_DEFAULT_CONFIG` const + inlined MCP env-key locks). `loadWebhookConfig` now accepts the const directly so the boot path no longer reads any JSON off disk. The dashboard CRUD remains the only edit surface. Closes #797 ## Test plan - [x] `bun x turbo run typecheck` — green - [x] `bun x @biomejs/biome check .` — green - [x] `bun x turbo run test` — 3213 / 3213 pass - [x] `grep -r 'config/.*\.json' apps/ packages/ Dockerfile justfile README.md docs/` — only references that explicitly note the migration - [x] `ls config/` — directory removed - [ ] Cold boot smoke: service comes up against a populated DB without reading the deleted JSON files

code-lead self-assigned this

2026-05-04 01:06:32 +00:00

code-lead added 1 commit

2026-05-04 01:06:32 +00:00

chore(config): rip config/*.json from the repo + Docker build context (DOB-5, #797 )

qa / dockerfile (pull_request) Successful in 15s

Details

qa / qa-1 (pull_request) Successful in 2m48s

Details

qa / qa (pull_request) Successful in 0s

Details

ca9fcc20ec

The factory-image fleet config moves into a typed `AGENTS_DEFAULT_CONFIG`
TS const (apps/server/src/shared/config/agents-default-config.ts);
loadWebhookConfig now accepts that const directly so the boot path no
longer reads any JSON off disk. The MCP env-key lock map is inlined in
mcp-locks.ts. justfile recipes that iterated agents.json switch to docker
filters / env vars / the canonical ~/.config/claude-hooks/agent-env
layout. Legacy /config/agents PUT/GET handlers stay registered but
return 503 — dashboard CRUD is the live edit surface. Docs rewritten to
say so.

Closes #797

code-lead requested review from reviewer

2026-05-04 01:09:24 +00:00

reviewer approved these changes

2026-05-04 01:15:58 +00:00

reviewer left a comment

All 9 config/*.json files deleted, config/ dir gone, scripts/config-split.ts removed. AGENTS_DEFAULT_CONFIG typed const is a faithful mirror of the old JSON fleet. loadWebhookConfig union overload (string | object) and the runWatchedReposBootMigration null-path are correct. Dockerfile never had COPY config/ so no image-layer delta — vacuously satisfies that AC. docs/configuration.md rewritten, CLAUDE.md + justfile updated, tests aligned. CI green (run #3008).

All 9 `config/*.json` files deleted, `config/` dir gone, `scripts/config-split.ts` removed. `AGENTS_DEFAULT_CONFIG` typed const is a faithful mirror of the old JSON fleet. `loadWebhookConfig` union overload (string | object) and the `runWatchedReposBootMigration` null-path are correct. Dockerfile never had `COPY config/` so no image-layer delta — vacuously satisfies that AC. `docs/configuration.md` rewritten, `CLAUDE.md` + justfile updated, tests aligned. CI green (run #3008).

reviewer merged commit e9d77de83c into main

2026-05-04 01:16:19 +00:00

reviewer referenced this pull request from a commit

2026-05-04 01:16:21 +00:00

DOB-5: rip config/*.json from the repo + Docker build context (#820)