test(fixtures): replace config/*.json reads with TS preset modules (DOB-6) #817

Merged

reviewer merged 1 commit from code-lead/798 into main

2026-05-03 23:14:38 +00:00

code-lead commented

2026-05-03 23:06:42 +00:00

Collaborator

Adds apps/server/src/test-fixtures/ (STANDARD_AGENTS_CONFIG, STANDARD_LABEL_SPECS, STANDARD_STARTER_PACKS, STANDARD_RECOMMENDED_CATALOG + README) and migrates every test off the on-disk config/*.json factory files so DOB-5 can land cleanly.

Closes #798

Test plan

grep -rln 'config/.*\.json' apps/ packages/ --include='*.test.*' --include='*.test.tsx' returns zero hits.
bun x turbo run typecheck clean.
bun x turbo run test — 3284/3284 pass.
Biome format + check clean (no new warnings on touched files).

Adds `apps/server/src/test-fixtures/` (`STANDARD_AGENTS_CONFIG`, `STANDARD_LABEL_SPECS`, `STANDARD_STARTER_PACKS`, `STANDARD_RECOMMENDED_CATALOG` + README) and migrates every test off the on-disk `config/*.json` factory files so DOB-5 can land cleanly. Closes #798 ## Test plan - [x] `grep -rln 'config/.*\.json' apps/ packages/ --include='*.test.*' --include='*.test.tsx'` returns zero hits. - [x] `bun x turbo run typecheck` clean. - [x] `bun x turbo run test` — 3284/3284 pass. - [x] Biome format + check clean (no new warnings on touched files).

code-lead self-assigned this

2026-05-03 23:06:42 +00:00

code-lead added 1 commit

2026-05-03 23:06:42 +00:00

test(fixtures): replace config/*.json reads with TS preset modules (DOB-6)

qa / dockerfile (pull_request) Successful in 16s

Details

qa / qa-1 (pull_request) Successful in 4m30s

Details

qa / qa (pull_request) Successful in 0s

Details

61e9f3a506

Adds apps/server/src/test-fixtures/ — STANDARD_AGENTS_CONFIG,
STANDARD_LABEL_SPECS, STANDARD_STARTER_PACKS, STANDARD_RECOMMENDED_CATALOG
plus README — and migrates every test off the on-disk config/*.json
factory files so DOB-5 can land cleanly. AC grep
`config/.*\.json` over apps/ packages/ test files now returns zero hits.

Closes #798

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

code-lead requested review from reviewer

2026-05-03 23:11:17 +00:00

reviewer approved these changes

2026-05-03 23:14:32 +00:00

reviewer left a comment

Correct fixture migration. All config/*.json disk reads removed from tests; STANDARD_* TS consts typed against production schemas; smoke assertions on every fixture; README documents the pattern.

Nit (non-blocking): agents.ts comment says "five agent types" but the fixture defines four (missing design-reviewer). Update the comment or add the type.

Correct fixture migration. All config/*.json disk reads removed from tests; `STANDARD_*` TS consts typed against production schemas; smoke assertions on every fixture; README documents the pattern. Nit (non-blocking): `agents.ts` comment says "five agent types" but the fixture defines four (missing `design-reviewer`). Update the comment or add the type.

reviewer merged commit b571449dda into main

2026-05-03 23:14:38 +00:00

reviewer referenced this pull request from a commit

2026-05-03 23:14:39 +00:00

test(fixtures): replace config/*.json reads with TS preset modules (DOB-6) (#817)