charles/claude-hooks
1
0
Fork 0
Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

feat(web): SAM-1 — drop Settings from desktop primary nav #809

Merged
dev merged 1 commit from dev/802 into main 2026-05-03 20:19:00 +00:00
Conversation 1 Commits 1 Files changed 3 +208 -1
dev commented 2026-05-03 20:08:21 +00:00
Collaborator
Copy link

Drop /settings from NAV_ITEMS so the desktop top nav renders only Board · Workspace · Agents · Flows. Mobile drawer retains Settings via MOBILE_NAV_ITEMS with the existing nav-drawer-nav-settings test-id.

Test plan

  • Vitest: NAV_ITEMS has 4 entries (no Settings); MOBILE_NAV_ITEMS has 5 (Settings last); desktop nav renders 4 links; mobile drawer exposes nav-drawer-nav-settings.
  • Playwright e2e: desktop viewport asserts nav-settings not attached; mobile opens drawer and asserts nav-drawer-nav-settings visible.

Closes #802.

Drop `/settings` from `NAV_ITEMS` so the desktop top nav renders only Board · Workspace · Agents · Flows. Mobile drawer retains Settings via `MOBILE_NAV_ITEMS` with the existing `nav-drawer-nav-settings` test-id. ## Test plan - Vitest: `NAV_ITEMS` has 4 entries (no Settings); `MOBILE_NAV_ITEMS` has 5 (Settings last); desktop nav renders 4 links; mobile drawer exposes `nav-drawer-nav-settings`. - Playwright e2e: desktop viewport asserts `nav-settings` not attached; mobile opens drawer and asserts `nav-drawer-nav-settings` visible. Closes #802.
dev self-assigned this 2026-05-03 20:08:21 +00:00
feat(web): SAM-1 — drop Settings from desktop primary nav (#802)
All checks were successful
qa / dockerfile (pull_request) Successful in 20s
Details
qa / qa-1 (pull_request) Successful in 4m57s
Details
qa / qa (pull_request) Successful in 0s
Details
ae285736f6 
- Remove /settings from NAV_ITEMS; desktop nav renders Board · Workspace · Agents · Flows only.
- Add MOBILE_NAV_ITEMS = [...NAV_ITEMS, settingsItem] so mobile drawer retains Settings entry with data-testid="nav-drawer-nav-settings".
- Vitest: covers NAV_ITEMS shape, MOBILE_NAV_ITEMS shape, desktop nav (4 links, no Settings), mobile drawer (Settings present).
- Playwright e2e: desktop asserts nav-settings absent; mobile opens drawer and asserts nav-drawer-nav-settings visible.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dev requested review from reviewer 2026-05-03 20:13:23 +00:00
dev force-pushed dev/802 from ae285736f6
All checks were successful
qa / dockerfile (pull_request) Successful in 20s
Details
qa / qa-1 (pull_request) Successful in 4m57s
Details
qa / qa (pull_request) Successful in 0s
Details
to daeb4740ac
All checks were successful
qa / dockerfile (pull_request) Successful in 21s
Details
qa / qa-1 (pull_request) Successful in 3m58s
Details
qa / qa (pull_request) Successful in 0s
Details
2026-05-03 20:14:55 +00:00 Compare
reviewer approved these changes 2026-05-03 20:16:11 +00:00
reviewer left a comment
Copy link

All AC met. NAV_ITEMS drops Settings; MOBILE_NAV_ITEMS re-adds it for the drawer with correct testId and closeMenu; CI green.

All AC met. `NAV_ITEMS` drops Settings; `MOBILE_NAV_ITEMS` re-adds it for the drawer with correct testId and closeMenu; CI green.
dev merged commit 809193c498 into main 2026-05-03 20:19:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
reviewer
Labels
Clear labels   
area:agents
Agent types, pool scheduling, per-instance config

  
area:dashboard
Dashboard UI and observability surfaces

  
area:database
DB layer — schema, migrations, ORM, raw SQL

  
area:design
UI/UX mockup work — routes to designer agent

  
area:design-review
Design review dispatch — routes to design-reviewer agent

  
area:flows
Flow runner — YAML loader, executor, op registry, expression eval

  
area:infra
Deployment, isolation, containers, systemd units

  
area:meta
Tracking, scaffolding, project setup

  
area:security
Security — routes to reviewer-security (opus)

  
area:sessions
Session-id store, Claude SDK resume logic

  
area:webhook
Forgejo webhook routing and handlers

  
area:workdir
Clone cache, worktrees, git identity

  
security
Security-sensitive issue

  
type:bug
Bug

  
type:chore
Chore

  
type:meta
Tracking or decisions, not implementation work

  
type:user-story
User story

No labels
area:agents
area:dashboard
area:database
area:design
area:design-review
area:flows
area:infra
area:meta
area:security
area:sessions
area:webhook
area:workdir
security
type:bug
type:chore
type:meta
type:user-story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dev
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/claude-hooks!809
No description provided.