feat(web): add Settings entry to avatar dropdown #804

Merged

reviewer merged 1 commit from feat/avatar-menu-settings-entry into main

2026-05-03 19:58:05 +00:00

dev commented

2026-05-03 19:51:25 +00:00

Collaborator

Inserts a Settings menu item between the theme section and external links in the avatar dropdown, linking to /settings via TanStack Router Link for client-side routing. Separators above and below give it a distinct visual group.

Test plan

avatar-menu.test.tsx: presence by testId, accessible name, href, click/keyboard default-not-prevented
avatar-menu-settings.spec.ts (Playwright): avatar → Settings → lands on /settings/

Closes #801

Inserts a `Settings` menu item between the theme section and external links in the avatar dropdown, linking to `/settings` via TanStack Router `Link` for client-side routing. Separators above and below give it a distinct visual group. ## Test plan - `avatar-menu.test.tsx`: presence by testId, accessible name, href, click/keyboard default-not-prevented - `avatar-menu-settings.spec.ts` (Playwright): avatar → Settings → lands on `/settings/` Closes #801

dev self-assigned this

2026-05-03 19:51:26 +00:00

dev added 1 commit

2026-05-03 19:51:26 +00:00

feat(web): add Settings entry to avatar dropdown (SAM-2)

qa / dockerfile (pull_request) Successful in 21s

Details

qa / qa-1 (pull_request) Successful in 3m53s

Details

qa / qa (pull_request) Successful in 0s

Details

933597e78f

Insert a Settings menu item between the theme section and external links,
linking to /settings via TanStack Router's Link for client-side routing.
Adds separator above and below for visual grouping. Includes unit tests
and a Playwright happy-path e2e spec.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer

2026-05-03 19:55:22 +00:00

reviewer approved these changes

2026-05-03 19:57:59 +00:00

reviewer left a comment

Correct placement, separators above+below, TanStack Link with to="/settings", size={14} icon, right className, testId. Vitest + Playwright coverage green.

Nit (non-blocking): unit tests assert defaultPrevented===false but not actual navigation; Playwright covers the full path.

Correct placement, separators above+below, TanStack `Link` with `to="/settings"`, `size={14}` icon, right className, testId. Vitest + Playwright coverage green. Nit (non-blocking): unit tests assert `defaultPrevented===false` but not actual navigation; Playwright covers the full path.

reviewer merged commit fc948f565d into main

2026-05-03 19:58:05 +00:00

reviewer referenced this pull request from a commit

2026-05-03 19:58:07 +00:00

feat(web): add Settings entry to avatar dropdown (#804)