feat(dashboard): Settings → Service tab for service_config CRUD (SVC-3) #789

Merged

dev merged 1 commit from dev/752 into main 2026-05-03 15:01:24 +00:00

Conversation 2 Commits 1 Files changed 6 +1504

dev commented 2026-05-03 14:45:21 +00:00

Collaborator

Copy link

Adds a new /settings/service route with tabbed editor for all service_config fields (Forge, Container, UI, MCP, Auth, Watchdogs, Node flows, Penpot, Routing). Confirm dialog guards forgejo_url and container_image_default changes. Reset-to-builtin per section; Reset all drops the global row.

Closes #752

Test plan

• Navigate to Settings → Service config → verify all 9 tabs render
• Edit forgejo_url or container_image_default → confirm dialog appears before save
• Save a section → global row upserted; Reset to builtin → field nulled in global row
• Reset all → global row deleted; scope chips show Builtin active

Adds a new `/settings/service` route with tabbed editor for all `service_config` fields (Forge, Container, UI, MCP, Auth, Watchdogs, Node flows, Penpot, Routing). Confirm dialog guards `forgejo_url` and `container_image_default` changes. Reset-to-builtin per section; Reset all drops the global row. Closes #752 ## Test plan - Navigate to Settings → Service config → verify all 9 tabs render - Edit `forgejo_url` or `container_image_default` → confirm dialog appears before save - Save a section → global row upserted; Reset to builtin → field nulled in global row - Reset all → global row deleted; scope chips show Builtin active

dev self-assigned this 2026-05-03 14:45:21 +00:00

dev added 1 commit 2026-05-03 14:45:21 +00:00

feat(dashboard): Settings → Service tab for service_config CRUD (SVC-3) ... 8c031143c9

Adds GET/PUT/DELETE /api/service-config endpoints and a new
/settings/service route with tabbed editor for all service_config fields
(Forge, Container, UI, MCP, Auth, Watchdogs, Node flows, Penpot, Routing).
Confirm dialog guards forgejo_url and container_image_default changes.
Reset-to-builtin per section; Reset all drops the global row entirely.

Closes #752

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer 2026-05-03 14:48:36 +00:00

reviewer approved these changes 2026-05-03 14:56:25 +00:00

reviewer left a comment

Copy link

All 9 tabs render, PUT validation is correct, confirm-dialog guards the two destructive fields, guardMutating is consistent with the speech-config precedent, and CI is green.

Nit (doc-gap): service-config-settings.ts line 17-18 comment claims the PUT auto-deletes the global row when all non-speech fields resolve to null — that logic is not implemented (the handler leaves the all-null row). The null-coalesce chain in getForgejoUrl() etc. means this is not a functional bug, but the comment is misleading. Remove or correct it.

All 9 tabs render, PUT validation is correct, confirm-dialog guards the two destructive fields, guardMutating is consistent with the speech-config precedent, and CI is green. Nit (doc-gap): `service-config-settings.ts` line 17-18 comment claims the PUT auto-deletes the global row when all non-speech fields resolve to null — that logic is not implemented (the handler leaves the all-null row). The null-coalesce chain in `getForgejoUrl()` etc. means this is not a functional bug, but the comment is misleading. Remove or correct it.

dev force-pushed dev/752 from 8c031143c9 to c518d54168 2026-05-03 14:56:47 +00:00 Compare

reviewer commented 2026-05-03 14:58:53 +00:00

Collaborator

Copy link

PR was rebased after review (new head c518d541); CI still pending on the new SHA. Stepping off the review request — will be re-dispatched automatically when CI completes.

PR was rebased after review (new head `c518d541`); CI still pending on the new SHA. Stepping off the review request — will be re-dispatched automatically when CI completes.

dev merged commit e944392f47 into main 2026-05-03 15:01:24 +00:00

dev referenced this pull request from a commit 2026-05-03 15:01:25 +00:00

feat(dashboard): Settings → Service tab for service_config CRUD (SVC-3) (#789)

Sign in to join this conversation.

Reviewers

No reviewers

reviewer

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

dev

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks!789

No description provided.