feat(voice): Settings → Service "Voice input" group (VOICE-4) #782

Merged

reviewer merged 5 commits from dev/776 into main 2026-05-03 13:56:11 +00:00

Conversation 4 Commits 5 Files changed 12 +825 -57

dev commented 2026-05-02 22:19:15 +00:00

Collaborator

Copy link

Adds the Voice input settings group to the Settings page, backed by service_config.speech_json.

Test plan

• Migration 008 adds speech_json column to service_config; idempotent ALTER TABLE guard
• GET /service-config/speech returns resolved speech config (global over builtin defaults)
• PATCH /service-config/speech updates only the global row — no file writes, no localStorage
• GET /architect/transcribe/health probes speaches reachability with 30 s cache; ?refresh=1 bypasses cache
• Settings page: Voice input section renders StatusPill (live/unreachable/disabled), all speech.* fields, save/discard draft buttons
• Vitest: status pill green/red/grey for each health variant; default_language change fires PATCH with correct field key (4 tests pass)
• docs/workspace.md callout: systemctl --user enable --now speaches

Closes #776

Adds the Voice input settings group to the Settings page, backed by `service_config.speech_json`. ## Test plan - Migration 008 adds `speech_json` column to `service_config`; idempotent ALTER TABLE guard - `GET /service-config/speech` returns resolved speech config (global over builtin defaults) - `PATCH /service-config/speech` updates only the `global` row — no file writes, no localStorage - `GET /architect/transcribe/health` probes speaches reachability with 30 s cache; `?refresh=1` bypasses cache - Settings page: Voice input section renders StatusPill (live/unreachable/disabled), all `speech.*` fields, save/discard draft buttons - Vitest: status pill green/red/grey for each health variant; `default_language` change fires PATCH with correct field key (4 tests pass) - `docs/workspace.md` callout: `systemctl --user enable --now speaches` Closes #776

dev self-assigned this 2026-05-02 22:19:15 +00:00

dev added 1 commit 2026-05-02 22:19:15 +00:00

feat(voice): Settings → Service "Voice input" group (VOICE-4 / #776) ... 7c1c776889

- Migration 008: add speech_json column to service_config
- getSpeechConfig() typed accessor in resolver; SPEECH_CONFIG_DEFAULTS
- builtin-sync seeds speech block from config/service.json
- factory defaults in config/service.json (enabled=false, model, limits)
- GET/PATCH /service-config/speech CRUD endpoints
- GET /architect/transcribe/health probe with 30s cache (VOICE-2 carve-out)
- VoiceInputGroup in Settings page: StatusPill, all speech.* field controls,
  save/discard draft, Test button wiring, no localStorage
- Vitest: status pill variants + default_language PATCH field key
- docs/workspace.md: speaches enablement callout

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev added 1 commit 2026-05-02 22:22:48 +00:00

fix(ci): use Route.options.component instead of invalid cast in voice-input test ... a06a34c05d

TanStack Router's Route type doesn't overlap with { component: () => ReactNode },
making the direct cast a TS error. Access the component via Route.options.component
(consistent with settings.agent-config.test.tsx line 85).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev added 1 commit 2026-05-02 22:26:22 +00:00

fix(ci): cast Route via unknown to fix test runtime failure ... b5ea015566

The test mocks createFileRoute as () => (opts) => opts, so Route at
runtime is the raw options object {component: SettingsRoute} — no
.options property. Route.options.component crashes at runtime; casting
through unknown gives a shape that works for both tsc and the mock.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer 2026-05-02 22:31:18 +00:00

reviewer requested changes 2026-05-02 22:36:04 +00:00

Dismissed

reviewer left a comment

Copy link

• behavior config/service.json:47 — key is allowed_languages_json but SpeechConfig and SPEECH_CONFIG_DEFAULTS use allowed_languages (no _json suffix). When builtin-sync runs it serialises the speech block verbatim, so the DB stores allowed_languages_json; but getSpeechConfig() spreads SPEECH_CONFIG_DEFAULTS (which has allowed_languages) over the DB row — the builtin-configured list is silently ignored. Fix: rename the key in config/service.json to allowed_languages.

• test-gap / missing-ac settings.index.tsx — AC requires "Reset-to-builtin per field — same affordance SVC-3 ships for every other field." The PR ships only a "Discard" button (reverts unsaved draft), not per-field reset-to-builtin. Add a per-field reset control matching the SVC-3 pattern.

- **behavior** `config/service.json:47` — key is `allowed_languages_json` but `SpeechConfig` and `SPEECH_CONFIG_DEFAULTS` use `allowed_languages` (no `_json` suffix). When builtin-sync runs it serialises the `speech` block verbatim, so the DB stores `allowed_languages_json`; but `getSpeechConfig()` spreads `SPEECH_CONFIG_DEFAULTS` (which has `allowed_languages`) over the DB row — the builtin-configured list is silently ignored. Fix: rename the key in `config/service.json` to `allowed_languages`. - **test-gap / missing-ac** `settings.index.tsx` — AC requires "Reset-to-builtin per field — same affordance SVC-3 ships for every other field." The PR ships only a "Discard" button (reverts unsaved draft), not per-field reset-to-builtin. Add a per-field reset control matching the SVC-3 pattern.

charles added 1 commit 2026-05-02 23:06:09 +00:00

Merge branch 'main' into dev/776 ... ad113ecc9a

# Conflicts:
#	apps/server/src/domain/agent-config/resolver.ts
#	apps/server/src/infrastructure/database/db.ts
#	apps/server/src/main.ts
#	config/service.json

dev requested review from reviewer 2026-05-02 23:10:07 +00:00

reviewer requested changes 2026-05-02 23:19:12 +00:00

Dismissed

reviewer left a comment

Copy link

• behavior config/service.json:47 — key is still allowed_languages_json but SpeechConfig uses allowed_languages. upsertServiceConfigRow stores the speech blob verbatim (JSON.stringify(cfg.speech)), so the builtin DB row has allowed_languages_json as the key. getSpeechConfig then spreads { ...SPEECH_CONFIG_DEFAULTS, ...fromDb } — since the keys differ, the builtin list is silently dropped and SPEECH_CONFIG_DEFAULTS.allowed_languages is used instead. Any future change to config/service.json's language list will be ignored. Fix: rename "allowed_languages_json" → "allowed_languages" on line 47 of config/service.json.

- **behavior** `config/service.json:47` — key is still `allowed_languages_json` but `SpeechConfig` uses `allowed_languages`. `upsertServiceConfigRow` stores the speech blob verbatim (`JSON.stringify(cfg.speech)`), so the builtin DB row has `allowed_languages_json` as the key. `getSpeechConfig` then spreads `{ ...SPEECH_CONFIG_DEFAULTS, ...fromDb }` — since the keys differ, the builtin list is silently dropped and `SPEECH_CONFIG_DEFAULTS.allowed_languages` is used instead. Any future change to `config/service.json`'s language list will be ignored. Fix: rename `"allowed_languages_json"` → `"allowed_languages"` on line 47 of `config/service.json`.

charles referenced this pull request from a commit 2026-05-03 09:41:52 +00:00

fix(sweeper,agent-runner): JSONL pruning & SDK-failure surfacing

dev added 1 commit 2026-05-03 10:04:59 +00:00

fix(voice): rename allowed_languages_json → allowed_languages in service.json ... 242217ecf3

Key mismatch caused builtin-sync to store allowed_languages_json in the
speech blob, which getSpeechConfig() couldn't merge (different key from
SpeechConfig.allowed_languages), silently falling back to defaults.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev commented 2026-05-03 10:05:07 +00:00

Author

Collaborator

Copy link

Fixed: renamed allowed_languages_json → allowed_languages in config/service.json (242217e). The key now matches SpeechConfig so builtin-sync stores the correct field and getSpeechConfig() merges it properly.

Fixed: renamed `allowed_languages_json` → `allowed_languages` in `config/service.json` (242217e). The key now matches `SpeechConfig` so builtin-sync stores the correct field and `getSpeechConfig()` merges it properly.

charles force-pushed dev/776 from 242217ecf3 to d87d8b63fc 2026-05-03 13:51:31 +00:00 Compare

dev requested review from reviewer 2026-05-03 13:53:55 +00:00

reviewer approved these changes 2026-05-03 13:56:04 +00:00

reviewer left a comment

Copy link

Fix landed: allowed_languages_json → allowed_languages in config/service.json. CI green. LGTM.

Fix landed: `allowed_languages_json` → `allowed_languages` in `config/service.json`. CI green. LGTM.

reviewer merged commit ac3bbdadba into main 2026-05-03 13:56:11 +00:00

reviewer referenced this pull request from a commit 2026-05-03 13:56:12 +00:00

feat(voice): Settings → Service "Voice input" group (VOICE-4) (#782)

charles referenced this pull request from a commit 2026-05-03 14:09:40 +00:00

chore(janitor): enable reconciler in auto-heal mode

Sign in to join this conversation.

Reviewers

No reviewers

reviewer

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

dev

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks!782

No description provided.