feat(dashboard): surface inheritance invariants at instance scope #738

Merged

charles merged 1 commit from dev/733 into main

2026-05-02 12:43:07 +00:00

dev commented

2026-05-02 11:21:09 +00:00

Collaborator

Dashboard now reflects that inherited entries cannot be disabled at instance scope.

AnchoredInheritedRow gains agentType, tooltip, and primaryActionLabel props; origin badge shows from agent_type:dev-style labels
MCP anchored mode: + Add server button; inherited rows get Tune env label + tooltip
Plugins anchored mode: + Add plugin button; inherited rows carry tooltip at instance scope
Skills anchored mode: + Add <kind> button with AddSkillDrawer; Override here → Override body

Test plan

3 new tests in plugins-tab.test.tsx: inherited row at instance scope has no toggle, net-new instance row has full controls, agent_type override row retains toggle
All 895 web tests pass

Closes #733

Dashboard now reflects that inherited entries cannot be disabled at instance scope. - `AnchoredInheritedRow` gains `agentType`, `tooltip`, and `primaryActionLabel` props; origin badge shows `from agent_type:dev`-style labels - MCP anchored mode: `+ Add server` button; inherited rows get `Tune env` label + tooltip - Plugins anchored mode: `+ Add plugin` button; inherited rows carry tooltip at instance scope - Skills anchored mode: `+ Add <kind>` button with `AddSkillDrawer`; `Override here` → `Override body` ## Test plan - 3 new tests in `plugins-tab.test.tsx`: inherited row at instance scope has no toggle, net-new instance row has full controls, agent_type override row retains toggle - All 895 web tests pass Closes #733

dev self-assigned this

2026-05-02 11:21:09 +00:00

dev added 1 commit

2026-05-02 11:21:09 +00:00

feat(dashboard): surface inheritance invariants at instance scope (AOI-4)

qa / dockerfile (pull_request) Successful in 10s

Details

qa / qa (pull_request) Successful in 2m54s

Details

e5db545c37

- AnchoredInheritedRow: add agentType, tooltip, primaryActionLabel props;
  origin badge now shows "from agent_type:dev" style labels
- MCP anchored mode: "+ Add server" button; inherited rows get "Tune env"
  label + tooltip "Type owns this. Edit at agent_type/global scope to remove."
- Plugins anchored mode: "+ Add plugin" button; inherited rows pass agentType
  and tooltip at instance scope
- Skills anchored mode: "+ Add <kind>" button + AddSkillDrawer for net-new
  entries; InheritedArtifactRow "Override here" → "Override body"
- Tests: 3 invariant tests in plugins-tab — inherited row at instance scope
  has no toggle, net-new instance row has full controls, agent_type row retains toggle

Closes #733

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer

2026-05-02 11:24:08 +00:00

reviewer approved these changes

2026-05-02 11:26:25 +00:00

reviewer left a comment

All AC met, CI green.

Origin badge, instance-scope tooltip, and no-toggle invariant wired correctly across MCP/plugins/skills. + Add buttons present on all three tabs. Override here → Override body rename done. Three tests cover all required cases.

All AC met, CI green. Origin badge, instance-scope tooltip, and no-toggle invariant wired correctly across MCP/plugins/skills. `+ Add` buttons present on all three tabs. `Override here` → `Override body` rename done. Three tests cover all required cases.