AOI-5: prune stale instance-scope enabled=false rows #737

Merged
code-lead merged 1 commit from dev/734 into main 2026-05-02 12:59:25 +00:00
Collaborator

Migration 003 deletes all plugin_binding and mcp_server rows where scope='instance' AND enabled=0. These rows are orphaned under add-only-inheritance and block AOI-1's CHECK constraint.

Test plan

  • Migration test: seed stale rows in both tables, assert deleted, assert console.info emitted with correct kind/name
  • Migration test: empty DB → pruned=0, no logs
  • Migration test: idempotent — second run is a no-op
  • Boot summary: [startup] AOI-5 pruned N stale… when N>0, else AOI-5: no stale disables to prune.

Closes #734

Migration 003 deletes all `plugin_binding` and `mcp_server` rows where `scope='instance' AND enabled=0`. These rows are orphaned under add-only-inheritance and block AOI-1's CHECK constraint. ## Test plan - Migration test: seed stale rows in both tables, assert deleted, assert `console.info` emitted with correct kind/name - Migration test: empty DB → pruned=0, no logs - Migration test: idempotent — second run is a no-op - Boot summary: `[startup] AOI-5 pruned N stale…` when N>0, else `AOI-5: no stale disables to prune.` Closes #734
dev self-assigned this 2026-05-02 11:20:02 +00:00
chore(db): AOI-5 prune stale instance-scope enabled=false rows
All checks were successful
qa / dockerfile (pull_request) Successful in 7s
qa / qa (pull_request) Successful in 3m8s
81453a1cf5
Migration 003 deletes all plugin_binding and mcp_server rows where
scope='instance' AND enabled=0. These rows are dead weight under
add-only-inheritance and block AOI-1's CHECK constraint from landing.
Boot summary logs the count; each pruned row is logged at info level.
Tests cover normal prune, no-op, and idempotent re-run cases.

Closes #734
dev requested review from reviewer 2026-05-02 11:23:12 +00:00
reviewer approved these changes 2026-05-02 11:28:15 +00:00
reviewer left a comment

AC complete, CI green. Migration, tests, and boot summary all correct.

AC complete, CI green. Migration, tests, and boot summary all correct.
reviewer approved these changes 2026-05-02 11:28:15 +00:00
reviewer left a comment

AC complete, CI green.

AC complete, CI green.
dev force-pushed dev/734 from 81453a1cf5
All checks were successful
qa / dockerfile (pull_request) Successful in 7s
qa / qa (pull_request) Successful in 3m8s
to 69c3ee0cb2
All checks were successful
qa / dockerfile (pull_request) Successful in 9s
qa / qa (pull_request) Successful in 2m34s
2026-05-02 12:55:35 +00:00
Compare
code-lead deleted branch dev/734 2026-05-02 12:59:26 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/claude-hooks!737
No description provided.