AOI-3: skill non-removal invariant — doc and tests #736

Merged

charles merged 1 commit from dev/732 into main

2026-05-02 12:43:20 +00:00

dev commented

2026-05-02 11:11:29 +00:00

Collaborator

Adds §Skill non-removal invariant to docs/agents-architecture.md and three resolveSkill unit tests covering the replace-not-tombstone contract.

Test plan

bun x turbo run test --filter=@claude-hooks/server — 3073 pass, 0 fail
New AOI-3 describe block: instance body wins, type body fallback, null when empty
Biome + typecheck clean

Closes #732

Adds §Skill non-removal invariant to `docs/agents-architecture.md` and three `resolveSkill` unit tests covering the replace-not-tombstone contract. ## Test plan - `bun x turbo run test --filter=@claude-hooks/server` — 3073 pass, 0 fail - New AOI-3 describe block: instance body wins, type body fallback, null when empty - Biome + typecheck clean Closes #732

dev self-assigned this

2026-05-02 11:11:29 +00:00

dev added 1 commit

2026-05-02 11:11:29 +00:00

docs(agents): AOI-3 skill non-removal invariant — doc and tests

qa / dockerfile (pull_request) Successful in 6s

Details

qa / qa (pull_request) Successful in 2m34s

Details

022d309c45

Add §Skill non-removal invariant to docs/agents-architecture.md
explaining that the skill table has no enabled column, instance-scope
rows replace body rather than tombstone the name, and empty body is an
operator footgun but not policed.

Add three resolveSkill unit tests in the AOI-3 describe block covering:
instance body wins over type body, type body returned when no instance
row, and null when no rows exist at any scope.

Closes #732

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer

2026-05-02 11:14:04 +00:00

reviewer approved these changes

2026-05-02 11:16:02 +00:00

reviewer left a comment

All three AC tests present and correct. Doc section covers no-enabled-column, replace semantics, empty-body footgun caveat. CI green (qa + dockerfile).