charles/claude-hooks

Fork 0

WIZ-4 agent types screen — rename + pool sizing + drop-design toggle #697

Merged

code-lead merged 2 commits from dev/675 into main

2026-05-01 23:23:43 +00:00

dev commented

2026-05-01 22:12:53 +00:00

Collaborator

Implements the TypesStep for the /onboarding wizard (WIZ-4).

Test plan

6 rows pre-filled with default names; each row has role chip, name input, pool-size select (1/2/4), help tooltip
Reserved-name validation (host, code-lead, code, review, design, design-review) shows inline error and disables Continue; exception when value equals the row own default
"I don't need design agents" toggle hides designer + design-reviewer rows
State PATCHed to /onboarding/state with agent_type_renames + pool_sizes on Continue from step 3
18 new tests — all 734 web tests pass, Biome clean, typecheck clean

Closes #675

Implements the `TypesStep` for the `/onboarding` wizard (WIZ-4). ## Test plan - 6 rows pre-filled with default names; each row has role chip, name input, pool-size select (1/2/4), help tooltip - Reserved-name validation (host, code-lead, code, review, design, design-review) shows inline error and disables Continue; exception when value equals the row own default - "I don't need design agents" toggle hides designer + design-reviewer rows - State PATCHed to `/onboarding/state` with `agent_type_renames` + `pool_sizes` on Continue from step 3 - 18 new tests — all 734 web tests pass, Biome clean, typecheck clean Closes #675

dev self-assigned this

2026-05-01 22:12:53 +00:00

dev added 1 commit

2026-05-01 22:12:53 +00:00

feat(web): WIZ-4 agent types screen — rename + pool sizing + drop-design toggle

qa / dockerfile (pull_request) Successful in 5s

Details

qa / qa (pull_request) Successful in 2m45s

Details

e7594a84d2

Implements the TypesStep component for the /onboarding wizard:
- 6 rows pre-filled with post-prereq-A default names (architect,
  code-lead, dev, reviewer, designer, design-reviewer)
- Each row: read-only role chip, editable name input, pool-size
  select (1/2/4), help tooltip button
- Reserved-name validation (host, code-lead, code, review, design,
  design-review) — inline error + Continue disabled; exception when
  the value equals the row's own default name
- "I don't need design agents" toggle hides designer + design-reviewer
- State PATCHed to /onboarding/state (agent_type_renames + pool_sizes)
  when Continue is pressed from step 3
- 18 new tests covering all 4 AC groups

Closes #675

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer

2026-05-01 22:15:40 +00:00

reviewer requested changes

2026-05-01 22:18:56 +00:00

Dismissed

reviewer left a comment

behavior: onboarding.tsx errors loop (for (const { defaultName } of DEFAULT_AGENT_TYPES)) iterates all 6 types regardless of dropDesign. If a user edits a design row to a reserved/empty name and then checks the drop-design toggle, the hidden rows still contribute validation errors and Continue stays disabled with no visible error to explain why. Fix: change the loop to iterate visibleTypes instead of DEFAULT_AGENT_TYPES.

- **behavior**: `onboarding.tsx` errors loop (`for (const { defaultName } of DEFAULT_AGENT_TYPES)`) iterates all 6 types regardless of `dropDesign`. If a user edits a design row to a reserved/empty name and then checks the drop-design toggle, the hidden rows still contribute validation errors and Continue stays disabled with no visible error to explain why. Fix: change the loop to iterate `visibleTypes` instead of `DEFAULT_AGENT_TYPES`.

dev added 1 commit

2026-05-01 22:20:56 +00:00

fix(web): WIZ-4 errors loop must skip hidden design rows

qa / dockerfile (pull_request) Successful in 4s

Details

qa / qa (pull_request) Successful in 2m53s

Details

79a6fb30db

Iterate `visibleTypes` instead of `DEFAULT_AGENT_TYPES` so that design-row
validation errors don't block Continue when the drop-design toggle is checked.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev commented

2026-05-01 22:21:26 +00:00

Author

Collaborator

Fixed in 79a6fb3. Moved visibleTypes derivation before the errors loop and changed the loop to iterate visibleTypes instead of DEFAULT_AGENT_TYPES. Hidden design rows no longer contribute validation errors when the drop-design toggle is checked.

Fixed in 79a6fb3. Moved `visibleTypes` derivation before the errors loop and changed the loop to iterate `visibleTypes` instead of `DEFAULT_AGENT_TYPES`. Hidden design rows no longer contribute validation errors when the drop-design toggle is checked.

dev requested review from reviewer

2026-05-01 22:23:50 +00:00

reviewer approved these changes

2026-05-01 22:25:50 +00:00

reviewer left a comment

Fix confirmed: errors loop now iterates visibleTypes, hidden design rows no longer block Continue. CI green.

Fix confirmed: errors loop now iterates `visibleTypes`, hidden design rows no longer block Continue. CI green.

dev force-pushed dev/675 from 79a6fb30db

qa / dockerfile (pull_request) Successful in 4s

Details

qa / qa (pull_request) Successful in 2m53s

Details