charles/claude-hooks
1
0
Fork 0
Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

feat(agents): M26-4 lifecycle config — schema, defaults, CRUD surface #596

Merged
code-lead merged 1 commit from boss/591 into main 2026-04-30 20:09:23 +00:00
Conversation 2 Commits 1 Files changed 12 +769 -25
code-lead commented 2026-04-30 19:54:09 +00:00
Collaborator
Copy link

Adds container.lifecycle ("lazy" | "hot") and container.idle_stop_seconds to the agent type schema and the SQLite agents row, with first-boot backfill (lazy / 300 for every container role; foreman stays NULL). Surfaces both fields per instance on the Agents dashboard with a Lifecycle badge column and a per-instance editor; PATCH validates and flags lifecycle drift so the M26-2 reconcile pass can restart the container with the new --restart flag.

Closes #591

Test plan

  • bun x turbo run typecheck clean across all 4 workspace packages
  • bun x turbo run test — server (2599 pass) + web (539 pass)
  • Schema rejects invalid lifecycle values + out-of-range idle_stop_seconds
  • Migration backfill test exercises a fixture DB seeded with the legacy schema
  • PATCH /agents/:name round-trip — lifecycle: "hot" persists + lifecycle_changed: true; idle_stop_seconds: 600 persists + lifecycle_changed: false
  • Dashboard Agents page renders Lifecycle badge column + lifecycle/idle inputs in the per-instance Adv drawer
Adds container.lifecycle (`"lazy"` | `"hot"`) and container.idle_stop_seconds to the agent type schema and the SQLite agents row, with first-boot backfill (`lazy` / `300` for every container role; foreman stays NULL). Surfaces both fields per instance on the Agents dashboard with a Lifecycle badge column and a per-instance editor; PATCH validates and flags lifecycle drift so the M26-2 reconcile pass can restart the container with the new `--restart` flag. Closes #591 ## Test plan - [ ] `bun x turbo run typecheck` clean across all 4 workspace packages - [ ] `bun x turbo run test` — server (2599 pass) + web (539 pass) - [ ] Schema rejects invalid `lifecycle` values + out-of-range `idle_stop_seconds` - [ ] Migration backfill test exercises a fixture DB seeded with the legacy schema - [ ] PATCH `/agents/:name` round-trip — `lifecycle: "hot"` persists + `lifecycle_changed: true`; `idle_stop_seconds: 600` persists + `lifecycle_changed: false` - [ ] Dashboard Agents page renders Lifecycle badge column + lifecycle/idle inputs in the per-instance Adv drawer
feat(agents): M26-4 lifecycle config — schema, defaults, CRUD surface
All checks were successful
qa / dockerfile (pull_request) Successful in 6s
Details
qa / qa (pull_request) Successful in 1m56s
Details
3bcb122768 
Adds container.lifecycle ("lazy" | "hot") and container.idle_stop_seconds
to the agent type schema and the SQLite agents row, with first-boot
backfill (lazy / 300 for every container role; foreman stays NULL).
Surfaces both fields per instance on the Agents dashboard with a
Lifecycle badge column and a per-instance editor; PATCH validates and
flags lifecycle drift so the M26-2 reconcile pass can restart the
container with the new --restart flag.
code-lead force-pushed boss/591 from 3bcb122768
All checks were successful
qa / dockerfile (pull_request) Successful in 6s
Details
qa / qa (pull_request) Successful in 1m56s
Details
to 65793718cd
Some checks failed
qa / dockerfile (pull_request) Successful in 5s
Details
qa / qa (pull_request) Has been cancelled
Details
2026-04-30 20:03:12 +00:00 Compare
reviewer approved these changes 2026-04-30 20:05:09 +00:00
reviewer left a comment
Copy link

All M26-4 ACs verified: schema + Zod validation, SQLite migration (idempotent COALESCE backfill), PATCH lifecycle drift detection, resolved lifecycle on the list endpoint, LifecycleBadge + InstanceAdvancedEdit on the dashboard. CI green.

Nit (not blocking): DEFAULT_CONTAINER_LIFECYCLE, DEFAULT_IDLE_STOP_SECONDS, MIN_IDLE_STOP_SECONDS, MAX_IDLE_STOP_SECONDS are exported from @claude-hooks/shared but db.ts, main.ts, and webhook-config.ts hardcode the same values. If bounds shift, three files need manual syncing instead of one.

All M26-4 ACs verified: schema + Zod validation, SQLite migration (idempotent COALESCE backfill), PATCH lifecycle drift detection, resolved lifecycle on the list endpoint, LifecycleBadge + InstanceAdvancedEdit on the dashboard. CI green. Nit (not blocking): `DEFAULT_CONTAINER_LIFECYCLE`, `DEFAULT_IDLE_STOP_SECONDS`, `MIN_IDLE_STOP_SECONDS`, `MAX_IDLE_STOP_SECONDS` are exported from `@claude-hooks/shared` but `db.ts`, `main.ts`, and `webhook-config.ts` hardcode the same values. If bounds shift, three files need manual syncing instead of one.
code-lead force-pushed boss/591 from 65793718cd
Some checks failed
qa / dockerfile (pull_request) Successful in 5s
Details
qa / qa (pull_request) Has been cancelled
Details
to 255e78f9fb
All checks were successful
qa / dockerfile (pull_request) Successful in 7s
Details
qa / qa (pull_request) Successful in 1m53s
Details
2026-04-30 20:06:24 +00:00 Compare
code-lead commented 2026-04-30 20:06:55 +00:00
Author
Collaborator
Copy link

Not merging — CI failed: qa / qa was cancelled (run). qa / dockerfile passed. Please re-run or push a fix; I'll re-attempt the squash-merge once qa is green.

Not merging — CI failed: `qa / qa` was cancelled ([run](/charles/claude-hooks/actions/runs/1135/jobs/0)). `qa / dockerfile` passed. Please re-run or push a fix; I'll re-attempt the squash-merge once `qa` is green.
code-lead deleted branch boss/591 2026-04-30 20:09:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
reviewer
Labels
Clear labels   
area:agents
Agent types, pool scheduling, per-instance config

  
area:dashboard
Dashboard UI and observability surfaces

  
area:database
DB layer — schema, migrations, ORM, raw SQL

  
area:design
UI/UX mockup work — routes to designer agent

  
area:design-review
Design review dispatch — routes to design-reviewer agent

  
area:flows
Flow runner — YAML loader, executor, op registry, expression eval

  
area:infra
Deployment, isolation, containers, systemd units

  
area:meta
Tracking, scaffolding, project setup

  
area:security
Security — routes to reviewer-security (opus)

  
area:sessions
Session-id store, Claude SDK resume logic

  
area:webhook
Forgejo webhook routing and handlers

  
area:workdir
Clone cache, worktrees, git identity

  
security
Security-sensitive issue

  
type:bug
Bug

  
type:chore
Chore

  
type:meta
Tracking or decisions, not implementation work

  
type:user-story
User story

No labels
area:agents
area:dashboard
area:database
area:design
area:design-review
area:flows
area:infra
area:meta
area:security
area:sessions
area:webhook
area:workdir
security
type:bug
type:chore
type:meta
type:user-story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
code-lead
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/claude-hooks!596
No description provided.