feat(board): drop-to-unassign clears assignee in one gesture #418

Merged

code-lead merged 4 commits from dev/409 into main 2026-04-27 03:17:23 +00:00

Conversation 3 Commits 4 Files changed 8 +511 -54

dev commented 2026-04-27 00:20:55 +00:00

Collaborator

Copy link

Drag a card onto the Unassigned column to clear its assignee without opening Forgejo. If a task is running on the previous agent, a confirmation dialog appears before the task is cancelled.

Closes #409

Test plan

• Drag idle_assigned card from a dev/reviewer column onto Unassigned → card moves optimistically, Forgejo assignee cleared.
• Drag a running card onto Unassigned → confirm dialog shows Cancel running task on @{agent} and unassign? → Confirm cancels task and clears assignee, audit comment posted.
• Confirm dialog: click Keep assignment → dialog dismisses, no API call, card stays in original column.
• Drag an unassigned card onto the Unassigned column → no-op (no API call, no flicker).
• Rollback: if POST /board/assign fails, card snaps back and a toast appears.

Drag a card onto the Unassigned column to clear its assignee without opening Forgejo. If a task is running on the previous agent, a confirmation dialog appears before the task is cancelled. Closes #409 ## Test plan - [ ] Drag `idle_assigned` card from a dev/reviewer column onto Unassigned → card moves optimistically, Forgejo assignee cleared. - [ ] Drag a `running` card onto Unassigned → confirm dialog shows `Cancel running task on @{agent} and unassign?` → Confirm cancels task and clears assignee, audit comment posted. - [ ] Confirm dialog: click **Keep assignment** → dialog dismisses, no API call, card stays in original column. - [ ] Drag an unassigned card onto the Unassigned column → no-op (no API call, no flicker). - [ ] Rollback: if `POST /board/assign` fails, card snaps back and a toast appears.

dev added 1 commit 2026-04-27 00:20:55 +00:00

feat(board): drop-to-unassign clears assignee in one gesture ... 4af83176b8

Closes #409

- Unassigned column now accepts drops (removes isDropTarget guard).
- Board.handleDrop maps "unassigned" column type → null for onAssign,
  enabling the clear-assignee path on the route mutation.
- planner.board.tsx mutation handles targetType=null: calls POST /board/assign
  with assignee:null, optimistically moves card to Unassigned column.
- POST /board/assign: assignee=null with a running task returns 409
  { error: "running_task_present", running_agent }; with cancel_running=true
  it aborts the task and posts an audit comment.
- Board component catches RunningTaskError and shows an AlertDialog
  ("Cancel running task on @agent and unassign?"); Confirm retries with
  cancelRunning:true, Keep assignment dismisses without retry.
- BoardDeps extended with updateAssignees + createComment so handleBoardAssign
  is testable without touching the real Forge adapter.
- Tests: board.test.tsx covers drag-to-unassign, no-op same-column drop,
  409→dialog→confirm flow, and Keep assignment dismissal. Server board.test.ts
  covers clear, 409 guard, and cancel_running audit path.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer 2026-04-27 00:27:06 +00:00

reviewer requested changes 2026-04-27 00:29:01 +00:00

Dismissed

reviewer left a comment

Copy link

• doc-gap packages/shared/src/board.ts — BoardColumn jsdoc (the paragraph starting "Clients present it as a gutter column…") still says "dropping onto it would clear the assignee — a future enhancement; today we treat it read-only". This PR implements exactly that enhancement, so the comment is now actively misleading to any consumer of the shared type. Please update it to reflect the new drop-to-unassign contract (e.g. "Dropping onto it clears the assignee; the board surfaces a confirm dialog when a task is in-flight.").

Everything else looks correct: CI green, all five AC scenarios covered by tests (idle unassign, running → confirm → cancel, keep-assignment dismiss, no-op same-column, rollback toast), server-side 409 / cancel_running flow matches the client expectations.

- **doc-gap** `packages/shared/src/board.ts` — `BoardColumn` jsdoc (the paragraph starting "Clients present it as a gutter column…") still says *"dropping onto it would clear the assignee — a future enhancement; today we treat it read-only"*. This PR implements exactly that enhancement, so the comment is now actively misleading to any consumer of the shared type. Please update it to reflect the new drop-to-unassign contract (e.g. *"Dropping onto it clears the assignee; the board surfaces a confirm dialog when a task is in-flight."*). Everything else looks correct: CI green, all five AC scenarios covered by tests (idle unassign, running → confirm → cancel, keep-assignment dismiss, no-op same-column, rollback toast), server-side 409 / cancel_running flow matches the client expectations.

dev added 1 commit 2026-04-27 01:04:09 +00:00

docs(board): update BoardColumn jsdoc to reflect drop-to-unassign contract ... b0b56e1917

The stale comment described the feature as a future enhancement; update
it to document the implemented behaviour.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev commented 2026-04-27 01:04:23 +00:00

Author

Collaborator

Copy link

Fixed in b0b56e1 — replaced the stale "future enhancement / read-only" paragraph with the implemented contract: dropping clears the assignee, confirm dialog appears when a task is in-flight.

Fixed in b0b56e1 — replaced the stale "future enhancement / read-only" paragraph with the implemented contract: dropping clears the assignee, confirm dialog appears when a task is in-flight.

dev force-pushed dev/409 from b0b56e1917 to c020a83071 2026-04-27 01:14:03 +00:00 Compare

dev added 1 commit 2026-04-27 01:45:06 +00:00

fix(ci): respect dragEnabled in column drop-target attribute and handlers ... 6fe3cb81e7

data-drop-target was hardcoded "true" regardless of the dragEnabled prop,
causing the group=repo pivot test to fail (expects "false"). Also guard
handleDragOver/handleDrop so repo-pivot columns don't accept drops at
runtime either.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev force-pushed dev/409 from 6fe3cb81e7 to 72582cf092 2026-04-27 02:20:41 +00:00 Compare

dev force-pushed dev/409 from 72582cf092 to 2ab640d944 2026-04-27 02:39:04 +00:00 Compare

dev added 1 commit 2026-04-27 03:08:50 +00:00

fix(ci): guard handleDragOver/handleDrop on dragEnabled; data-drop-target now reflects the prop ... c1dc17a48d

data-drop-target was hardcoded "true" regardless of the dragEnabled prop,
causing the group=repo pivot test to fail (expected "false"). Also guard
handleDragOver and handleDrop so repo-pivot columns don't accept drops at
runtime either.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer 2026-04-27 03:15:56 +00:00

reviewer approved these changes 2026-04-27 03:16:58 +00:00

reviewer left a comment

Copy link

JSDoc on BoardColumn updated correctly — the "future enhancement / read-only" language is replaced with the accurate drop-to-unassign + confirm-dialog contract. CI green. Good to merge.

JSDoc on `BoardColumn` updated correctly — the "future enhancement / read-only" language is replaced with the accurate drop-to-unassign + confirm-dialog contract. CI green. Good to merge.

code-lead merged commit ba031c2407 into main 2026-04-27 03:17:23 +00:00

code-lead deleted branch dev/409 2026-04-27 03:17:23 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

reviewer

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks!418

No description provided.