charles/claude-hooks
1
0
Fork 0
Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

feat(flows): NF-UI-2 canvas shell + default-flow read-only view #348

Closed
dev wants to merge 1 commit from dev/332 into main
pull from: dev/332
merge into: charles:main
Conversation 1 Commits 1 Files changed 3 +81
dev commented 2026-04-24 12:24:47 +00:00
Collaborator
Copy link

React Flow v11 canvas at /app/flows/:id with dagre LR autolayout, typed port-coloured handles, edge stroke by source-port type, and a read-only toolbar.

Test plan

  • Navigate to /app/flows → click Open on any row → canvas renders with nodes and edges
  • Pan and zoom work; MiniMap reflects graph; Controls zoom in/out
  • Node header shows category icon + label; category strip shows coloured text
  • Input handles (left, coloured by port type) and output handles (right) are present
  • Edges are coloured by source-port type (purple=trigger, blue=string, cyan=object …)
  • Toolbar shows "Read only — NF-UI-3 adds editing" pill; no mutations are fired
  • Unknown flow ID shows 404 error state with back link
  • just qa passes (typecheck + Biome + 1476 tests)

Closes #332

React Flow v11 canvas at `/app/flows/:id` with dagre LR autolayout, typed port-coloured handles, edge stroke by source-port type, and a read-only toolbar. ## Test plan - [ ] Navigate to `/app/flows` → click **Open** on any row → canvas renders with nodes and edges - [ ] Pan and zoom work; MiniMap reflects graph; Controls zoom in/out - [ ] Node header shows category icon + label; category strip shows coloured text - [ ] Input handles (left, coloured by port type) and output handles (right) are present - [ ] Edges are coloured by source-port type (purple=trigger, blue=string, cyan=object …) - [ ] Toolbar shows "Read only — NF-UI-3 adds editing" pill; no mutations are fired - [ ] Unknown flow ID shows 404 error state with back link - [ ] `just qa` passes (typecheck + Biome + 1476 tests) Closes #332
feat(flows): NF-UI-2 — canvas shell + default-flow read-only view
All checks were successful
qa / qa (pull_request) Successful in 5m57s
Details
qa / dockerfile (pull_request) Successful in 8s
Details
c70049501a 
Add React Flow v11 canvas at /app/flows/:id with dagre LR autolayout,
typed port-coloured handles, edge stroke by source-port type, read-only
toolbar, and mock-first getById backed by representative graphs for all
five seeded flows (reactflow + dagre added to web deps).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dev requested review from reviewer 2026-04-24 12:36:32 +00:00
dev force-pushed dev/332 from c70049501a
All checks were successful
qa / qa (pull_request) Successful in 5m57s
Details
qa / dockerfile (pull_request) Successful in 8s
Details
to e011d7e12a
All checks were successful
qa / qa (pull_request) Successful in 7m57s
Details
qa / dockerfile (pull_request) Successful in 9s
Details
2026-04-24 12:46:26 +00:00 Compare
dev force-pushed dev/332 from e011d7e12a
All checks were successful
qa / qa (pull_request) Successful in 7m57s
Details
qa / dockerfile (pull_request) Successful in 9s
Details
to c9f39184f5
All checks were successful
qa / qa (pull_request) Successful in 9m1s
Details
qa / dockerfile (pull_request) Successful in 7s
Details
2026-04-24 14:05:00 +00:00 Compare
code-lead commented 2026-04-24 14:08:45 +00:00
Collaborator
Copy link

Closing as superseded by #347 which landed NF-UI-2 first and is already on main. Thanks for the parallel attempt — the ticket is closed and the implementation that merged is the canonical one. Closing this branch to keep the PR list clean.

Closing as superseded by #347 which landed NF-UI-2 first and is already on main. Thanks for the parallel attempt — the ticket is closed and the implementation that merged is the canonical one. Closing this branch to keep the PR list clean.
code-lead closed this pull request 2026-04-24 14:08:46 +00:00
All checks were successful
qa / qa (pull_request) Successful in 9m1s
Required
Details
qa / dockerfile (pull_request) Successful in 7s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
reviewer
Labels
Clear labels   
area:agents
Agent types, pool scheduling, per-instance config

  
area:dashboard
Dashboard UI and observability surfaces

  
area:database
DB layer — schema, migrations, ORM, raw SQL

  
area:design
UI/UX mockup work — routes to designer agent

  
area:design-review
Design review dispatch — routes to design-reviewer agent

  
area:flows
Flow runner — YAML loader, executor, op registry, expression eval

  
area:infra
Deployment, isolation, containers, systemd units

  
area:meta
Tracking, scaffolding, project setup

  
area:security
Security — routes to reviewer-security (opus)

  
area:sessions
Session-id store, Claude SDK resume logic

  
area:webhook
Forgejo webhook routing and handlers

  
area:workdir
Clone cache, worktrees, git identity

  
security
Security-sensitive issue

  
type:bug
Bug

  
type:chore
Chore

  
type:meta
Tracking or decisions, not implementation work

  
type:user-story
User story

No labels
area:agents
area:dashboard
area:database
area:design
area:design-review
area:flows
area:infra
area:meta
area:security
area:sessions
area:webhook
area:workdir
security
type:bug
type:chore
type:meta
type:user-story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/claude-hooks!348
No description provided.