charles/claude-hooks
1
0
Fork 0
Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

feat(flows): NF-UI-1 flow list page at /app/flows #343

Closed
dev wants to merge 1 commit from dev/331 into main
pull from: dev/331
merge into: charles:main
Conversation 1 Commits 1 Files changed 7 +296
dev commented 2026-04-24 11:56:05 +00:00
Collaborator
Copy link

Adds the /app/flows list page (NF-UI-1) server-driven from a new GET /flows endpoint.

Test plan

  • GET /flows returns the seeded default flow on a fresh DB
  • Trigger / repo-pattern / enabled / source filters narrow the table client-side
  • Enable toggle is optimistic; a 403 response rolls back the pill
  • Default flows show no Delete button; operator flows do (when authenticated)
  • just qa passes (typecheck + Biome + 241 tests)

Closes #331

Adds the `/app/flows` list page (NF-UI-1) server-driven from a new `GET /flows` endpoint. ## Test plan - [ ] `GET /flows` returns the seeded default flow on a fresh DB - [ ] Trigger / repo-pattern / enabled / source filters narrow the table client-side - [ ] Enable toggle is optimistic; a 403 response rolls back the pill - [ ] Default flows show no Delete button; operator flows do (when authenticated) - [ ] `just qa` passes (typecheck + Biome + 241 tests) Closes #331
feat(flows): NF-UI-1 flow list page at /app/flows
All checks were successful
qa / qa (pull_request) Successful in 4m28s
Details
qa / dockerfile (pull_request) Successful in 9s
Details
50ff30e067 
Add GET /flows server endpoint, flows SQLite table (seeded with one
default row on startup), and the /app/flows list page with filters
(trigger, repo-pattern, enabled, source), per-row actions (open, toggle,
delete), optimistic enable-toggle with 403 rollback, auth-gated operator
actions, and Vitest unit tests covering validateSearch, filter logic,
delete-refused, and auth-gating.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dev requested review from reviewer 2026-04-24 12:04:10 +00:00
dev force-pushed dev/331 from 50ff30e067
All checks were successful
qa / qa (pull_request) Successful in 4m28s
Details
qa / dockerfile (pull_request) Successful in 9s
Details
to 174542f833
All checks were successful
qa / qa (pull_request) Successful in 4m37s
Details
qa / dockerfile (pull_request) Successful in 9s
Details
2026-04-24 12:45:59 +00:00 Compare
code-lead commented 2026-04-24 14:08:39 +00:00
Collaborator
Copy link

Closing as superseded by #344 which landed NF-UI-1 first and is already on main. Thanks for the parallel attempt — the ticket is closed and the implementation that merged is the canonical one. Closing this branch to keep the PR list clean.

Closing as superseded by #344 which landed NF-UI-1 first and is already on main. Thanks for the parallel attempt — the ticket is closed and the implementation that merged is the canonical one. Closing this branch to keep the PR list clean.
code-lead closed this pull request 2026-04-24 14:08:40 +00:00
All checks were successful
qa / qa (pull_request) Successful in 4m37s
Required
Details
qa / dockerfile (pull_request) Successful in 9s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
reviewer
Labels
Clear labels   
area:agents
Agent types, pool scheduling, per-instance config

  
area:dashboard
Dashboard UI and observability surfaces

  
area:database
DB layer — schema, migrations, ORM, raw SQL

  
area:design
UI/UX mockup work — routes to designer agent

  
area:design-review
Design review dispatch — routes to design-reviewer agent

  
area:flows
Flow runner — YAML loader, executor, op registry, expression eval

  
area:infra
Deployment, isolation, containers, systemd units

  
area:meta
Tracking, scaffolding, project setup

  
area:security
Security — routes to reviewer-security (opus)

  
area:sessions
Session-id store, Claude SDK resume logic

  
area:webhook
Forgejo webhook routing and handlers

  
area:workdir
Clone cache, worktrees, git identity

  
security
Security-sensitive issue

  
type:bug
Bug

  
type:chore
Chore

  
type:meta
Tracking or decisions, not implementation work

  
type:user-story
User story

No labels
area:agents
area:dashboard
area:database
area:design
area:design-review
area:flows
area:infra
area:meta
area:security
area:sessions
area:webhook
area:workdir
security
type:bug
type:chore
type:meta
type:user-story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/claude-hooks!343
No description provided.