refactor(deps): migrate to adapter factory (MF-10) #319

Merged
code-lead merged 1 commit from feat/mf10-migrate-deps into main 2026-04-24 10:39:49 +00:00
Collaborator

Summary

  • Replace every new ForgejoAdapter(token) in apps/server/src/domain/workflow/deps.ts with createForgeAdapterForRepo(repo, token) from adapter-factory.ts so the issue-dependency propagator, /issues/ready, buildIssueDepsGraph, and just deps-backfill honour each repo's forge binding (MF-4 / #295).
  • Mechanical migration — eleven callsites touched (including the defaultListIssues DI seam and the in-doc example). No behaviour change for pure-forgejo repos; GitHub + GitLab repos now get the right adapter without further plumbing.
  • Existing public signatures preserved so the test-mocked ListIssuesFn still plugs in without modification.

Cleanup of MF-8 (#299) out-of-scope list — migrates deps.ts.

Test plan

  • apps/server/src/domain/workflow/deps.test.ts — 61/61 pass
  • bun x turbo run typecheck — clean across all 4 packages
  • bun x biome check . — clean (299 files)
  • Full server suite — only 5 pre-existing failures (session JSONL pruning, foreman session CRUD), none touch deps.ts

🤖 Generated with Claude Code

## Summary - Replace every `new ForgejoAdapter(token)` in `apps/server/src/domain/workflow/deps.ts` with `createForgeAdapterForRepo(repo, token)` from `adapter-factory.ts` so the issue-dependency propagator, `/issues/ready`, `buildIssueDepsGraph`, and `just deps-backfill` honour each repo's forge binding (MF-4 / #295). - Mechanical migration — eleven callsites touched (including the `defaultListIssues` DI seam and the in-doc example). No behaviour change for pure-forgejo repos; GitHub + GitLab repos now get the right adapter without further plumbing. - Existing public signatures preserved so the test-mocked `ListIssuesFn` still plugs in without modification. Cleanup of MF-8 (#299) out-of-scope list — migrates deps.ts. ## Test plan - [x] `apps/server/src/domain/workflow/deps.test.ts` — 61/61 pass - [x] `bun x turbo run typecheck` — clean across all 4 packages - [x] `bun x biome check .` — clean (299 files) - [x] Full server suite — only 5 pre-existing failures (session JSONL pruning, foreman session CRUD), none touch deps.ts 🤖 Generated with [Claude Code](https://claude.com/claude-code)
refactor(deps): migrate to adapter factory (MF-10)
All checks were successful
qa / qa (pull_request) Successful in 3m56s
qa / dockerfile (pull_request) Successful in 8s
c39201217f
Replace every `new ForgejoAdapter(token)` in `deps.ts` with
`createForgeAdapterForRepo(repo, token)` from `adapter-factory.ts` so each
call site honours the per-repo forge binding (MF-4 / #295). This lets the
issue-dependency propagator, `/issues/ready`, and `just deps-backfill` work
against GitHub + GitLab repos without further changes.

Mechanical migration — eleven callsites touched, including the
`defaultListIssues` DI seam. Existing public signatures preserved so the
test-mocked `ListIssuesFn` still plugs in without modification.

Cleanup of MF-8 (#299) out-of-scope list — migrates deps.ts.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
code-lead deleted branch feat/mf10-migrate-deps 2026-04-24 10:39:49 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/claude-hooks!319
No description provided.