refactor(board-view): migrate to adapter factory (MF-10) #316

Merged
code-lead merged 1 commit from feat/mf10-migrate-board into main 2026-04-24 10:39:38 +00:00
Collaborator

Summary

  • Replace every new ForgejoAdapter(token) in apps/server/src/domain/views/board.ts with createForgeAdapterForRepo(repo, token) from infrastructure/forge/adapter-factory.
  • 7 callsites migrated (5 in PROD_DEPS, plus handleBoardAssign and handleBoardReroute). Each site already has repo in scope, so the swap is mechanical.
  • Cleanup of MF-8 (#299) out-of-scope list — migrates board.ts so board derivation and drag-to-assign route to the right ForgePort instead of silently hitting Forgejo for github/gitlab repos.

Test plan

  • bun run --filter @claude-hooks/server qa — typecheck clean, same 4 pre-existing failures as main (session JSONL pruning, foreman session CRUD); no new regressions.
  • cd apps/server && bun test src/domain/views/board.test.ts — 11 pass / 0 fail.
  • bun x biome check apps/server/src/domain/views/board.ts — clean.
  • Smoke /board + POST /board/assign + POST /board/reroute against the live Forgejo repo once merged; verify the same 200 responses.

Refs: #299 (MF-8), #313.

## Summary - Replace every `new ForgejoAdapter(token)` in `apps/server/src/domain/views/board.ts` with `createForgeAdapterForRepo(repo, token)` from `infrastructure/forge/adapter-factory`. - 7 callsites migrated (5 in `PROD_DEPS`, plus `handleBoardAssign` and `handleBoardReroute`). Each site already has `repo` in scope, so the swap is mechanical. - Cleanup of MF-8 (#299) out-of-scope list — migrates `board.ts` so board derivation and drag-to-assign route to the right `ForgePort` instead of silently hitting Forgejo for github/gitlab repos. ## Test plan - [x] `bun run --filter @claude-hooks/server qa` — typecheck clean, same 4 pre-existing failures as main (session JSONL pruning, foreman session CRUD); no new regressions. - [x] `cd apps/server && bun test src/domain/views/board.test.ts` — 11 pass / 0 fail. - [x] `bun x biome check apps/server/src/domain/views/board.ts` — clean. - [ ] Smoke `/board` + `POST /board/assign` + `POST /board/reroute` against the live Forgejo repo once merged; verify the same 200 responses. Refs: #299 (MF-8), #313.
refactor(board-view): migrate to adapter factory (MF-10)
All checks were successful
qa / qa (pull_request) Successful in 3m56s
qa / dockerfile (pull_request) Successful in 9s
e84ea53505
Replace every `new ForgejoAdapter(token)` in `board.ts` with
`createForgeAdapterForRepo(repo, token)` so board derivation and
drag-to-assign resolve the right forge per repo — github/gitlab repos
stop silently hitting Forgejo.

Cleanup of MF-8 (#299) out-of-scope list.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
code-lead deleted branch feat/mf10-migrate-board 2026-04-24 10:39:38 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/claude-hooks!316
No description provided.