chore(skills): terse Forgejo artifacts via shared artifact-style fragment #265

Merged
code-lead merged 1 commit from dev/261 into main 2026-04-21 20:43:36 +00:00
Collaborator
  • New skills/artifact-style.md: PR body ≤150 words, comment bullets ≤100/300 words, review verdicts typed per finding category
  • Appended unconditionally at every skill dispatch in webhook-handlers.ts (implement, review, address-review, rebase, breakdown) and webhook-ci.ts (fix-ci, merge)
  • skills/breakdown.md gets a scoping note: rules apply to the tracking comment only, not created issue bodies
  • Separate from caveman mode (#231) — affects output text only, not reasoning

Test plan

  • bun x biome check clean on modified files
  • bun x tsc --noEmit no new errors
  • Spot-check: next PR body from any agent should be ≤150 words with no boilerplate banner

Closes #261

- New `skills/artifact-style.md`: PR body ≤150 words, comment bullets ≤100/300 words, review verdicts typed per finding category - Appended unconditionally at every skill dispatch in `webhook-handlers.ts` (implement, review, address-review, rebase, breakdown) and `webhook-ci.ts` (fix-ci, merge) - `skills/breakdown.md` gets a scoping note: rules apply to the tracking comment only, not created issue bodies - Separate from caveman mode (#231) — affects output text only, not reasoning ## Test plan - `bun x biome check` clean on modified files - `bun x tsc --noEmit` no new errors - Spot-check: next PR body from any agent should be ≤150 words with no boilerplate banner Closes #261
chore(skills): add artifact-style fragment and wire to all skill dispatches
All checks were successful
qa / qa (pull_request) Successful in 4m4s
qa / dockerfile (pull_request) Successful in 9s
18ea4caa39
Creates skills/artifact-style.md with terse Forgejo output rules (PR body
≤150 words, bullets for comments, typed findings for review verdicts) and
appends it unconditionally at every skill dispatch in webhook-handlers.ts and
webhook-ci.ts. Breakdown note clarifies scope: rules cover the tracking
comment only, not created issue bodies. Separate from caveman mode (#231).

Closes #261

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dev requested review from reviewer 2026-04-21 20:40:26 +00:00
reviewer approved these changes 2026-04-21 20:43:07 +00:00
reviewer left a comment

CI green. All ACs met.

  • skills/artifact-style.md correct — under 40 lines, covers all required artifact types
  • breakdown.md scoping note (HTML comment) correctly excludes issue bodies
  • applyArtifactStyleAppendix wired at all dispatch sites: dispatchIssueForAgent (covers implement/design-implement/design-breakdown), handleReviewRequested, handleChangesRequested, dispatchRebaseIfNotMergeable, dispatchBreakdown, handlePostMergeRebase, dispatchFixCi, dispatchMerge
  • Caveman appendix still applied before artifact-style (correct ordering)
  • Duplicate applyArtifactStyleAppendix in webhook-ci.ts is correct given the webhook-handlers → webhook-ci import direction; comment explains the trade-off
CI green. All ACs met. - `skills/artifact-style.md` correct — under 40 lines, covers all required artifact types - `breakdown.md` scoping note (HTML comment) correctly excludes issue bodies - `applyArtifactStyleAppendix` wired at all dispatch sites: `dispatchIssueForAgent` (covers implement/design-implement/design-breakdown), `handleReviewRequested`, `handleChangesRequested`, `dispatchRebaseIfNotMergeable`, `dispatchBreakdown`, `handlePostMergeRebase`, `dispatchFixCi`, `dispatchMerge` - Caveman appendix still applied before artifact-style (correct ordering) - Duplicate `applyArtifactStyleAppendix` in `webhook-ci.ts` is correct given the `webhook-handlers → webhook-ci` import direction; comment explains the trade-off
code-lead deleted branch dev/261 2026-04-21 20:43:37 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/claude-hooks!265
No description provided.