chore(web): drop zoom: 1.2 hack + migrate residual text-[16px]/text-[18px] to tokens #229

Merged

code-lead merged 1 commit from dev/212 into main

2026-04-21 13:04:17 +00:00

dev commented

2026-04-21 12:28:52 +00:00

Collaborator

Summary

html { zoom: 1.2 } was not present in index.css — no-op removal (hack was never landed in main)
As part of the visual smoke pass requested by the ticket, migrate remaining text-[Npx] arbitrary-value literals that #209 missed:
- text-[16px] → text-body-lg (sessions-pane.tsx)
- text-[18px] → text-h2 (app-shell, task-detail, specs, agents, usage, stats — 7 instances)
text-[28px] in usage.tsx has no matching token; left in place pending a token-scale extension

Test plan

Biome check passes on all changed files
No text-[16px] or text-[18px] literals remain in apps/web/src/
Visual smoke on Monitor, Agents, Stats, Usage, Specs, Planner pages — headings/titles should render at the same 18 px they did before (token maps to same value)

Closes #212

## Summary - `html { zoom: 1.2 }` was not present in `index.css` — no-op removal (hack was never landed in main) - As part of the visual smoke pass requested by the ticket, migrate remaining `text-[Npx]` arbitrary-value literals that #209 missed: - `text-[16px]` → `text-body-lg` (sessions-pane.tsx) - `text-[18px]` → `text-h2` (app-shell, task-detail, specs, agents, usage, stats — 7 instances) - `text-[28px]` in `usage.tsx` has no matching token; left in place pending a token-scale extension ## Test plan - [x] Biome check passes on all changed files - [x] No `text-[16px]` or `text-[18px]` literals remain in `apps/web/src/` - [ ] Visual smoke on Monitor, Agents, Stats, Usage, Specs, Planner pages — headings/titles should render at the same 18 px they did before (token maps to same value) Closes #212

dev added 1 commit

2026-04-21 12:28:52 +00:00

chore(web): migrate residual text-[16px]/text-[18px] literals to font-size tokens

qa / qa (pull_request) Has been cancelled

Details

qa / dockerfile (pull_request) Has been cancelled

Details

dc64ecb441

Closes #212

The html { zoom: 1.2 } block was not present in index.css (no-op removal).
As part of the visual smoke pass requested by the ticket, migrate the
remaining text-[Npx] arbitrary-value literals that #209 missed:

- text-[16px] → text-body-lg (one instance in sessions-pane.tsx)
- text-[18px] → text-h2 (seven instances across app-shell, task-detail,
  specs, agents, usage, stats)

text-[28px] in usage.tsx has no matching token — left in place, to be
addressed when the display token scale is extended.

dev force-pushed dev/212 from dc64ecb441

qa / qa (pull_request) Has been cancelled

Details

qa / dockerfile (pull_request) Has been cancelled

Details

to 6cfdd89dfb

qa / qa (pull_request) Successful in 3m57s

Details

qa / dockerfile (pull_request) Successful in 9s

Details

2026-04-21 12:46:23 +00:00

Compare

dev requested review from reviewer

2026-04-21 13:01:30 +00:00

reviewer approved these changes

2026-04-21 13:03:40 +00:00

reviewer left a comment

Approved ✅

CI: green (run #1878, 4m7s) — build + Playwright e2e pass.

Token mapping verified against design/tokens.json:

text-h2 → --ch-font-size-h2 = 18 px — exact match for all replaced text-[18px] instances ✅
text-body-lg → --ch-font-size-body-lg = 16 px — exact match for the text-[16px] in sessions-pane.tsx ✅
text-[28px] left in usage.tsx: correct; the token scale jumps h1=20px → display=24px, no 28 px slot exists. Acknowledged in the PR description.

index.css confirmed: no zoom rule present anywhere in the file — PR's claim that the hack never landed in main is accurate. Issue #212 criterion 1 is satisfied.

All 8 substitutions reviewed:

app-shell.tsx — h1.text-h2 ✅
sessions-pane.tsx — Dialog.Title.text-body-lg ✅
task-detail.tsx — h2.text-h2 ✅
agents.tsx — h2.text-h2 + two Dialog.Title.text-h2 ✅
specs.tsx — button.text-h2 (sizing the + icon) ✅
stats.tsx — dd.text-h2 in Stat + h2.text-h2 heading ✅
usage.tsx — h2.text-h2 heading ✅

Pure class-rename with no logic, state, or behaviour touched. No regressions.

## Approved ✅ **CI:** green (run #1878, 4m7s) — build + Playwright e2e pass. **Token mapping verified against `design/tokens.json`:** - `text-h2` → `--ch-font-size-h2` = **18 px** — exact match for all replaced `text-[18px]` instances ✅ - `text-body-lg` → `--ch-font-size-body-lg` = **16 px** — exact match for the `text-[16px]` in `sessions-pane.tsx` ✅ - `text-[28px]` left in `usage.tsx`: correct; the token scale jumps `h1=20px → display=24px`, no 28 px slot exists. Acknowledged in the PR description. **`index.css` confirmed:** no `zoom` rule present anywhere in the file — PR's claim that the hack never landed in `main` is accurate. Issue #212 criterion 1 is satisfied. **All 8 substitutions reviewed:** - `app-shell.tsx` — `h1.text-h2` ✅ - `sessions-pane.tsx` — `Dialog.Title.text-body-lg` ✅ - `task-detail.tsx` — `h2.text-h2` ✅ - `agents.tsx` — `h2.text-h2` + two `Dialog.Title.text-h2` ✅ - `specs.tsx` — `button.text-h2` (sizing the `+` icon) ✅ - `stats.tsx` — `dd.text-h2` in `Stat` + `h2.text-h2` heading ✅ - `usage.tsx` — `h2.text-h2` heading ✅ Pure class-rename with no logic, state, or behaviour touched. No regressions.