feat(dashboard): timeline filter bar — event type / tool / actor / state #1000

Merged

reviewer merged 1 commit from dev/976 into main 2026-05-08 20:36:26 +00:00

Conversation 5 Commits 1 Files changed 4 +693 -47

dev commented 2026-05-08 20:12:37 +00:00

Collaborator

Copy link

Chip-based filter bar above the agent event log for post-mortem triage. Replaces the old single-line text filter.

Test plan

• <TimelineFilterBar> renders above event log in <TaskDetail> once events load
• Event type chips (e.g. tool_call, assistant) multi-select; kind chips (e.g. shell, edit) multi-select; state chips (error / approval / denied) appear only when matching events exist; actor chips appear when events carry detail.actor
• Selecting chips in the same group OR-matches; selecting across groups AND-matches (?evt=tool_call&kind=shell&state=error → shell tool_calls with errors only)
• "Clear" pill appears when any filter is active; clicking removes all params from URL
• Opening the URL with filter params pre-set (e.g. shared link) correctly scopes the log on load
• 27 unit tests: applyTimelineFilters logic, deriveFilterOptions counts, component chip rendering + toggle + clear

Closes #976

Chip-based filter bar above the agent event log for post-mortem triage. Replaces the old single-line text filter. ## Test plan - `<TimelineFilterBar>` renders above event log in `<TaskDetail>` once events load - Event type chips (e.g. `tool_call`, `assistant`) multi-select; kind chips (e.g. `shell`, `edit`) multi-select; state chips (`error` / `approval` / `denied`) appear only when matching events exist; actor chips appear when events carry `detail.actor` - Selecting chips in the same group OR-matches; selecting across groups AND-matches (`?evt=tool_call&kind=shell&state=error` → shell tool_calls with errors only) - "Clear" pill appears when any filter is active; clicking removes all params from URL - Opening the URL with filter params pre-set (e.g. shared link) correctly scopes the log on load - 27 unit tests: `applyTimelineFilters` logic, `deriveFilterOptions` counts, component chip rendering + toggle + clear Closes #976

dev self-assigned this 2026-05-08 20:12:37 +00:00

dev added 1 commit 2026-05-08 20:12:38 +00:00

feat(dashboard): timeline filter bar — event type / tool / actor / state ... d0011d372e

Add <TimelineFilterBar> above the agent event log with multi-select chips
for four dimensions: event type, ToolKind, canned state (error / approval /
denied), and subagent actor. Filters AND across dimensions, OR within.
State serialises to URL search params (evt= / kind= / state= / actor=) via
window.history.replaceState so links are shareable and survive reload.

Removes the old single-line text filter from EventLog; the chip bar
is a strict superset.

27 tests: applyTimelineFilters logic, deriveFilterOptions counts, component
chip rendering + toggle + clear all.

Closes #976

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer 2026-05-08 20:15:42 +00:00

reviewer requested changes 2026-05-08 20:16:58 +00:00

Dismissed

reviewer left a comment

Copy link

• ci: Run #3276 is failure — fix before merge. Logs at https://forge.jacquin.app/charles/claude-hooks/actions/runs/1754
• conflict: PR is mergeable: false — rebase on main required.
• behavior: deriveFilterOptions(events) always uses the raw (unfiltered) event list. AC says "Chips show counts at the current filter scope" — if kind=shell is active, event-type chip counts should reflect only shell events, not the full set. Fix: pass the currently-filtered events to deriveFilterOptions, or compute per-dimension counts from events filtered by all other active dimensions.

- **ci**: Run #3276 is `failure` — fix before merge. Logs at https://forge.jacquin.app/charles/claude-hooks/actions/runs/1754 - **conflict**: PR is `mergeable: false` — rebase on main required. - **behavior**: `deriveFilterOptions(events)` always uses the raw (unfiltered) event list. AC says "Chips show counts at the current filter scope" — if `kind=shell` is active, event-type chip counts should reflect only shell events, not the full set. Fix: pass the currently-filtered events to `deriveFilterOptions`, or compute per-dimension counts from events filtered by all other active dimensions.

dev force-pushed dev/976 from d0011d372e to c8771529ee 2026-05-08 20:25:51 +00:00 Compare

dev force-pushed dev/976 from c8771529ee to e5112bc9c2 2026-05-08 20:31:47 +00:00 Compare

dev requested review from reviewer 2026-05-08 20:31:53 +00:00

reviewer refused to review 2026-05-08 20:32:46 +00:00

reviewer commented 2026-05-08 20:32:49 +00:00

Collaborator

Copy link

CI still pending at review time (run #3283, sha e5112bc). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3283, sha `e5112bc`). Stepping off the review request — will be re-dispatched automatically when CI completes.

reviewer commented 2026-05-08 20:34:01 +00:00

Collaborator

Copy link

CI still pending at review time (run #3283, sha e5112bc). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3283, sha `e5112bc`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-08 20:34:50 +00:00

reviewer approved these changes 2026-05-08 20:36:21 +00:00

Dismissed

reviewer left a comment

Copy link

Filter logic, URL serialisation, and component rendering all correct. 27 tests cover the critical paths. CI green.

Filter logic, URL serialisation, and component rendering all correct. 27 tests cover the critical paths. CI green.

reviewer merged commit 42725f978d into main 2026-05-08 20:36:26 +00:00

reviewer approved these changes 2026-05-08 20:36:31 +00:00

reviewer left a comment

Copy link

Filter logic correct, URL serialization idiomatic, all 6 ACs met, CI green. Nit: persistFilters is called inside the setFiltersState updater — harmless (idempotent) but could move outside the updater for clarity.

Filter logic correct, URL serialization idiomatic, all 6 ACs met, CI green. Nit: `persistFilters` is called inside the `setFiltersState` updater — harmless (idempotent) but could move outside the updater for clarity.

Sign in to join this conversation.

Reviewers

No reviewers

reviewer

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

dev

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks!1000

No description provided.