feat(webhook): SR-5 drop routing skill_overrides (#873) #888

Merged

charles merged 1 commit from code-lead/872 into main 2026-05-05 22:00:16 +00:00

Conversation 2 Commits 1 Files changed 10 +113 -157

claude-desktop commented 2026-05-05 21:54:23 +00:00

Collaborator

Copy link

Summary

Implements #873 (SR-5 webhook routing cleanup): remove parallel skill name rewrites from webhook routing so dispatch always passes base skill names (implement, review, …) into renderPrompt / resolveSkillBody, with specialised bodies coming from agent_skill rows per type.

Changes

• Drop skill_overrides from RoutingInputType, skillOverrideByAgent, and exported skillForAgent.
• RoutingDbOverlay now only overlays reviews_authors / reviews_labels (SC-10).
• agent.render_skill passes the base skill through unchanged.
• Tests seed designer implement and design-reviewer review in agent_skill where design templates are required.

Checklist

• just qa

Closes #873

## Summary Implements **#873** (SR-5 webhook routing cleanup): remove parallel skill name rewrites from webhook routing so dispatch always passes base skill names (`implement`, `review`, …) into `renderPrompt` / `resolveSkillBody`, with specialised bodies coming from **`agent_skill`** rows per type. ## Changes - Drop `skill_overrides` from `RoutingInputType`, `skillOverrideByAgent`, and exported **`skillForAgent`**. - `RoutingDbOverlay` now only overlays `reviews_authors` / `reviews_labels` (SC-10). - `agent.render_skill` passes the base skill through unchanged. - Tests seed designer `implement` and design-reviewer `review` in `agent_skill` where design templates are required. ## Checklist - [x] `just qa` Closes #873

claude-desktop added 6 commits 2026-05-05 21:54:23 +00:00

feat(skills): SR-4 dispatch cutover — replace skillForEvent chain with renderPrompt (#872) 6a7091c085

style(skills): avoid 'any' cast in renderPrompt (lint) ba960ff2a0

chore(web): fix lint warnings and remove legacy Object.hasOwn polyfill c4a08b3cde

fix(skills): restore flow-graph renderPrompt FS fallback and caveman labels ... 9ec25326d4

- Optional filesystemFallback (on for agent.render_skill) matches legacy
  skillForEvent + ship skills when agent_skill rows are absent
- dispatchLabels + shared gate restore per-label caveman (issue #872)
- dispatchIssueForAgent passes labels into renderPrompt

Co-authored-by: Cursor <cursoragent@cursor.com>

fix(agent-nodes): restore artifact-only mode and full caveman gate ... b0781ba859

- artifact-only appendix_mode in else branch never fired artifact-style
  (neither if/else if matched, so the unconditional applyArtifactStyleAppendix
  call from the old code had no equivalent); add explicit else if branch.
- caveman gate in else-full branch only checked globalMode||apply_caveman,
  missing per-agent caveman.enabled and per-label matching; align with the
  full shouldApplyCavemanAppendix logic.
- Fix broken HTML comment in index.html (wrong indentation + duplicate "rather").

Co-authored-by: Cursor <cursoragent@cursor.com>

feat(webhook): drop routing skill_overrides and skillForAgent (SR-5, #873) ... 47b4288fb7

- Remove skill_overrides from RoutingInputType and baked defaults; stop
  compiling skillOverrideByAgent.
- Routing DB overlay now only carries reviews_authors/reviews_labels.
- Flow render_skill passes base skill names through; agent_skill rows
  supply designer/design-reviewer templates.
- Update flow + handler tests with agent_skill seeds and stricter assertions.

Co-authored-by: Cursor <cursoragent@cursor.com>

claude-desktop commented 2026-05-05 21:56:30 +00:00

Author

Collaborator

Copy link

Clean history: branch code-lead/873 is pushed with a single commit on top of current main (cherry-pick of the SR-5 work). Please edit this PR and set the head/compare branch to code-lead/873 instead of code-lead/872. After that you can delete or reset code-lead/872 on the remote if you no longer need it.

Clean history: branch **`code-lead/873`** is pushed with a single commit on top of current `main` (cherry-pick of the SR-5 work). Please **edit this PR** and set the head/compare branch to **`code-lead/873`** instead of **`code-lead/872`**. After that you can delete or reset `code-lead/872` on the remote if you no longer need it.

charles force-pushed code-lead/872 from 47b4288fb7 to 534eb8c994 2026-05-05 21:59:25 +00:00 Compare

claude-desktop commented 2026-05-05 21:59:29 +00:00

Author

Collaborator

Copy link

Update: origin/code-lead/872 was force-pushed to match 534eb8c (same tip as code-lead/873) — i.e. exactly one commit on top of current main (fad29b6). PR #888 should now list a single commit. The pre-merge #872 chain is only on main now via #887, not on this branch.

**Update:** `origin/code-lead/872` was force-pushed to match **`534eb8c`** (same tip as `code-lead/873`) — i.e. **exactly one commit** on top of current `main` (`fad29b6`). PR #888 should now list a single commit. The pre-merge #872 chain is only on `main` now via #887, not on this branch.

charles merged commit 3b0eac1874 into main 2026-05-05 22:00:16 +00:00

charles deleted branch code-lead/872 2026-05-05 22:00:16 +00:00

charles referenced this pull request from a commit 2026-05-05 22:00:17 +00:00

feat(webhook): SR-5 drop routing skill_overrides (#873) (#888)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks!888

No description provided.