charles/claude-hooks

Fork 0

SVC-1: Schema + builtin-sync for service_config #750

New issue

Closed

opened 2026-05-02 17:26:25 +00:00 by claude-desktop · 1 comment

claude-desktop commented

2026-05-02 17:26:25 +00:00

Collaborator

Bundle directive

This story ships in one PR with #743 (AT-1) and #754 (LBL-1) — the foundation layer. Assign #743, not this issue. The PR closes all three (Closes #743 #750 #754).

As a platform engineer, I want a service_config table and a builtin-sync pass that mirrors config/service.json into scope='builtin', so that runtime reads of deploy-time service infra (forge URL, container image, watchdogs, auth, node_flows, penpot, MCP command) can move off the file system onto a DB-backed source of truth.

Acceptance criteria

Schema

migrations/<n>-service-config.ts creates the service_config table with the columns + scope check (builtin/global only) + UNIQUE(scope) constraint per specs/config-to-db.md § Architecture.
Webhook secret moves to the SC-6 secret table — the schema migration reads the file's bytes (one-shot), writes them to secret, stores the FK in service_config.webhook_secret_ref, and renames the file to .<basename>.migrated.bak.

Builtin sync

syncServiceConfigBuiltin(serviceJsonPath) writes the single scope='builtin' row. Idempotent.
getServiceConfig() returns the most-specific row across global → builtin.

Tests

Unit: idempotent sync, scope ladder merge.
Integration: a scope='global' override on container_image is preserved across a re-sync that bumps the builtin's value.

Out of scope

Swapping consumers — covered by SVC-2.
Hot reload of service infra mid-run — out of scope per spec non-goals.
Dashboard CRUD UI — covered by SVC-3.

References

Spec: specs/config-to-db.md § Story SVC-1, § Architecture.
Bundled with: #743 (AT-1), #754 (LBL-1) — assign #743, this closes via the same PR.

## Bundle directive This story ships in **one PR with #743 (AT-1) and #754 (LBL-1)** — the foundation layer. **Assign #743**, not this issue. The PR closes all three (`Closes #743 #750 #754`). --- As a platform engineer, I want a `service_config` table and a builtin-sync pass that mirrors `config/service.json` into `scope='builtin'`, so that runtime reads of deploy-time service infra (forge URL, container image, watchdogs, auth, node_flows, penpot, MCP command) can move off the file system onto a DB-backed source of truth. ## Acceptance criteria ### Schema - [ ] `migrations/<n>-service-config.ts` creates the `service_config` table with the columns + scope check (`builtin`/`global` only) + UNIQUE(scope) constraint per `specs/config-to-db.md` § Architecture. - [ ] Webhook secret moves to the SC-6 `secret` table — the schema migration reads the file's bytes (one-shot), writes them to `secret`, stores the FK in `service_config.webhook_secret_ref`, and renames the file to `.<basename>.migrated.bak`. ### Builtin sync - [ ] `syncServiceConfigBuiltin(serviceJsonPath)` writes the single `scope='builtin'` row. Idempotent. - [ ] `getServiceConfig()` returns the most-specific row across `global → builtin`. ### Tests - [ ] Unit: idempotent sync, scope ladder merge. - [ ] Integration: a `scope='global'` override on `container_image` is preserved across a re-sync that bumps the builtin's value. ## Out of scope - Swapping consumers — covered by SVC-2. - Hot reload of service infra mid-run — out of scope per spec non-goals. - Dashboard CRUD UI — covered by SVC-3. ## References - Spec: `specs/config-to-db.md` § Story SVC-1, § Architecture. - Bundled with: #743 (AT-1), #754 (LBL-1) — assign #743, this closes via the same PR.

claude-desktop added the

area:infra

type:user-story

labels

2026-05-02 17:28:59 +00:00

claude-desktop added this to the Config to DB milestone

2026-05-02 17:29:00 +00:00

claude-desktop referenced this issue

2026-05-02 17:40:04 +00:00

AT-1: Schema + builtin-sync for agent_type tables #743

claude-desktop referenced this issue

2026-05-02 17:40:31 +00:00

LBL-1: Schema + builtin-sync for label_catalog #754

code-lead referenced this issue from a commit

2026-05-02 17:56:01 +00:00

feat(agent-config): schema + builtin-sync for agent_type / service_config / label_catalog

code-lead referenced this issue

2026-05-02 17:56:25 +00:00

feat(agent-config): schema + builtin-sync for agent_type / service_config / label_catalog #761

charles referenced this issue from a commit

2026-05-02 18:11:02 +00:00

feat(agent-config): schema + builtin-sync for agent_type / service_config / label_catalog (#761)

claude-desktop commented

2026-05-02 19:16:48 +00:00

Author

Collaborator

Shipped via PR #761 (commit 28027b9) as part of the foundation bundle alongside #743 (AT-1) and #754 (LBL-1). The PR body lacked the Closes keyword so this issue stayed open by mistake — closing now.

Coverage:

migrations/<n>-service-config.ts created
syncServiceConfigBuiltin(serviceJsonPath) writes the single scope='builtin' row, idempotent
getServiceConfig() resolves global → builtin
Webhook secret migration into the SC-6 secret table

Closing.

Shipped via PR #761 (commit `28027b9`) as part of the foundation bundle alongside #743 (AT-1) and #754 (LBL-1). The PR body lacked the `Closes` keyword so this issue stayed open by mistake — closing now. Coverage: - `migrations/<n>-service-config.ts` created - `syncServiceConfigBuiltin(serviceJsonPath)` writes the single `scope='builtin'` row, idempotent - `getServiceConfig()` resolves `global → builtin` - Webhook secret migration into the SC-6 `secret` table Closing.

claude-desktop closed this issue

2026-05-02 19:16:51 +00:00

claude-desktop referenced this issue

2026-05-02 19:16:57 +00:00

LBL-1: Schema + builtin-sync for label_catalog #754

charles referenced this issue from a commit

2026-05-02 21:33:04 +00:00

docs(spec): workspace chat voice input via local speaches

code-lead referenced this issue

2026-05-02 21:41:50 +00:00

VOICE-1: /architect/transcribe server proxy + speaches integration #773