charles/claude-hooks

Fork

You've already forked claude-hooks

Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

AT-1: Schema + builtin-sync for agent_type tables #743

New issue

Closed

opened 2026-05-02 17:24:42 +00:00 by claude-desktop · 0 comments

claude-desktop commented

2026-05-02 17:24:42 +00:00

Collaborator

Copy link

Bundle directive

This story ships in one PR with #750 (SVC-1) and #754 (LBL-1) — the foundation layer that introduces the three new resolver entry points (getAgentType, getServiceConfig, getLabelCatalogForRepo), the three matching builtin-sync passes, and the three migration files. They share a single round of edits to domain/agent-config/resolver.ts and domain/agent-config/builtin-sync.ts, so bundling avoids merge conflicts and lets one review pass cover the whole layer.

The PR closes all three issues (Closes #743 #750 #754).

As a platform engineer, I want the per-kind tables that hold per-type identity, container, and routing config plus a builtin-sync pass that mirrors config/agents.json::types{} into them on boot, so that runtime reads can move off the in-memory cfg.types[…] map onto a DB-backed scope ladder consistent with skills / prompts / plugins.

Acceptance criteria

Schema

migrations/<n>-agent-type.ts creates agent_type, agent_type_container, and agent_type_routing with the columns, scope checks (builtin → global → agent_type → instance per table — service-wide tables only builtin/global), and unique constraints listed in specs/config-to-db.md § Architecture.
agent_type.token_secret_id column exists as a forward placeholder for TOK-1; nullable.
Schema migration is idempotent across reboots and a no-op when columns already exist.

Builtin sync

domain/agent-config/builtin-sync.ts grows syncAgentTypeBuiltins(agentsJsonPath) that walks types{} and upserts one row per type at scope='builtin' plus a joined container row + routing row per type.
Re-running the sync on unchanged input returns { inserted: 0, updated: 0 }.
A type that vanishes from the factory image is not deleted from the DB — its scope='builtin' row gets enabled=false (mirrors the plugin-binding shadow pattern) so existing instances keep resolving.

Resolver

domain/agent-config/resolver.ts grows getAgentType(name): ResolvedAgentType | null that joins the most-specific agent_type + agent_type_container + agent_type_routing rows across the scope ladder.
ResolvedAgentType shape matches today's cfg.types[name] (same field names, same JSON-decoded shapes) so AT-2's call-site swap is mechanical.

Tests

Unit: idempotent sync, scope ladder merge, removed-type shadow.
Integration: a fresh DB + a mutated agents.json boot syncs new rows; an existing agent_type-scope override is preserved across restart (operator-edited git_email for dev survives a re-sync that updates the builtin's default_system_prompt).

Out of scope

Swapping consumers — covered by AT-2.
Token migration — covered by TOK-1.
Dashboard CRUD UI — covered by AT-6.

References

Spec: specs/config-to-db.md § Architecture, § Story AT-1.
Precedent: SC-1 (issue closed under milestone #28) — schema + builtin-sync pattern.
Bundled with: #750 (SVC-1), #754 (LBL-1).

## Bundle directive This story ships in **one PR with #750 (SVC-1) and #754 (LBL-1)** — the foundation layer that introduces the three new resolver entry points (`getAgentType`, `getServiceConfig`, `getLabelCatalogForRepo`), the three matching builtin-sync passes, and the three migration files. They share a single round of edits to `domain/agent-config/resolver.ts` and `domain/agent-config/builtin-sync.ts`, so bundling avoids merge conflicts and lets one review pass cover the whole layer. The PR closes all three issues (`Closes #743 #750 #754`). --- As a platform engineer, I want the per-kind tables that hold per-type identity, container, and routing config plus a builtin-sync pass that mirrors `config/agents.json::types{}` into them on boot, so that runtime reads can move off the in-memory `cfg.types[…]` map onto a DB-backed scope ladder consistent with skills / prompts / plugins. ## Acceptance criteria ### Schema - [ ] `migrations/<n>-agent-type.ts` creates `agent_type`, `agent_type_container`, and `agent_type_routing` with the columns, scope checks (`builtin → global → agent_type → instance` per table — service-wide tables only `builtin`/`global`), and unique constraints listed in `specs/config-to-db.md` § Architecture. - [ ] `agent_type.token_secret_id` column exists as a forward placeholder for TOK-1; nullable. - [ ] Schema migration is idempotent across reboots and a no-op when columns already exist. ### Builtin sync - [ ] `domain/agent-config/builtin-sync.ts` grows `syncAgentTypeBuiltins(agentsJsonPath)` that walks `types{}` and upserts one row per type at `scope='builtin'` plus a joined container row + routing row per type. - [ ] Re-running the sync on unchanged input returns `{ inserted: 0, updated: 0 }`. - [ ] A type that vanishes from the factory image is **not deleted** from the DB — its `scope='builtin'` row gets `enabled=false` (mirrors the plugin-binding shadow pattern) so existing instances keep resolving. ### Resolver - [ ] `domain/agent-config/resolver.ts` grows `getAgentType(name): ResolvedAgentType | null` that joins the most-specific `agent_type` + `agent_type_container` + `agent_type_routing` rows across the scope ladder. - [ ] `ResolvedAgentType` shape matches today's `cfg.types[name]` (same field names, same JSON-decoded shapes) so AT-2's call-site swap is mechanical. ### Tests - [ ] Unit: idempotent sync, scope ladder merge, removed-type shadow. - [ ] Integration: a fresh DB + a mutated `agents.json` boot syncs new rows; an existing `agent_type`-scope override is preserved across restart (operator-edited `git_email` for `dev` survives a re-sync that updates the builtin's `default_system_prompt`). ## Out of scope - Swapping consumers — covered by AT-2. - Token migration — covered by TOK-1. - Dashboard CRUD UI — covered by AT-6. ## References - Spec: `specs/config-to-db.md` § Architecture, § Story AT-1. - Precedent: SC-1 (issue closed under milestone #28) — schema + builtin-sync pattern. - Bundled with: #750 (SVC-1), #754 (LBL-1).

claude-desktop added the

area:agents

type:user-story

labels

2026-05-02 17:28:33 +00:00

claude-desktop added this to the Config to DB milestone

2026-05-02 17:29:00 +00:00

claude-desktop referenced this issue

2026-05-02 17:40:22 +00:00

SVC-1: Schema + builtin-sync for service_config #750

claude-desktop referenced this issue

2026-05-02 17:40:31 +00:00

LBL-1: Schema + builtin-sync for label_catalog #754

code-lead was assigned by claude-desktop

2026-05-02 17:40:36 +00:00

code-lead referenced this issue from a commit

2026-05-02 17:56:01 +00:00

feat(agent-config): schema + builtin-sync for agent_type / service_config / label_catalog

code-lead referenced this issue from a pull request that will close it,

2026-05-02 17:56:25 +00:00

feat(agent-config): schema + builtin-sync for agent_type / service_config / label_catalog #761

charles closed this issue

2026-05-02 18:11:01 +00:00

charles referenced this issue from a commit

2026-05-02 18:11:02 +00:00

feat(agent-config): schema + builtin-sync for agent_type / service_config / label_catalog (#761)

claude-desktop referenced this issue

2026-05-02 19:16:48 +00:00

SVC-1: Schema + builtin-sync for service_config #750

claude-desktop referenced this issue

2026-05-02 19:16:57 +00:00

LBL-1: Schema + builtin-sync for label_catalog #754

No Branch/Tag specified

main

chore/sync-pre-push-from-forge-base

fix/flows-yaml-dispatch-identity

feat/board-tap-to-assign

dev/1107

code-lead/1106

code-lead/1108

dev/1104

code-lead/1103

code-lead/1080

dev/1087

feat/flows-yaml-ci-events

chore/board-drop-stalled-and-density-controls

fix/flows-yaml-routes-always-register

flows-yaml/api-defaults

dev/1023

fix/event-log-history-bleed

fix/janitor-fix-ci-logs-and-cap

dev/1022

fix/board-card-provider

code-lead/1036

dev/1025

code-lead/1020

dev/1017

code-lead/1026

feat/web-shortcut-registry-1018

dev/1015

code-lead/1009

code-lead/1008

dev/975

dev/969

dev/973

dev/967

code-lead/968

code-lead/953

dev/970

dev/976

code-lead/966

code-lead/956

code-lead/951

dev/962

dev/963

dev/977

dev/955

dev/983

dev/961

dev/974

code-lead/950

code-lead/939

dev/941

dev/940

dev/937

dev/938

dev/936

dev/935

feat/web-i18n-fr-locale

feat/spec-editor-ui-polish

chore/drop-legacy-compat

fix/skills-drop-preview-pane

fix/882-skills-safety-rail

dev/911

dev/909

dev/923

dev/917

dev/915

feat/879-sr11-m2-drop-legacy-skill

code-lead/873

dev/881

code-lead/869

dev/867

code-lead/845

code-lead/843

code-lead/844

dev/837

dev/861

dev/849

code-lead/837

code-lead/842

fix/dedup-rebase-inflight

dev/838

code-lead/847

dev/833

code-lead/848

pr/838

code-lead/841

feat/settings-save-bar/836

code-lead/840

dev/846

code-lead/839

dev/832

fix/board-sse-stale-cache

dev/834

dev/835

feat/settings-breadcrumbs

feat/forge-oauth-credentials

refactor/service-config-consolidation

feat/agent-tokens-to-secrets

feat/gitlab-oauth-to-db

feat/authelia-rip-and-voice-fixes

fix/rebase-storm-and-dead-letter

code-lead/797

code-lead/796

dev/811

code-lead/798

dev/810

code-lead/795

dev/808

code-lead/794

dev/805

dev/802

dev/803

feat/avatar-menu-settings-entry

feat/per-agent-token-tracking

dev/793

dev/747

dev/752

code-lead/790

code-lead/759

dev/756

dev/760

dev/741

dev/767

dev/740

dev/709

dev/644

dev/637

boss/614

dev/600

dev/611

dev/585

fix/login-bonus-fixes

boss/544

dev/542

refactor/api-prefix-and-session-gate

dev/489

boss/531

boss/518

dev/499

boss/516

dev/530

dev/517

dev/519

dev/515

dev/522

dev/503

dev/471

boss/329

dev/417

dev/418

dev/402

boss/327

dev/334

dev/332

boss/326

boss/325

dev/331

boss/324

boss/323

boss/322

dev/294

test/s11-task-analytics

dev/262

boss/270

dev/268

foreman/ui-consolidation-spec

dev/234

boss/196

boss/176

boss/164

fix/124-session-persist-bind

boss/52

dev/87

boss/73

dev/77

dev/81

dev/82

boss/79

dev/42

dev/35

boss/7

No results found.

Labels

Clear labels

area:agents

Agent types, pool scheduling, per-instance config

area:dashboard

Dashboard UI and observability surfaces

area:database

DB layer — schema, migrations, ORM, raw SQL

area:design

UI/UX mockup work — routes to designer agent

area:design-review

Design review dispatch — routes to design-reviewer agent

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

area:infra

Deployment, isolation, containers, systemd units

area:meta

Tracking, scaffolding, project setup

area:security

Security — routes to reviewer-security (opus)

area:sessions

Session-id store, Claude SDK resume logic

area:webhook

Forgejo webhook routing and handlers

area:workdir

Clone cache, worktrees, git identity

security

Security-sensitive issue

Tracking or decisions, not implementation work

No labels

Milestone

Clear milestone

No items

No milestone

Config to DB

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

code-lead

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks#743

Reference in a new issue

Repository

charles/claude-hooks

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns