charles/claude-hooks

Fork

You've already forked claude-hooks

Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

Cleanup webhooks — issues.closed and pull_request.merged #4

New issue

Closed

opened 2026-04-16 22:44:09 +00:00 by claude-desktop · 0 comments

claude-desktop commented

2026-04-16 22:44:09 +00:00

Collaborator

Copy link

User story

As ops, I want claude-hooks to drop persisted state for an issue or PR as soon as it closes/merges, so that worktrees and (later) session entries do not accumulate forever.

Acceptance criteria

New webhook routes (`src/webhook.ts`)

issues event with action === "closed" → call cleanupIssue(repo, issue_number) for each registered agent
pull_request event with action === "closed" and payload.pull_request.merged === true → derive the issue/branch and call cleanupIssue (or a parallel cleanupBranch) for the PR's source branch
Reopened issues (action === "reopened") are intentionally a no-op — no cleanup, no auto-redispatch
Bodies of these handlers stay short: delegate the actual filesystem/state work to a cleanup.ts module so the webhook layer stays declarative

`cleanup.ts` shim

Defines cleanupIssue(repo, issue_number, opts?) and cleanupBranch(repo, branch, opts?)
First implementation only logs the intent (so this PR can ship before the workdir module lands)
Once the workdir module merges, wire releaseWorktree({ keep: false }) for each agent
Once the sessions store ships, also call dropAllForIssue

Tests (`src/webhook.test.ts`)

Synthetic issues.closed payload triggers cleanupIssue once per agent
Synthetic pull_request.closed with merged: true triggers cleanupBranch
pull_request.closed with merged: false (i.e. closed without merging) also triggers cleanupBranch — discarded work shouldn't keep state either

Out of scope

The actual releaseWorktree call (lives in the workdir module's wiring story)
The actual session drop (lives in the sessions store story)
Sweeper for missed events (separate story)

References

Forgejo v15 event names: modules/webhook/type.go
Discussion: chat history, "Phase 1 — cleanup webhooks"

Dependencies

Blocked by: none (ships with stub cleanup.ts)
Blocks: #5
Branch off: main
Full graph: #10

## User story As **ops**, I want claude-hooks to drop persisted state for an issue or PR as soon as it closes/merges, so that worktrees and (later) session entries do not accumulate forever. ## Acceptance criteria ### New webhook routes (`src/webhook.ts`) - [ ] `issues` event with `action === "closed"` → call `cleanupIssue(repo, issue_number)` for each registered agent - [ ] `pull_request` event with `action === "closed"` and `payload.pull_request.merged === true` → derive the issue/branch and call `cleanupIssue` (or a parallel `cleanupBranch`) for the PR's source branch - [ ] Reopened issues (`action === "reopened"`) are intentionally a no-op — no cleanup, no auto-redispatch - [ ] Bodies of these handlers stay short: delegate the actual filesystem/state work to a `cleanup.ts` module so the webhook layer stays declarative ### `cleanup.ts` shim - [ ] Defines `cleanupIssue(repo, issue_number, opts?)` and `cleanupBranch(repo, branch, opts?)` - [ ] First implementation only logs the intent (so this PR can ship before the workdir module lands) - [ ] Once the workdir module merges, wire `releaseWorktree({ keep: false })` for each agent - [ ] Once the sessions store ships, also call `dropAllForIssue` ### Tests (`src/webhook.test.ts`) - [ ] Synthetic `issues.closed` payload triggers `cleanupIssue` once per agent - [ ] Synthetic `pull_request.closed` with `merged: true` triggers `cleanupBranch` - [ ] `pull_request.closed` with `merged: false` (i.e. closed without merging) also triggers `cleanupBranch` — discarded work shouldn't keep state either ## Out of scope - The actual `releaseWorktree` call (lives in the workdir module's wiring story) - The actual session drop (lives in the sessions store story) - Sweeper for missed events (separate story) ## References - Forgejo v15 event names: `modules/webhook/type.go` - Discussion: chat history, "Phase 1 — cleanup webhooks" ## Dependencies - **Blocked by:** none (ships with stub `cleanup.ts`) - **Blocks:** #5 - **Branch off:** `main` - **Full graph:** #10

claude-desktop added this to the Persistent workdirs and sessions milestone

2026-04-16 22:44:09 +00:00

claude-desktop added the

area:webhook

type:user-story

labels

2026-04-16 22:44:09 +00:00

claude-desktop referenced this issue

2026-04-16 22:45:58 +00:00

Tracking: persistent workdirs and sessions #10

claude-desktop referenced this issue

2026-04-16 22:47:14 +00:00

runAgent integration — swap mkdtemp+clone for worktree #5

dev was assigned by claude-desktop

2026-04-16 23:00:57 +00:00

dev was unassigned by charles

2026-04-16 23:15:49 +00:00

dev was assigned by charles

2026-04-16 23:15:54 +00:00

charles referenced this issue from a commit

2026-04-16 23:20:13 +00:00

feat(webhook): handle issues.closed and pull_request.closed for cleanup

claude-desktop referenced this issue from a pull request that will close it,

2026-04-16 23:22:03 +00:00

feat(webhook): handle issues.closed and pull_request.closed for cleanup #12

claude-desktop referenced this issue from a commit

2026-04-16 23:35:01 +00:00

feat(webhook): handle issues.closed and pull_request.closed for cleanup

charles referenced this issue from a commit

2026-04-17 09:07:34 +00:00

feat(webhook): handle issues.closed and pull_request.closed for cleanup

charles closed this issue

2026-04-17 09:07:45 +00:00

charles referenced this issue from a commit

2026-04-17 09:07:45 +00:00

feat(webhook): handle issues.closed and pull_request.closed for cleanup (#12)

designer referenced this issue

2026-04-18 22:38:35 +00:00

[smoke] Designer dispatch — hello sticker #62

design-reviewer referenced this issue

2026-04-19 18:35:16 +00:00

Design: rework the claude-hooks monitor (dashboard home screen) #70

designer referenced this issue

2026-04-19 23:47:09 +00:00

Design: rework the claude-hooks monitor (dashboard home screen) #70

code-lead referenced this issue from a commit

2026-04-28 10:53:02 +00:00

fix(sessions): bind forge into session key to prevent cross-forge collision (#520)

code-lead referenced this issue

2026-04-28 10:53:22 +00:00

fix(sessions): bind forge into session key to prevent cross-forge collision #534

code-lead referenced this issue from a commit

2026-04-28 13:06:14 +00:00

fix(sessions): bind forge into session key to prevent cross-forge collision

charles referenced this issue from a commit

2026-05-11 18:20:59 +00:00

fix(settings): seed inline-tree open groups from active route

No Branch/Tag specified

main

chore/sync-pre-push-from-forge-base

fix/flows-yaml-dispatch-identity

feat/board-tap-to-assign

dev/1107

code-lead/1106

code-lead/1108

dev/1104

code-lead/1103

code-lead/1080

dev/1087

feat/flows-yaml-ci-events

chore/board-drop-stalled-and-density-controls

fix/flows-yaml-routes-always-register

flows-yaml/api-defaults

dev/1023

fix/event-log-history-bleed

fix/janitor-fix-ci-logs-and-cap

dev/1022

fix/board-card-provider

code-lead/1036

dev/1025

code-lead/1020

dev/1017

code-lead/1026

feat/web-shortcut-registry-1018

dev/1015

code-lead/1009

code-lead/1008

dev/975

dev/969

dev/973

dev/967

code-lead/968

code-lead/953

dev/970

dev/976

code-lead/966

code-lead/956

code-lead/951

dev/962

dev/963

dev/977

dev/955

dev/983

dev/961

dev/974

code-lead/950

code-lead/939

dev/941

dev/940

dev/937

dev/938

dev/936

dev/935

feat/web-i18n-fr-locale

feat/spec-editor-ui-polish

chore/drop-legacy-compat

fix/skills-drop-preview-pane

fix/882-skills-safety-rail

dev/911

dev/909

dev/923

dev/917

dev/915

feat/879-sr11-m2-drop-legacy-skill

code-lead/873

dev/881

code-lead/869

dev/867

code-lead/845

code-lead/843

code-lead/844

dev/837

dev/861

dev/849

code-lead/837

code-lead/842

fix/dedup-rebase-inflight

dev/838

code-lead/847

dev/833

code-lead/848

pr/838

code-lead/841

feat/settings-save-bar/836

code-lead/840

dev/846

code-lead/839

dev/832

fix/board-sse-stale-cache

dev/834

dev/835

feat/settings-breadcrumbs

feat/forge-oauth-credentials

refactor/service-config-consolidation

feat/agent-tokens-to-secrets

feat/gitlab-oauth-to-db

feat/authelia-rip-and-voice-fixes

fix/rebase-storm-and-dead-letter

code-lead/797

code-lead/796

dev/811

code-lead/798

dev/810

code-lead/795

dev/808

code-lead/794

dev/805

dev/802

dev/803

feat/avatar-menu-settings-entry

feat/per-agent-token-tracking

dev/793

dev/747

dev/752

code-lead/790

code-lead/759

dev/756

dev/760

dev/741

dev/767

dev/740

dev/709

dev/644

dev/637

boss/614

dev/600

dev/611

dev/585

fix/login-bonus-fixes

boss/544

dev/542

refactor/api-prefix-and-session-gate

dev/489

boss/531

boss/518

dev/499

boss/516

dev/530

dev/517

dev/519

dev/515

dev/522

dev/503

dev/471

boss/329

dev/417

dev/418

dev/402

boss/327

dev/334

dev/332

boss/326

boss/325

dev/331

boss/324

boss/323

boss/322

dev/294

test/s11-task-analytics

dev/262

boss/270

dev/268

foreman/ui-consolidation-spec

dev/234

boss/196

boss/176

boss/164

fix/124-session-persist-bind

boss/52

dev/87

boss/73

dev/77

dev/81

dev/82

boss/79

dev/42

dev/35

boss/7

No results found.

Labels

Clear labels

area:agents

Agent types, pool scheduling, per-instance config

area:dashboard

Dashboard UI and observability surfaces

area:database

DB layer — schema, migrations, ORM, raw SQL

area:design

UI/UX mockup work — routes to designer agent

area:design-review

Design review dispatch — routes to design-reviewer agent

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

area:infra

Deployment, isolation, containers, systemd units

area:meta

Tracking, scaffolding, project setup

area:security

Security — routes to reviewer-security (opus)

area:sessions

Session-id store, Claude SDK resume logic

area:webhook

Forgejo webhook routing and handlers

area:workdir

Clone cache, worktrees, git identity

security

Security-sensitive issue

Tracking or decisions, not implementation work

No labels

Milestone

Clear milestone

No items

No milestone

Persistent workdirs and sessions

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

dev

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks#4

Reference in a new issue

Repository

charles/claude-hooks

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns

Cleanup webhooks — issues.closed and pull_request.merged #4

User story

Acceptance criteria

New webhook routes (src/webhook.ts)

cleanup.ts shim

Tests (src/webhook.test.ts)

Out of scope

References

Dependencies

New webhook routes (`src/webhook.ts`)

`cleanup.ts` shim

Tests (`src/webhook.test.ts`)