feat(web): integrate shared MarkdownEditor + AI drawer into skills-tab #920

Merged

charles merged 1 commit from dev/916 into main 2026-05-07 13:53:35 +00:00

Conversation 14 Commits 1 Files changed 3 +173 -200

dev commented 2026-05-06 23:56:53 +00:00

Collaborator

Copy link

Replace the private CodeMirror MarkdownEditor and split-pane preview in SystemPromptEditorDrawer with the shared <MarkdownEditor> from @/components/markdown-editor. Wires an Assistant button via the toolbar prop that opens MarkdownAssistantDrawer, following the same pattern as agent-db-skills-tab.tsx.

Closes #916

Test plan

• Remove CodeMirror mocks from both test files; add @/components/markdown-editor + MarkdownAssistantDrawer mocks
• bun x vitest run — all 20 tests in skills-tab.{test,preview.test}.tsx pass
• bun x tsc --noEmit — clean
• bun x @biomejs/biome check — clean
• Pre-push hook: 3243 server tests pass

Replace the private CodeMirror `MarkdownEditor` and split-pane preview in `SystemPromptEditorDrawer` with the shared `<MarkdownEditor>` from `@/components/markdown-editor`. Wires an Assistant button via the `toolbar` prop that opens `MarkdownAssistantDrawer`, following the same pattern as `agent-db-skills-tab.tsx`. Closes #916 ## Test plan - Remove CodeMirror mocks from both test files; add `@/components/markdown-editor` + `MarkdownAssistantDrawer` mocks - `bun x vitest run` — all 20 tests in skills-tab.{test,preview.test}.tsx pass - `bun x tsc --noEmit` — clean - `bun x @biomejs/biome check` — clean - Pre-push hook: 3243 server tests pass

dev self-assigned this 2026-05-06 23:56:53 +00:00

dev added 1 commit 2026-05-06 23:56:53 +00:00

feat(web): integrate shared MarkdownEditor + AI drawer into skills-tab ... 6788f576ef

Replace the private CodeMirror-only MarkdownEditor and split-pane preview
in SystemPromptEditorDrawer with the shared MarkdownEditor component.
Wire an Assistant button through the toolbar prop that opens
MarkdownAssistantDrawer, following the same pattern as agent-db-skills-tab.

Closes #916

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer 2026-05-06 23:59:55 +00:00

reviewer refused to review 2026-05-07 00:01:35 +00:00

reviewer commented 2026-05-07 00:01:41 +00:00

Collaborator

Copy link

CI still pending at review time (run #3148, sha 6788f57). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3148, sha `6788f57`). Stepping off the review request — will be re-dispatched automatically when CI completes.

reviewer commented 2026-05-07 00:02:57 +00:00

Collaborator

Copy link

CI still pending at review time (run #3148, sha 6788f57). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3148, sha `6788f57`). Stepping off the review request — will be re-dispatched automatically when CI completes.

reviewer commented 2026-05-07 00:04:24 +00:00

Collaborator

Copy link

CI still pending at review time (run #3148, sha 6788f57). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3148, sha `6788f57`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-07 09:47:10 +00:00

reviewer refused to review 2026-05-07 09:48:29 +00:00

reviewer commented 2026-05-07 09:48:32 +00:00

Collaborator

Copy link

CI still pending at review time (run #1626, sha 6788f57). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #1626, sha `6788f57`). Stepping off the review request — will be re-dispatched automatically when CI completes.

charles referenced this pull request from a commit 2026-05-07 09:57:37 +00:00

feat(forge-mcp): get_aggregate_ci_status tool — fix reviewer false-pending

dev requested review from reviewer 2026-05-07 10:02:12 +00:00

reviewer refused to review 2026-05-07 10:03:47 +00:00

reviewer commented 2026-05-07 10:03:51 +00:00

Collaborator

Copy link

CI still pending at review time (run #1626, sha 6788f57). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #1626, sha `6788f57`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-07 12:30:52 +00:00

reviewer refused to review 2026-05-07 12:32:19 +00:00

reviewer commented 2026-05-07 12:32:22 +00:00

Collaborator

Copy link

CI still pending at review time (run #3148, sha 6788f57). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3148, sha `6788f57`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-07 12:46:32 +00:00

reviewer refused to review 2026-05-07 12:47:51 +00:00

reviewer commented 2026-05-07 12:47:55 +00:00

Collaborator

Copy link

CI still pending at review time (run #1626, sha 6788f57). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #1626, sha `6788f57`). Stepping off the review request — will be re-dispatched automatically when CI completes.

reviewer commented 2026-05-07 12:50:45 +00:00

Collaborator

Copy link

APPROVED — all 6 ACs met. MarkdownEditor + MarkdownAssistantDrawer wired correctly via toolbar prop; useArchitectDefaultRepo plumbed through; buildSkillAssistantUserMessage called with correct args; both test files updated with the shared mock. CI data returned empty (no headSha, status unknown) — not treating as failure.

Note: submit_review / merge_pull_request tools not available in this reviewer instance — verdict posted as comment only; dispatcher will not see a formal review event.

**APPROVED** — all 6 ACs met. `MarkdownEditor` + `MarkdownAssistantDrawer` wired correctly via `toolbar` prop; `useArchitectDefaultRepo` plumbed through; `buildSkillAssistantUserMessage` called with correct args; both test files updated with the shared mock. CI data returned empty (no headSha, status unknown) — not treating as failure. Note: `submit_review` / `merge_pull_request` tools not available in this reviewer instance — verdict posted as comment only; dispatcher will not see a formal review event.

reviewer commented 2026-05-07 12:52:27 +00:00

Collaborator

Copy link

CI still pending at review time (run #3148, sha 6788f576). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3148, sha `6788f576`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-07 13:41:51 +00:00

reviewer refused to review 2026-05-07 13:42:57 +00:00

reviewer commented 2026-05-07 13:43:00 +00:00

Collaborator

Copy link

CI still pending at review time (run #3148, sha 6788f576). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3148, sha `6788f576`). Stepping off the review request — will be re-dispatched automatically when CI completes.

charles referenced this pull request from a commit 2026-05-07 13:45:35 +00:00

fix(agent-env-sync): fall back to built-in MCP default when DB command empty

charles referenced this pull request from a commit 2026-05-07 13:45:35 +00:00

fix(spec-editor): drop dead defaultMode/showModeToggle props

dev requested review from reviewer 2026-05-07 13:47:36 +00:00

reviewer refused to review 2026-05-07 13:48:30 +00:00

reviewer commented 2026-05-07 13:48:36 +00:00

Collaborator

Copy link

CI still pending at review time (run #1626, sha 6788f57). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #1626, sha `6788f57`). Stepping off the review request — will be re-dispatched automatically when CI completes.

charles requested review from reviewer 2026-05-07 13:49:15 +00:00

reviewer commented 2026-05-07 13:50:44 +00:00

Collaborator

Copy link

APPROVED

All ACs from #916 met: shared MarkdownEditor replaces the private CodeMirror one, toolbar prop wires the Assistant button → MarkdownAssistantDrawer, buildSkillAssistantUserMessage carries skill/agent/draft context, useArchitectDefaultRepo used for repo context. Both test files swapped to @/components/markdown-editor + MarkdownAssistantDrawer mocks correctly.

CI run returned status unknown with empty headSha — merge deferred to post-CI webhook path.

**APPROVED** All ACs from #916 met: shared `MarkdownEditor` replaces the private CodeMirror one, `toolbar` prop wires the Assistant button → `MarkdownAssistantDrawer`, `buildSkillAssistantUserMessage` carries skill/agent/draft context, `useArchitectDefaultRepo` used for repo context. Both test files swapped to `@/components/markdown-editor` + `MarkdownAssistantDrawer` mocks correctly. CI run returned status `unknown` with empty headSha — merge deferred to post-CI webhook path.

reviewer approved these changes 2026-05-07 13:52:00 +00:00

reviewer left a comment

Copy link

All AC from #916 met.

Nit (non-blocking): the module-level JSDoc at the top of skills-tab.tsx still references "CodeMirror 6 markdown editor (left) + live Markdown preview (right)" — update it to reflect Milkdown Crepe / shared MarkdownEditor when convenient.

All AC from #916 met. Nit (non-blocking): the module-level JSDoc at the top of `skills-tab.tsx` still references "CodeMirror 6 markdown editor (left) + live Markdown preview (right)" — update it to reflect Milkdown Crepe / shared `MarkdownEditor` when convenient.

reviewer commented 2026-05-07 13:52:20 +00:00

Collaborator

Copy link

CI still pending at review time (run #3148, sha 6788f57). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3148, sha `6788f57`). Stepping off the review request — will be re-dispatched automatically when CI completes.

charles requested review from reviewer 2026-05-07 13:53:11 +00:00

charles merged commit d336ab0e73 into main 2026-05-07 13:53:35 +00:00

charles deleted branch dev/916 2026-05-07 13:53:35 +00:00

charles referenced this pull request from a commit 2026-05-07 13:53:37 +00:00

feat(web): integrate shared MarkdownEditor + AI drawer into skills-tab (#920)

charles referenced this pull request from a commit 2026-05-07 15:10:17 +00:00

fix(forge-mcp): extract models cache so bun --compile bundle works

Sign in to join this conversation.

Reviewers

No reviewers

reviewer

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

dev

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/agent-hooks!920

No description provided.